One run in five on #120 reported "Unused crate: sha2", the crate
env_hash is built on, on a commit that changed only a Markdown file.
Every run's sanity check finds the Cargo project only partly loaded in
the linter's container, and the inspection sometimes concludes from
that. A baseline entry would not hold, because its fingerprint hashes
neighbouring lines that Dependabot rewrites weekly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The installed build from a fresh release dry run, against a real
--symlinks venv: added as itself with its own identity, listed beside
its base with its own packages, removed for good; a deleted venv's
broken row removed for good; the installed CLI agreeing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its python.exe links to the Python it was made from, and env_hash
followed the link, so the venv's pins, snapshots and cached graph,
report and audit were filed under its base. Nothing showed it while no
screen could list the two apart; Add interpreter now can. A venv's own
interpreter, recognised by its pyvenv.cfg, is resolved only up to its
folder. No other path's identity changes, and a linked venv's earlier
pins and snapshots stay with the base they were filed under.
Checked against a real --symlinks venv: `env use` stores the venv with
its own prefix, and the venv and its base keep two identities.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A venv made with --symlinks is run and stored as itself, not as the base
Python its python.exe links to: validate_interpreter returned the
canonical path, so `--env .venv update --all --yes` would have changed
the system Python. Canonicalizing now only decides where a link leads
and whether it is PipDock's own; a link to another program is refused,
and a Microsoft Store alias (os error 1920) is judged by its own path.
The GUI merges and removes an added row by its path rather than by
envHash, which follows links: a re-add replaces a broken row, removal
sticks for an entry whose file is gone (a share), and neither runs
during a scan. Added entries are validated again on every listing in
both heads (envs::probe_listed), and the CLI checks its stored default
when it uses it. `env remove` makes a typed path absolute first.
SECURITY section 2 and env_probe's doc claimed an enforcement point over
IPC; they now say what is checked, and backlog X36-b records the rest.
notify.yml reports a Triage failure on a pull request.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Found by running env list against this machine: the python.org
installer puts python3.14t.exe (PEP 703) beside python.exe, the registry
lists it, and the new name rule refused it — so Add interpreter… could
not add an interpreter discovery itself reports. A version may now end
in t; pythonw3.14t, pythont and python3.14tt are still refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README carries the status in both languages, CONTRIBUTING a 'Scope in
maintenance mode' section the triage bot links to, and ROADMAP a section
recording the decision: dependency, security, major-upgrade, defect and
wording work is taken; P1-7, X19, the engine caches and P2 are not
planned, each with its reason. The Audit backlog is the maintenance
backlog.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PRD P0-1, UI-SPEC §4, CLI-SPEC (env add/remove, their JSON, --env's new
refusal), CLI-GUIDE, ERROR-CATALOG (PD-ENV-001's new cases, and the
first button its advice ever had) and TESTING's golden count. SECURITY
§2 claimed for two milestones that interpreter paths were canonicalized
before use while the only check was existence; it now describes the
validator that makes it true. PRD also records P0-9's first-run uv
detection, P1-7 and P2 as not planned in maintenance mode.
legal/PRIVACY-POLICY.md 1.3 names the interpreter paths a person adds,
kept until removed, in both languages. With the repository URL it
already changed, the first-run gate shows once in 1.6.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PRD P0-1's manual browse, the last command NOT_YET owed (env_add_manual).
- envs::validate_interpreter, the enforcement point for every path a
person supplies: an existing file named python[X[.Y]].exe, not one of
PipDock's own tools or audit venvs (canonical, so .. cannot walk past),
returned canonical and without the verbatim prefix. A missing file reads
exactly as the probe's own message, so the CLI's goldens do not move.
- store v5: manual_envs, apart from the CLI's recents and default.
- scan_reporting appends the manual list last: discovery keeps its own
source, and an added interpreter whose file is gone stays listed, so
its PD-ENV-001 row can be removed.
- env_add_manual validates, probes, then stores; env_remove_manual takes
an entry off the list and touches nothing else. env_probe validates a
manual path too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repository now lives in the poli0981org organization, and this makes it at home there.
- main was red since 2026-11-18: RUSTSEC-2026-0543 (chrono), in Cargo.lock only through serde_with's weak features and compiled into nothing; ignored with its reason and exit condition.
- Supersedes #113–#118 (Rust 1.100.0, rusqlite 0.42.0, Tauri 2.12.6, code-health pins, actions, npm) plus jsdom 31.0.1; minimatch 11 closes GHSA-g3hv-75wg-m249. rfd 0.18 (#112) is held again until tauri-plugin-dialog moves.
- Dependabot's tauri groups never worked (it picks the most specific group); exclude-patterns on the catch-alls fix it.
- CI is self-contained: no workflow calls poli0981/.github; every action is pinned by commit; notify.yml vendors the Discord notifier.
- npm licences: scripts/check-licenses.mjs, deny.toml's allowlist for the npm half. Required, with cargo deny and tauri lockstep — eight required checks.
- Qodana in two parts (Rust, TS/JS), full scans, a triaged Rust baseline, fail on anything new. The Rust container needed its toolchain and CARGO_HOME pointed somewhere writable before it analysed anything.
- SonarQube Cloud analyses into poli0981org_pipdock; every npm ci runs with --ignore-scripts (S6505).
- Every repository URL points at the organization. README's attestation command for 1.4.0/1.5.0 had stopped working; it now says --owner poli0981 --signer-repo poli0981/pipdock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Visually-hidden text is position: absolute, and with no positioned ancestor
it is laid out against the viewport, outside every scroller above it. A pin
chip's hidden sentence did that on Pins: a long list made the whole window
scroll and took the header with it. Every parent of hidden text is relative.
- A run that failed before producing a summary rendered no <h1>, so the focus
rule had nothing to land on. The branch has a heading.
- The console drawer stays open across runs, so the next run mounts it with no
opener to return focus to. It falls back to the Console button.
- Under forced-colors the selection outline followed the focus ring at equal
specificity and replaced it on a focused current tab.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
changelog/1.x.md gains 1.5.0, written by reader: keyboard, screen reader,
contrast theme, everyone. It says that Narrator was not run again on this
release and that zoom was built and held back.
ROADMAP records the slice: the decisions and why, and the defects that were in
code with green tests and were found by driving the installed build over
WebView2's debugging port — the high-contrast border that had never been
drawn, the buttons that dropped focus when they went busy, the legal gate, two
accessible names. U45, U47 and U48 close; A1-A7 open, each with what it is
waiting for, and A7 is the testing only a person can do.
ACCESSIBILITY.md, UI-SPEC and TESTING are corrected to what the build actually
does: no zoom, a double border, busy as aria-disabled. CLAUDE.md carries the
rules the slice left behind and the recipe that found the defects.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
UI-SPEC §7 no longer describes a forced-colors list that is "not complete": the
mark is data-destructive. §8 gains the five rules the pass left behind — focus
on every screen replacement, names that contain the visible text, composite
widgets as one tab stop, chip meanings as text, status regions that exist
before their first message.
TESTING says which of the three new tests holds what, and that none of them
knows what a screen reader says; the manual charter gains a ten-minute
accessibility pass. CLI-SPEC writes down that the CLI has no colour and nothing
that animates, which was true of the code and stated nowhere.
RELEASE-CI: the conversation-resolution rule the protection table never listed,
the labels box that had been true for weeks, and .nvmrc, which still said 24 a
month after every workflow moved to 26.
README links the new files and gains Accessibility and Contributing sections.
AI-DISCLOSURE and About name the model that produced 1.5.0.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- cargo update (~60 bumps, 627 -> 616 crates) clears the yanked async-executor 1.14.0 that
had turned cargo audit red on main and on every Dependabot PR since 2026-11-03 (Linux-only,
never in the shipped binary). rusqlite 0.41.1 (SQLite 3.54.1), no code change. rfd 0.17 with
tauri-plugin-dialog 2.8.4, which met the rfd ignore's own condition, so the ignore goes.
- npm: thirteen packages to latest; TypeScript still held at 6.0.3 (typescript-eslint peers <6.1).
- Tools: ruff 0.17.3, certifi, msgpack, platformdirs; constraints regenerated.
- Actions: taiki-e/install-action v2.87.32, sonarqube-scan-action v8.4.0; Node 24 -> 26 LTS.
"Latest" means the newest release past each ecosystem's Dependabot cooldown.
- pip 26.3 renders an unloadable build backend as `error: backend-unavailable`, which fell
through to PD-BLD-003; a classifier rule restores PD-BLD-002. Found by the drift job; live
corpus re-captured with pip 26.3 / uv 0.13.7, the 26.2.1 capture frozen as pip-26.2/, and a
test holds both renderings to one code.
- Docs: ARCHITECTURE §10 re-verified, ERROR-CATALOG, TESTING, ROADMAP, CLAUDE.md.
Supersedes #97, #98, #99, #100, #101.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The analysis that first sent 1.4.0 still measured from 2026-09-27; the
next measured from the last analysis of the version before (2026-10-20).
The docs said the version did not move it at all. They now say when it
does, what that means for the merge carrying a release bump, and what
main's gate read after #91.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The first CI analysis of main failed its gate: 16 Rust bugs and new-code
coverage 78.3 % against 80 %, over all of 1.4.0 (sending a version did not
move the previous-version baseline).
- rust:S6677 x3: a failure's message is logged as `error`, not as a second
`message` field (CLI, update flow, app startup); golden.rs reads the
CLI's log to hold it, and failed first.
- rust:S7493 x13: std::fs inside async fns goes through tokio::fs (tools
venv sync, deptry's report, export/requirements/report commands).
- Tests for 1.4.0 code nothing drove: rollback end to end, forcing a
latest this Python cannot run, PEP 691 parsing (L55), user_file_error
(U25), a plan verified in another environment, PyPiReleases' cache, and
the plan/env stores' success and late-error paths. InstallSet::only had
no caller and is removed.
- ROADMAP, TESTING and CLAUDE.md record what the analysis found.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automatic analysis could not build, so it never analysed the Rust two
thirds of the code and imported no coverage; it also sent no project
version, leaving the previous-version new-code period anchored to the
first analysis. sonar.yml runs on Windows, produces cargo-llvm-cov and
vitest LCOV plus clippy's JSON, and scans with sonarqube-scan-action
v8.3.0 (pinned), passing the version from package.json. The token
reaches the scan step alone; the job is skipped without one (Dependabot,
forks) and refuses a dispatch off main, which this plan cannot analyse.
Unblocks the required audits, red on main since 2026-10-21:
rustls-webpki 0.103.16, webpki-root-certs 1.0.11, clipboard-win 5.4.3,
zod 4.6.7. Dependabot groups vitest with @vitest/*.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three things have kept CI red since 2026-10-18; none touches the shipped program.
- **cargo audit** (required on every PR, and the daily Security scan) fails on
RUSTSEC-2026-0370/0371/0372: zvariant, zbus_names and zvariant_derive were folded into
zbus 6 on 2026-10-16 and marked unmaintained the same day. zbus reaches the tree only
through tauri-plugin-opener and tauri-plugin-single-instance, for D-Bus on Linux;
`cargo tree -i zbus --target x86_64-pc-windows-msvc` prints nothing. Every release of both
plugins, the 3.0 alphas included, still requires zbus ^5.9, so there is no update to take.
Ignored individually in .cargo/audit.toml with that reason and a removal condition.
`cargo audit --deny warnings` is clean locally.
- **The Monday fixture-drift job** failed on pip/build-backend-failure/stdout.txt: pip 26
ends a finished bar with the bare elapsed time, not `eta 0:00:00`, so `_is_progress` let
the transfer rate through (15.1 MB/s committed, 75.1 MB/s on the next runner). The rule now
keys on a trailing time token. Old vs new over every committed fixture line: exactly this
one line changes verdict. The fixture is restored to `<PROGRESS>` in binary mode, 7 CRLF
before and after; its blob is again b349d1f, the pre-pip-26 bytes.
- **rfd**: Dependabot's 0.17.2 bump (#83) adds a second rfd to the binary, because
tauri-plugin-dialog 2.8.3 requires ^0.16 and src-tauri depends on rfd only because the
plugin already compiles it. dependabot.yml now ignores rfd >= 0.17 until the plugin moves.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Every spec checked against the code rather than against itself, in four passes that each read the
branch's commits and then the source:
- CLI-SPEC/CLI-GUIDE: one JSON document per command (with the per-command table and the paths
that print nothing), environment selection, logging, Ctrl-C and exit 130, the prompts as they
are rather than the [A]bort and countdown that never existed, `.heldBack`, a `pipdock audit`
section, and the rules every mutating command now follows.
- ARCHITECTURE/DATA-FLOW/ERROR-CATALOG: the Engine trait's real signatures, Requires-Python's
three checkpoints, store v4 and the log folder, §7's return types and events, the state machine
with re-probing and Force latest, where each §9 invariant is enforced, and 35 codes in 32 rows.
- SECURITY/TESTING/RELEASE-CI/CODE-HEALTH-SPEC: the PEP 668 override as built, four browser hosts
and the exact capability set, attested releases, the new CI, the tools constraints, and test
tiers that describe what runs rather than what was planned.
- UI-SPEC/PRD/README/I18N: the screens as they render, the keyboard, tokens and their contrast
sweep, the feature matrix's status, attestation instructions, and I18N's one stated exception.
ROADMAP gets the 1.4.0 record — what was wrong, what running found that reading did not, what was
deliberately not done — and the **Audit backlog**: every finding not fixed, with where it is and
why it waited. CLAUDE.md's counts and contradictions are corrected, with the rules this release
left behind. changelog/1.x.md has the 1.4.0 entry, including "Changed for scripts" and "You will
see this once". AI-DISCLOSURE, README and About say which model and who released what. The legal
documents' effective date moves to the release date.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The window (U21). It may now be maximized and snapped; the 1600x1100 cap is gone, and the content
column stops at max-w-content (87.5rem) instead, centred in what is left. The window is created
hidden and src-tauri/src/window.rs fits it to the monitor's work area before showing it: 1180x760
is taller than the work area of a 1920x1080 panel at 150% and of a 1366x768 laptop, so the status
line and the plan panel's Confirm opened under the taskbar. Never below 900x560; pinned to the
corner rather than centred off-screen when even that does not fit. UI-SPEC §5 says so.
The webview's grants (U1, U32). core:default granted some sixty core commands nothing called and
not core:window:allow-close, so Decline on the legal gate did nothing in the installed app while
its component test - which mocks close() - passed. default.json now holds exactly the five the
frontend calls, and a test in lib.rs pins the union of every capability file, plus the opener's
four hosts.
CSP (U56): object-src, base-uri and form-action 'none'. A release build's style-src drops
'unsafe-inline' - React sets styles through CSSOM, which CSP does not govern. index.html keeps it
for `npm run dev`, where Vite injects <style> elements; both policies are enforced, so the
stricter decides. To be confirmed on the installed build.
Language (U3): the choice is stored and applied at start. save() sent locale: null every time, so
choosing Vietnamese lasted until the window closed. Settings now load before the legal gate, so the
gate is in the chosen language too, and <html lang> follows the UI.
Keys: a screen's data-autofocus wins over the heading (U12) - Search's field lost focus to the
shell's effect, which runs after its children's - and `/` works from Search itself. Ctrl+1..9 by
e.code (U49): on AZERTY Ctrl+3 reports `"`. A release build swallows F5, Ctrl+R, Ctrl+P, Ctrl+F,
F3 and Alt+arrows (U20), which reloaded, printed and found in a single-page app.
Also: Security scrolls (U2); the legal gate shows a consent that cannot be recorded (U29); Report
bug asks for the link again with the environment, so the issue carries the Python and engine
versions, at one subprocess per click rather than per row (U31); the package table's header and
rows share one set of widths and one gutter, and narrow tables drop Size so names stay visible at
900px (U22, U23); the grid is focusable (Sonar S6852); --color-danger is #F26A63 and danger badges
use a 15% tint, with tokens.test.ts now compositing every badge tint over every surface (U46 -
3.92:1 before); test seeds typecheck instead of `as never`, the IPC mock uses the real isPdError
and has the audit cache entry (U10).
U14 and U26 were already fixed by earlier commits in this release.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The GUI writes data\logs\pipdock.<date>.log through the same core::logging the CLI uses, with
the panic hook installed, so a crash leaves a record where it used to leave nothing.
- A data folder that cannot be opened is said in a dialog before any window exists (U18). The
store was opened inside Tauri's setup hook, whose failure is a panic in the event loop: a
release build has no console, so the user double-clicked and nothing happened. It now opens
before Tauri starts, and the failure shows the code, the message and the log path through
rfd - already in the tree via tauri-plugin-dialog, so Cargo.lock gains one dependency edge and
no crate. It is the one place GUI copy is written in Rust (both languages at once), because no
webview exists yet to load a catalog.
- logs_tail returns LogTail { dir, lines } - a new schema, so schema-LogTail is blessed and
schema-unknown-type lists one more type. NOT_YET is down to one entry, env_add_manual.
- Settings gains a Logs row: the folder, as a path, and "Copy recent log", which re-reads the tail
at the moment of copying so the clipboard holds the run that just went wrong. The clipboard
permission "Copy full log" already had is enough; no capability changes. en + vi copy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
**PD-ENG-004 `EngTimedOut`.** Every engine command shares one watchdog, and when it fired the run
reported PD-INT-001 — "PipDock hit an internal error" — for an sdist build that was simply still
compiling, and in the batch phase that error aborted the whole run with no summary and no
per-package retry. A timeout is a fact about the engine, not a PipDock bug, so it gets its own
code. Raised by PipDock, never classified from stderr, so it joins the `internally_raised` table of
the corpus gate. The exec layer starts producing it in the next commit.
The nine places: the catalog variant (`as_str`, `area`, `ALL`), both count tests (34 → 35), the
corpus gate, both `errors.json` catalogues, `codes.json` and `generated.ts` (regenerated, not
edited), the ERROR-CATALOG row (31 → 32 rows), and the five schema goldens that embed `Code` —
`Code`, `StepResult`, `ExecutionSummary`, `HealthReport`, `AuditReport` — each re-blessed for
exactly one new `const`, which is the contract change this is.
**WinError needles include the closing bracket.** Python prints `[WinError N]`, and the bare
"winerror 5" also matched 50, 53 and 59: `[WinError 53] The network path was not found` came out
as PD-PRM-001, "use a venv". `[WinError 53]` and `[WinError 10013]` (a firewall refusing the
socket, raised *as* a PermissionError) now classify as network failures, ahead of the permission
rules that would otherwise take them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UI-SPEC §4 gains the screen and **loses the sentence it contradicted**.
It said the third row action folds all three into a `⋮` menu "with the
budget intact"; that makes uninstall four clicks where §5's table
records three, hand-counted. The correction is written as a correction
rather than an overwrite, because the reason it slipped through is the
useful part: four is under the ceiling of five, and a ceiling is not a
ratchet — a table of measured counts is. §5 gains the row, §6 the
component, ARCHITECTURE §4 the forward direction and the whole-graph
value.
**The dangling cross-reference is repaired by writing what it promised.**
`ROADMAP.md` has pointed at "the analysis above" for what blocks P1-6
and P1-7 since 1.2.0, and no such analysis was anywhere in the document
— the survey lived only outside the repository, and the sentence had
been copied into CLAUDE.md as well. P1-6's half is its slice record.
P1-7's is now written too, and counted against the tree rather than
recalled: no toast component, no notification/autostart/tray dependency,
one plan-scoped `tokio::spawn` and zero intervals in either head, and no
surface that can report a failure at 03:00 while `logs_tail` is still
`NOT_YET`. Drafting this commit I nearly shipped a CLAUDE.md line
claiming that survey existed before I had written it, which is the same
defect one layer up.
Version in five places, moved together: the workspace inherits it, so
`Cargo.toml`, `package.json` and `tauri.conf.json` are the only hand
edits and the two lockfiles are regenerated. Hand-editing `Cargo.lock`
would have been wrong twice over — `scopeguard` and `simd_cesu8` are
also at 1.2.0 and `fs_extra` was already at 1.3.0. `cargo metadata
--locked` passes, which is the one-command check.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`pin_suggestions`' shape, not `audit_run`'s. No `Sessions` slot, no
progress channel, no cancellation: those exist because an audit is
18-68 seconds, and a probe is 605 ms. Borrowing them here would be a
constant carrying its original units — the mistake `AUDIT_TIMEOUT`
already records.
One call per environment rather than one per package, which is the
whole reason the value is shaped this way. The view re-centres on a
click; a `deps_for(pkg)` command would read more naturally and pay a
probe for every click to answer a question the previous probe already
held the data for.
No store read, so there is no guard to drop — `pkg_list` is the same
and for the same reason. All five sites: the command, the handler list,
`COMMANDS`, the wrapper with `DepsGraph` added to the `import type`
list (`export type *` does not bring it into scope for a wrapper's own
signature), the `test/ipc.ts` mock, and ARCHITECTURE §7 — with its
trailing pipe, which the test added two commits ago now checks.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Found while surveying P1-6. None is caught by any suite, which is the
common thread rather than a coincidence.
`docs/ARCHITECTURE.md`'s `audit_run` row was the only row in the §7
command table missing its trailing pipe, so the table rendered wrong
from 1.2.0. Every gate passed: the command is registered, declared and
documented, and `documented()` strips only the *leading* pipe, so the
row parsed correctly and nothing looked at its shape. A spec sentence
is not a test — and neither is a spec table. The new
`the_architecture_table_is_well_formed` asserts the shape as well as the
contents, and was mutation-checked against the row it was written for.
`catalog.rs`'s comment read "Rust has 33; docs tabulates 30" three
lines above `assert_eq!(Code::ALL.len(), 34)`. Both numbers were one
behind; the doc tabulates 31, folding PD-HLT-001..004 into one row.
CLAUDE.md's error-code checklist named three schemas embedding `Code`
while saying "four", and 1.2.0 made it genuinely four by adding
`AuditReport` via `ToolProblem.code` — five snapshot files in all. So
anyone adding a code today would leave `golden__schema-AuditReport.snap`
stale. The line now says to grep `PD-ENV-001` across the snapshots
rather than trust the list, because that is how the omission was found.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Version in all five places — `Cargo.toml`, `Cargo.lock`, `package.json`,
`package-lock.json`, `tauri.conf.json` — and `cargo metadata --locked` verified after,
which is the one-command check that would have caught the `thiserror` lockfile
breakage that had `main` red for a day in Phase 4.
The ROADMAP stage record, and three rules in CLAUDE.md that the diff does not show:
- **A spec can promise a field that has never existed.** SECURITY §6 and PRD P1-1 both
asked for a severity pip-audit publishes under neither vulnerability service, and §6
named a venv the code had refused since P2. Found by running the tool and reading its
JSON, not by reading the specs against each other. When a spec describes an external
tool, the tool is the authority.
- **A watchdog is a unit, not a number.** Borrowing Code Health's 120 s gave an audit a
linter's budget for a network fetch, and it fired on the first real run. A borrowed
constant carries its original units with it.
- **Adding a field to a struct that is summed is a bug the suite will not see.**
`total_bytes` kept adding three entries after a fourth arrived, with every cache test
green.
Post-1.0 is down to two items: the dependency-graph view and the scheduled check.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two gaps the Security tab left, both of the same kind — a thing that exists on disk or
on screen that the rest of the app did not know about.
**The cache manager under-reported by a whole venv.** P1-1 put pip-audit in
`data\audit\`, and `cache::usage` knew only about `data\tools\`, so "clear the cache"
would have left one venv behind while reporting it gone. `Target::Audit` is a separate
variant rather than part of `Tools` for the same reason the venvs are separate: two
directories are two rows.
Fixing that turned up a second, worse one. `total_bytes` summed three entries and the
new field made four, so the total silently under-reported while **every existing test
passed** — the size on screen would have been wrong with nothing to say so.
`every_entry_reaches_the_total` now asserts on distinct powers of two, so a missing term
shows up as its own bit rather than as a number that merely looks plausible.
`PdCacheUsage`'s `entryOf` also became a lookup, because its ternary chain ended in a
hand-maintained negation that would have reported the tools venv's size on the audit row.
**And an audit could not be saved**, where Code Health writes Markdown and JSON beside a
chosen path. `audit_save_report` is `health_save_report`'s shape exactly, including both
of its reasons: Rust does the writing because `dialog:allow-save` asks for a path and
grants no `fs` permission, and the report comes from the frontend because what the user
asked to save is what is on their screen. `audit::markdown` lives in core so a future
`--format md` reuses it rather than growing a second renderer, and it states the source
at the top — an advisory database records what has been *reported*, which is what a
reader needs to judge an absence of findings.
Still owner-verifiable only: the save dialog itself, which needs the real Tauri runtime
rather than the stubbed bridge.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
SECURITY §6 has said since it was written that pip-audit "runs **from the tools venv**".
The code has refused that since P2, with three tests enforcing the refusal, because
`pip-audit`'s closure contains `msgpack` — no universal wheel, so a new CPython would
hard-fail the whole sync under `--only-binary=:all:` and take Code Health down with a
feature it does not use. §6 now describes the venv that exists.
**And neither §6 nor PRD P1-1 could have been implemented as written.** Both promised a
severity — §6 as "(CVE/GHSA id, severity, fixed-in)", the PRD as "severity-sorted" —
against a field pip-audit has never had under either vulnerability service. Running the
pinned 2.10.1 is what settled it: a finding carries `id`, `fix_versions`, `aliases` and
`description`, full stop. Both are corrected to the order that ships, which is package →
fixable → id, and both now say why a derived severity would be worse than none.
`osv.dev` joins the opener allowlist, which ROADMAP has flagged as owed since 1.1.0 —
without it every advisory link rejects and nothing opens, which is the silence SECURITY
§4 exists to name. The description records what makes this entry different from
`docs.astral.sh`: `PdHealthReport` hands over ruff's own `finding.url` verbatim, while
`audit::advisory_url` **builds** the URL from an id checked against a whitelist that
cannot contain a slash, colon, question mark, hash or percent. The tool chooses the id,
never the destination.
The three legal documents that said pip-audit is "not invoked in version 1.0" now say
what it does, and DISCLAIMER §4's forward-looking sentence is replaced by one about a
feature that exists: findings come from **PyPI's** advisory data, an advisory database
is a record of what has been reported rather than a guarantee, and PipDock assigns no
severity because pip-audit publishes none. **This re-shows the consent gate once** for
every existing user — the mechanism working, not a regression.
Also: UI-SPEC §4 gains the screen it has assumed since §3's diagram, §5 its click budget
counted in the running app, and §6's off-list inventory said *four* while naming five —
now six, plus the three from 1.1.0 it never named at all. CLI-SPEC §3 documents
`pipdock audit` and drops `doctor`'s promise of an audit summary it has never printed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Security tab's core reaches both heads. `AuditReport` joins `SCHEMA_TYPES`, which
is the six-place change the P1-A record describes — including `golden.rs`'s own copy of
the list, a new `golden__schema-AuditReport.snap`, and the expected churn in
`golden__schema-unknown-type.snap`, whose error message enumerates every known type.
`audit_run` takes the freeze itself, through the configured engine, because that choice
changes what is audited: pip is invoked with `--all` and includes pip and setuptools,
uv has no such flag. The real run makes that concrete — auditing the SP-4 environment
reports **five advisories in pip 25.0.1** alongside urllib3's eight, which a uv-engine
audit of the same environment would not see. The store guard is read and dropped before
any subprocess.
`AppState.audit` is `Sessions<()>`: nothing is parked, because an audit hands its report
straight back with no second call consuming it the way `health_fix` consumes a
`HealthSession`. What the slot is for is the **token**, which lives beside it so
`audit_cancel` can reach a run the slot no longer owns. Its own slot rather than
health's, for the reason health's is not `sessions` — an audit touches no environment,
so refusing it while Code Health runs would be a lock with no invariant behind it.
`pipdock audit` exits **1 on findings**, as `health` does: an advisory is a result, not
a failure, and a script wants to branch on it. A tool problem outranks the findings, so
a report that is empty because pip-audit never ran cannot exit 0 and read as "nothing
wrong here".
**Run rather than asserted.** Cold, against `spikes/out/target-env` with an isolated
`LOCALAPPDATA`: the audit venv bootstrapped, wrote its manifest, and reported 13
advisories across 2 packages; `--json` emitted **one** camelCase document with
`toolVersion` read back out of that manifest, and exit was 1. The second run did no
bootstrap at all, which is `needs_sync` returning `Fresh` for `AUDIT_TOOLS` — the half
of the venv split that only a warm second run can show.
Two hand-maintained lists were a row short and are not now: ARCHITECTURE §7, which the
new drift test demanded before it would pass, and `golden.rs`'s per-command help list,
which nothing polices — so `help-audit.snap` exists rather than the subcommand's help
going unpinned.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The stage table in ROADMAP's Post-1.0 section, plus three entries in CLAUDE.md that
are not derivable from the diff:
- a hand-written fixture that matches the documentation while the code does not is
worse than none, because it makes a test asserting the right thing prove the wrong
one — which is exactly how the doubled blocker sentence shipped for two milestones
under a green `PdPreviewDiff.test.tsx`;
- a sentence assembled in Rust is a sentence the other head assembles again, so
invariant 4 is not only about translation;
- `sed -i` must never touch `tests/fixtures/`: Git Bash rewrites in text mode and
strips the CRs that `.gitattributes`' `-text` exists to preserve.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
§7 opens with "A command that is not listed here does not exist; adding one means
amending this section in the same commit." The 1.1.0 P1 wave broke that rule five
times: `pin_suggestions`, `env_export`, `requirements_read`, `cache_usage` and
`cache_clear` are registered, wrapped and shipping, and appear nowhere in the
document. 35 rows against 38 registered commands.
The rows are added, and so is a fourth drift test. The three that existed police
`lib.rs`, `COMMANDS` and `NOT_YET` against each other and not one of them reads the
document making the promise — the assertion message of `every_registered_command_is_
declared` even claimed it did, so that message is narrowed to what it actually
checks. `documented()` parses §7's table the way `registered()` parses the handler
macro, and the new test runs both directions: a row for a command nobody registered
is the same lie as a command nobody documented, it just fails later. Checked by
deleting the `cache_clear` row, which fails it by name.
Two stale counts with it. `golden.rs` said "25 as of Phase 3 P3" and there are 30, so
the number is removed rather than reset — the list is directly below it and
`schema_lists_exactly_the_documented_types` already holds it to the binary's. CLAUDE
said 58 goldens; there are 64, now pinned to 1.1.0 per the counting-trap rule.
ROADMAP's screenshot note was **not** stale, which only looking established: the
seven pre-About shots really do show an eight-entry sidebar. The sentence just reads
as though `screenshot/` held seven files when it holds eight. Reworded, and while
there: `about.png` shows nine entries and a build panel reading 1.0.0, so every shot
is now stale in at least one way.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The guide said it was run against 1.0.0, which would leave a reader wondering whether
`pin suggest` exists. It does not: all four of 1.1.0's features are GUI-only, and the
guide now says so in a table with the nearest CLI equivalent for each, plus the note
that `pins::suggest`, `requirements::parse` and `cache::usage` are in core so a
subcommand is small when someone asks for one.
The README's feature table still described pin auto-suggest as a promise and did not
mention requirements files, disk usage or the palette at all. Also dropped "(v1)"
from its heading, which stopped being true at the tag.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Five places again — Cargo.toml, Cargo.lock, package.json, package-lock.json,
tauri.conf.json — and `cargo metadata --locked` earned its place in the checklist by
failing on the first attempt, exactly the way `main` was broken this morning. The
shipped CLI reports `pipdock 1.1.0`.
The stage record covers all four slices and the four things running them said that
reading could not: 94 suggestions on a real environment, a parser that turns prose
into a package name, a cache manager for a logs directory that does not exist, and a
palette that ranked an action above the screen it belongs to.
**One PRD row corrected rather than ticked.** P1-4 asked for the engine caches
(`pip cache`, `uv cache`) as well as PipDock's own. Those belong to the engine, live
outside `%LOCALAPPDATA%\PipDock\`, and purging them is a subprocess rather than a
file delete — a different feature wearing the same word. The row says "partly
shipped" and names what is missing, and the roadmap's open list carries it.
UI-SPEC §1's "signature moves" sentence stops saying the palette is P1; §8 gains
Ctrl+K; §4 gains the Disk usage section and why it lists three artefacts.
Two rules into CLAUDE.md, both paid for this afternoon: a parser correct for trusted
input is a hole for untrusted input, and check a thing exists before shipping a size
and a Clear button for it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Running it against `C:\Python314` — 352 packages, the scale fixture — the default
threshold of 5 qualifies **94 packages**. The ranking is right (setuptools at 150
dependents, then zope at 93, zope-interface at 86; it is a Plone environment and
those really are its workhorses) but a "Worth pinning" section with 94 rows is not a
suggestion, it is a second package list.
No unit test could have said this. The fixtures have six packages because that is
what proves the threshold logic; the usability of the result at scale is a property
of real dependency graphs.
**Raising the default would have been the wrong fix.** A deep tree is exactly where
a bulk update is most dangerous, so it is exactly where the feature has to work. The
screen shows the top 8 and says how many more qualify — `RUFF_ROWS_SHOWN`'s pattern,
including its rule that the count comes from the **full** list so a capped view never
misreports a total. `pins::suggest` is unchanged and still returns everything at or
above the threshold, which is what keeps it composable.
Measured in --release while there: probe **605 ms**, graph build plus the entire
suggest pass **1 ms**. The plan's worry about `dependent_count` being O(n·m) over 350
packages was unfounded — the subprocess dominates completely, and there is no case
for a batched counts method.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The stage record in the established shape, plus the estimate kept beside it for
comparison — its central claim held: most of pin auto-suggest was already written and
had never been called.
Three corrections, all found by doing the work rather than by planning it:
- **Six registration places for a new command, not five.** `golden.rs` keeps its own
copy of `SCHEMA_TYPES`, guarded by a test that reads the real list back out of the
binary. The checklist now says so, and says that blessing
`golden__schema-unknown-type.snap` is expected rather than suspicious.
- **`/hold/i` matches "threshold".** `PdPins.test.tsx` uses that pattern to prove the
screen offers no way to create a Hold pin, so any copy on Pins containing the
substring breaks a test about something else. Recorded in CLAUDE.md as the general
rule: grep a screen's test for regex assertions before adding copy to it.
- **`ReverseDeps::build`'s doc contradicted `dependent_count`.** Also recorded in
CLAUDE.md, generalised: a comment describing an intent nothing implements leaves
the next reader with two readings and no way to choose.
UI-SPEC §4 loses its `(P1)` marker and gains why the section sits above the list, why
it is silent on failure, and why the Settings label avoids one word. PRD P1-2 is
marked shipped with the in-force-edges qualifier. The rough edge that is deliberately
not fixed — unpinning re-offers — is written down rather than left to be rediscovered.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A count written into a file is wrong the moment the file is committed. This page
said 172/163, then 175/166, and both were stale before they were pushed — the edit
that corrected the number was itself the commit that invalidated it.
Pinned to `v1.0.0` instead, which does not move, with the arithmetic done so this
commit is the tag point. The note says why, because the next person to update it
will hit the same thing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The count is public evidence in an AI disclosure, so being off by one undermines
the thing it is there to demonstrate. The thirty-fourth was `app_info` fetching
twice per mount; the thirty-fifth was `self report-bug`'s stray whitespace, found
by reading its output while writing the CLI guide — no test asserts on that text
and no golden covers it, so nothing else could have caught it.
Commit numbers moved to the re-cut 1.0.0 tag, with a line telling the reader to
re-run the commands rather than trust two figures that go stale immediately.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Surveyed the real tree rather than the feature list, and three of the four turn out
to be mostly wiring. The survey is the deliverable — an estimate made from PRD line
items would be wrong in both directions.
**Pin auto-suggest is largely already written and never called.**
`graph::dependent_count` exists, is documented "for pin auto-suggest (PRD P1-2)", and
has no caller outside its own test. So does `PIN_SUGGEST_THRESHOLD = 5`, documented
"configurable" and read by nothing. What is actually missing is a settings key, one
command and a section on PdPins. Recorded with it: do *not* compute this in JS even
though the frontend holds `requiresDist` — the counts depend on marker evaluation and
extra-gated edge exclusion, and a JS copy would drift from the guard that shares
those edges.
**Requirements export is nearly free; import is a parser.** A snapshot's freeze
document already is a requirements.txt, and `Intent::Install { specs }` is the
install-many flow PdSearch already drives. The work is a tolerant line parser —
`-r`/`-c`, `--hash`, extras, markers — and the note that matters is: do not widen
`snapshot::pin_of` to get it. Its narrowness is what makes it the exact complement of
`unrestorable_lines`.
**The cache manager needs its scope corrected before it is estimated.** There are no
log files: `LOG_RETENTION_DAYS` has no reader, the only log is an in-memory ring
buffer, and `logs_tail` is still NOT_YET. So it covers three artefacts, not four —
and `index.db` cannot be a delete target because it holds settings and pins too. It
also introduces the first delete-a-tree primitive in production code, which makes the
under-app_data assertion the real work rather than the UI.
**The command palette is frontend-only and Ctrl+K collides with nothing** — verified
against all ten existing bindings. It is a silent no-op today because `parseInt('k')`
is NaN. Two rules written down so it does not reintroduce solved bugs: refuse while
PANEL_PHASES owns the screen, and refuse behind the legal gate including About's
review mode. Also: write a matcher, do not route palette queries through
`index_search` — that searches 864k package names over IPC, wrong corpus and wrong
cost for thirty actions.
Ends with the ten-place checklist for adding an IPC command, which two of the four
need.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
**AI disclosure.** PipDock was written with substantial help from Claude Opus 5
(Anthropic, via Claude Code), and the fact was only visible as a commit trailer.
`docs/AI-DISCLOSURE.md` is the full statement — model, vendor, period, what it wrote
(source, tests, debugging, the VI catalogue), what review actually meant, what was
not delegated, and how to verify any of it from `git log`. 172 commits, 163 with the
trailer.
It also says the thing worth saying: a green suite was never sufficient. Thirty-four
defects reached or nearly reached `main` and not one was caught by the suite that was
green at the time.
Three surfaces, because three different people look in three different places: the
README for someone browsing the repo, `docs/` for someone reading the code, and the
**About tab** for someone who installed the app and will never open GitHub. The last
one needed keys in both catalogues.
**`docs/CLI-GUIDE.md`.** CLI-SPEC is the contract; this is what you type. Written
against `pipdock 1.0.0` by running every command rather than by reading the spec —
which is how the exit codes in it were confirmed (`PD-ENV-001` really is 3, `schema`
on an unknown type really is 1) rather than copied.
That also turned up a defect: `self report-bug` printed **fourteen stray spaces** in
the middle of a sentence, because a multi-line string literal keeps its source
indentation. Nobody had read the output.
Also: `About.png` -> `about.png` so the seven screenshots share one convention, and
the About shot joins the README.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
All six open items are done, recorded with what was actually exercised rather than
"the charter was run": three machines (a real Windows 11 box that had never run
PipDock, Windows Sandbox, a Windows 10 VM), no SmartScreen prompt on any — with the
caveat that reputation is per-hash and unsigned binaries can still warn a future
user, which is why the checksum instructions stay. The three owed charter items plus
a non-ASCII Windows *username*, which is a different case from the non-ASCII path
because the username is in %LOCALAPPDATA% and therefore in the data root, the logs
and the tools venv.
The icon is a decision now, not a deferral. It was called a placeholder because
nobody had chosen it.
RELEASE-CI §5 ticks all eight, and three of the last four turned out to be already
done and never ticked — CodeQL default setup was already not-configured, Discussions
were already on, the secrets were set today. §2's "main protected" claim is true for
the first time; its exact settings, the reason CI / Integration is excluded (a
paths-filtered required check never starts, so it blocks forever), the two contexts
owned by the ops repo, and how to unwedge it are all written down.
Also recorded: the four things Phase 4 found that were not on its list, and the three
rules the About tab settled. Post-1.0 gains the Third-Party-Notices generation
deferred here, a screenshot re-capture, and the OSV host the Security tab will need.
Two long-standing self-contradictions fixed: NOT_YET is two (lib.rs is the
authority; ROADMAP and CLAUDE.md each said two in one paragraph and three or four in
another), and 15 of UI-SPEC §6's 16 components exist, not 16.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
UI-SPEC §4 has specified *Legal & About* since the spec was written, as a section
inside Settings, and four milestones shipped without it. That is what folding a
read-only surface into a screen of controls does. It is now the ninth tab.
**The ninth tab cost nothing.** `App.tsx` reads `NAV_KEYS[key - 1]`, so appending
`about` made it Ctrl+9 without moving one existing binding. UI-SPEC's warning was
about *inserting* — which is still true, and is still why Snapshots is a mode of
Environments: it would have to sit beside Environments to read as related. The
comments in four files said "a ninth entry would renumber Ctrl+1..8"; they now say
what the rule actually is.
Contents: what PipDock does and what it does not collect; version and the legal-docs
hash from `app_info` — a command that has existed since M1 with no consumer, so the
version on screen cannot drift from CARGO_PKG_VERSION; the SPDX identifier
`GPL-3.0-only` rather than the looser "GPL-3.0" elsewhere; a control that puts the
gate back; and contact.
**Addresses are copied, not opened.** `mailto:` would widen the opener capability by
a whole URL scheme, and the scope's real job is bounding the two call sites that pass
data — one of which hands over a URL that came out of ruff's JSON. Clipboard-write is
already granted, works with no mail client, and the address has to be on screen
anyway. Only `https://poli0981.dev/*` was added, for the links page. They are also TS
constants rather than catalog entries: an address is data (I18N §2), and a catalog is
a thing a translator is invited to change.
**`review` is a flag of its own, not `accepted = false`.** Re-using the latter was
one line and would have made a review indistinguishable from a revocation — offering
Accept, and a Decline that closes the application, to someone who wanted to re-read
their privacy policy. The gate takes a presentational prop instead; first-run
rendering is untouched and `PdLegalGate.test.tsx` (its first test, ever) pins that.
Two things found by running rather than by the suite:
- `app_info` fired **twice** per mount under `npm run dev`. StrictMode's doubling is
dev-only, but it drew attention to the real one: `key={nav}` remounts `<main>`, so
every visit to About was a fresh call for a value baked in at compile time. Now
cached per process in `useAppInfo`. Verified against the bridge log: one call.
- The whole seam — About, re-open, Ctrl+3 refused behind the modal, Close, back on
About — with zero IPC calls, confirming consent is never touched.
VI catalog complete and checked in the running app; the parity gate gets the rest.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`legal/THIRD-PARTY-NOTICES.md` was not the only document listing a dependency the
project deliberately does not have. ARCHITECTURE §9, TESTING §3 and CLAUDE.md all
still say types are generated with specta/tauri-specta; `bindings.rs` has recorded
since M1 that they are not, and why. Each now says what actually happens and points
at that file — including the consequence, which is that drift is a `cargo test`
failure rather than a compile error.
PRD G7 carried the same stale claim as the privacy policy: "network traffic limited
to PyPI + GitHub Releases", from before the self-updater was removed.
SECURITY §7 repeated the `cargo about` / `licenses/` claim; §8's reset advice
pointed at "Settings -> Legal & About", a screen that has never existed; §9 promised
a root SECURITY.md that was never written. The last one is now `.github/SECURITY.md`
— a short pointer so GitHub's Security-policy tab is not empty — carrying the
advisory URL and code@poli0981.dev.
SECURITY §4 gains the poli0981.dev entry ahead of the About tab that needs it, per
its own rule that an allowlist widening belongs in prose and not only in
capabilities/. It also now says what the scope actually defends: the two call sites
that pass data rather than constants, one of which hands over a URL that came out of
ruff's JSON. That is the argument for copying the contact addresses to the clipboard
instead of adding a mailto: scheme.
README dropped a "(add the standard GPL-3.0 text at repo creation)" instruction that
had been shipping for three milestones after the text was added.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI's Node job failed on the test I had just added: `TS2322` on an `ExecutionOutcome` literal
that was missing `appVersion` and carried three fields `SnapshotMeta` does not have. Vitest
does not typecheck, so `npm test` passed — and I ran the suite and the linter after adding the
file but **not `npm run typecheck`**, which is the one gate that could see it.
Now taken from `snapshot_list.json`, which is the pattern the rest of the suite already uses
and the reason it exists: a fixture serialized from the real Rust type cannot drift from it,
and a literal typed by hand can be wrong in three ways at once.
Also records the Phase 4 state for whoever picks this up: what the pipeline can now do, and
the six things still open — a genuinely clean machine, SmartScreen, the rest of the manual
charter, the icon, the version and RC tag, and README screenshots. CLAUDE.md gains the two
rules this stretch established: building and installing are their own test tier, and the seam
between a tested component and its untested parent is where bugs live.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
UI-SPEC gains the three rules the first installed build established, and each is written with
what was measured rather than what was intended.
Single instance: five launches, **one process, one window** — checked against the installed
build after rebuilding, because a plugin registered in the wrong order fails silently by
simply not being reached.
Maximize: the window style no longer carries `WS_MAXIMIZEBOX` and still carries
`WS_THICKFRAME`, so it is bounded without being frozen — read off the real `HWND` rather than
inferred from the config that asked for it.
Sidebar-disabled-during-a-plan is recorded beside §8's existing `Ctrl+1..8` rule, since they
are the same rule for two input devices and a reader who finds only one will assume the other
was an oversight.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI caught two things the previous commits broke, and the first is pointed: I declared the CLI
sidecar in `tauri.conf.json`, and **`tauri-build` validates `externalBin` at build-script
time** — so plain `cargo clippy` and `cargo test` on `pipdock-app` began failing in a fresh
clone with *"resource path `binaries\pipdock-x86_64-pc-windows-msvc.exe` doesn't exist"*.
It passed locally only because I had already staged the file. That is exactly the "works on
my machine" failure the commit that introduced it claimed to be preventing.
`externalBin` moves to `src-tauri/tauri.bundle.conf.json`, merged with `--config` only when
bundling. Compiling the app does not need the sidecar; bundling it does, and the config now
says so. Verified the way it should have been the first time: **`src-tauri/binaries/` deleted**,
then `cargo clippy -p pipdock-app --all-targets` and `cargo test --workspace` both clean —
and `npm run bundle` from that same state stages the sidecar and produces two installers, the
NSIS payload still carrying `pipdock-app.exe` and `pipdock.exe`.
The whole recipe now lives in one `npm run bundle` script the workflow calls, so nobody has
to remember that `--locked` goes after `--` or that the overlay exists. RELEASE-CI §3.1
records both traps rather than just the command.
Second breakage: `ci-integration.yml` hardcoded `%LOCALAPPDATA%\PipDock\tools` in three
places — it quarantines `ruff.exe` there to prove `PD-HLT-001` — and the data root had moved
under `data\`. A test that reaches into a path by hand is a test that has to be told when the
path moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Phase 4 record now carries all three defects the bundle exposed, the uninstall behaviour
that was tested rather than assumed, and — the part that matters most — an explicit list of
what was **not** verified.
Three things are still owed and need a human at the keyboard: the OS folder picker, a ruff
rule link (the `docs.astral.sh` allowlist entry fails *silently* if wrong), and the fix
dialog. The screenshot tooling resolves the installed app to a virtualized sandbox path and
masks its window, so it could not be driven from here. SmartScreen was not exercised either —
the installer was run scripted, and SmartScreen is an Explorer behaviour, so a scripted run
proves nothing about it.
And the criterion itself is only approximated: this machine has run PipDock before, so
isolating the app-data root is not the same as a machine that never has.
Charter progress recorded with numbers rather than ticks: a non-ASCII project path
(`E:\sp5\dự án tiếng việt`) runs all three Code Health tools with the path intact, and
`pipdock list` is 1.1 s over a 145-package venv and 1.5 s over a 352-package system Python.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Installing the first bundle put `pipdock-app.exe`, `pipdock.exe` and `uninstall.exe` into
`%LOCALAPPDATA%\PipDock` — the same folder as `index.db`, `snapshots\` and `tools\`, because
Tauri's NSIS per-user installer writes to `$LOCALAPPDATA\{productName}` and
`store::default_app_data()` derived from the same name.
SECURITY §8 tells users that deleting the app data folder is a complete reset. With the two
collided, following our own documented advice would have uninstalled the application.
The data root moves to `%LOCALAPPDATA%\PipDock\data\`. Changed now because it is still free:
**no release has ever been published**, so there is no on-disk layout in the world to migrate
and no migration code belongs here — a `default_app_data()` that checked for a legacy
location would be dead code from its first commit.
`APP_DATA_SUBDIR` is a second constant rather than `"PipDock/data"` in one join: a path built
from a literal containing a separator reads differently depending on the platform's idea of
one, and every comparison against it inherits that.
Verified by moving this machine's real data and asking the binaries to find it: `tools status`
reports `…\PipDock\data\tools` and *up to date with the pins shipped in this build*, and
`search` still answers out of the 53 MB index.
Two doc paths were also corrupted, by me, in earlier commits: `\PipDock\tools` written through
a Python patch became `PipDock<TAB>ools` in SECURITY §2 and ROADMAP. Fixed here rather than
left for a reader to puzzle over.
The uninstall behaviour is recorded in SECURITY §8 because it was tested rather than assumed:
uninstalling removes its own binaries, the Start-menu shortcut and the registry entry, and
leaves the data directory untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`npx tauri build --locked --bundles nsis,msi` fails with *"unexpected argument '--locked'
found"* before a single crate compiles. `--locked` is **cargo's** flag; `tauri build` passes
everything after `--` to the runner. No `v*` tag has ever been pushed, so the release job had
never executed and this had never surfaced.
Found by building the bundle on the dev machine for the first time — which is the whole point
of Phase 4, and which took one command to expose a pipeline that would have failed on the
tag that was meant to ship v1.
Also removed a duplicated frontend build: `tauri build` runs `beforeBuildCommand`, which is
already `npm run build`, so vite ran twice per release for no benefit. RELEASE-CI §3.1 now
describes the command that exists rather than `cargo tauri build --locked`, which has the
same flag problem.
**Verified against real artifacts**, not just re-read: the corrected command produces
`PipDock_0.1.0_x64-setup.exe` (5.7 MB) and `PipDock_0.1.0_x64_en-US.msi` (7.6 MB) in 3m48s,
and the workflow's own collect and checksum steps, run verbatim in PowerShell, emit a correct
`SHA256SUMS.txt`.
The README gains the badges RELEASE-CI §5 asks for, loses a status line that still said
*design phase*, and gains the command that makes "verify the SHA-256 checksum" actionable —
tested against the real file, and it reproduces the published sum.
One correction there is not cosmetic: the feature table claimed network traffic goes to
"PyPI (package data) and GitHub (app updates)". **PipDock has no self-updater** — SECURITY §5
removed it deliberately, and the paragraph two lines below the table says so. PyPI is the
only host it connects to; GitHub and the ruff docs are only ever handed to the browser as a
link the user clicked.
ROADMAP records both the build numbers and the blocker the build exposed — see the next
commit's absence: the installer ships no CLI, and fixing that needs an owner decision.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The exit criterion was *"CODE-HEALTH flows pass on two real projects (one pyproject, one
requirements-only)"*. Both are recorded in the stage table with times from a release build
rather than ticked: a requirements-only project reports 1 dependency, 3 dead-code and 3 lint
findings in 1.4 s; one declaring nothing reports `ran: [vulture, ruff]` with an empty
`problems` in 1.3 s, because deptry cannot answer its question there and is correctly not
run. The fix path's three refusals were exercised on a seeded repository.
UI-SPEC §8 gains the two rules P6 established and the reason each exists: `←`/`→` are the
ARIA grid pattern's roving tabindex, added because making the row the only tab stop had left
*Pin* and *Remove* reachable by mouse only; and `Enter` on a row is the non-destructive
primary, because a row has one reversible annotation and one irreversible removal.
CLI-SPEC §6's amendment said *"`health` is still the M3 stub"* — stale since P3, and now
carrying the `--fix` output contract instead.
CLAUDE.md records the tab-stop rule beside the other things this project learned by running,
and the status line moves to Phase 4.
**Still owed, and it needs the real Tauri runtime rather than the stubbed bridge:** the OS
folder picker, a ruff rule link (to confirm the `docs.astral.sh` allowlist entry actually
works — it fails silently if not), and the fix dialog end to end. All three are named in the
ROADMAP so they are not rediscovered.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
DATA-FLOW gains **invariant 6** and §9.1's state machine. §9.1 and §9.2 are scoped to a
mutating *engine* call and do not reach `ruff check --fix`, which rewrites the user's source
tree — a thing no snapshot in this application describes, so one taken here would have no
consumer that could use it. That is invariant 2's own argument for the pip-upkeep exemption,
a second time, and like that one the exemption is **made visible rather than silent**: the
confirm states that PipDock cannot undo the change and that only the user's version control
can. The fifth proof shape is a `HealthReport` plus a server-checked `FixConsent`.
**A SECURITY paragraph was ahead of the code, and the code caught up rather than the
paragraph coming back.** §2 now says the project folder is canonicalized, existence-checked,
and refused when it resolves inside PipDock's own tools directory — so `validate_project`
exists, `..` is handled by comparing canonical paths rather than strings, and running Health
against `%LOCALAPPDATA%\PipDock\tools` answers `PD-ENV-003`. ruff would otherwise have
rewritten PipDock's own venv, and that failure would have looked like a corrupted install
rather than like the fix that caused it.
§2 also records the git resolution finding: this is the one place PipDock runs a
PATH-resolved program with a user-controlled working directory, and a planted `git.exe` does
**not** win — verified by planting one, not by reasoning about `CreateProcess`. §8 gains the
one exception to "all state is local".
CODE-HEALTH-SPEC §5 replaces "recommends a clean git tree" with what was built. CLI-SPEC §3
carries the `--yes` rule where someone reading the flag will see it. UI-SPEC §5 gains the fix
row and §7 names the confirm alongside the other three destructive ones, with the
forced-colors requirement each of them shares. ARCHITECTURE §7 gains `health_dirty`.
CLAUDE.md's waiver list goes 2 → 3, and the no-snapshot decision is written where the next
person will look for it rather than left to be re-derived.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>