fix(ci): a release workflow that had never been run, and could not have worked

`npx tauri build --locked --bundles nsis,msi` fails with *"unexpected argument '--locked'
found"* before a single crate compiles. `--locked` is **cargo's** flag; `tauri build` passes
everything after `--` to the runner. No `v*` tag has ever been pushed, so the release job had
never executed and this had never surfaced.

Found by building the bundle on the dev machine for the first time — which is the whole point
of Phase 4, and which took one command to expose a pipeline that would have failed on the
tag that was meant to ship v1.

Also removed a duplicated frontend build: `tauri build` runs `beforeBuildCommand`, which is
already `npm run build`, so vite ran twice per release for no benefit. RELEASE-CI §3.1 now
describes the command that exists rather than `cargo tauri build --locked`, which has the
same flag problem.

**Verified against real artifacts**, not just re-read: the corrected command produces
`PipDock_0.1.0_x64-setup.exe` (5.7 MB) and `PipDock_0.1.0_x64_en-US.msi` (7.6 MB) in 3m48s,
and the workflow's own collect and checksum steps, run verbatim in PowerShell, emit a correct
`SHA256SUMS.txt`.

The README gains the badges RELEASE-CI §5 asks for, loses a status line that still said
*design phase*, and gains the command that makes "verify the SHA-256 checksum" actionable —
tested against the real file, and it reproduces the published sum.

One correction there is not cosmetic: the feature table claimed network traffic goes to
"PyPI (package data) and GitHub (app updates)". **PipDock has no self-updater** — SECURITY §5
removed it deliberately, and the paragraph two lines below the table says so. PyPI is the
only host it connects to; GitHub and the ruff docs are only ever handed to the browser as a
link the user clicked.

ROADMAP records both the build numbers and the blocker the build exposed — see the next
commit's absence: the installer ships no CLI, and fixing that needs an owner decision.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
poli0981andClaude Opus 5 committed 2026-08-13 20:59:43 +07:00
1 parent 4720e1ccb5
commit 1aee0bea6b
4 files changed
+52 -8

No files matched your search

+7 -4
View File
@@ -59,11 +59,14 @@ jobs:
- name: Install frontend dependencies
run: npm ci
- name: Build frontend
run: npm run build
# No separate frontend step: `tauri build` runs `beforeBuildCommand`, which is
# `npm run build`. Having both meant vite ran twice per release for no benefit.
- name: Build and bundle
run: npx tauri build --locked --bundles nsis,msi
# `--locked` is **cargo's** flag, not `tauri build`'s: everything after `--` is passed
# to the runner. Written the other way round it fails with "unexpected argument
# '--locked' found" before a single crate is compiled — and since no `v*` tag has ever
# been pushed, this workflow had never run to find out.
run: npx tauri build --bundles nsis,msi -- --locked
- name: Collect artifacts
shell: pwsh
+15 -3
View File
@@ -1,8 +1,14 @@
# PipDock
[![CI · Rust](https://github.com/poli0981/pipdock/actions/workflows/ci-rust.yml/badge.svg)](https://github.com/poli0981/pipdock/actions/workflows/ci-rust.yml)
[![CI · Node](https://github.com/poli0981/pipdock/actions/workflows/ci-node.yml/badge.svg)](https://github.com/poli0981/pipdock/actions/workflows/ci-node.yml)
[![CodeQL](https://github.com/poli0981/pipdock/actions/workflows/codeql.yml/badge.svg)](https://github.com/poli0981/pipdock/actions/workflows/codeql.yml)
[![Release](https://img.shields.io/github/v/release/poli0981/pipdock?display_name=tag&sort=semver)](https://github.com/poli0981/pipdock/releases)
[![License: GPL-3.0](https://img.shields.io/badge/license-GPL--3.0-blue)](LICENSE)
**A friendly dock for your Python environments.** Inspect, install, update, and clean up Python packages in bulk — through a keyboard-first GUI or a scriptable CLI — without ever hand-typing another `pip install` incantation or guessing why an upgrade broke your project.
> Repo: `poli0981/pipdock` · License: **GPL-3.0** · Platform: **Windows 10/11 (v1)** · Status: **design phase**
> Repo: `poli0981/pipdock` · License: **GPL-3.0** · Platform: **Windows 10/11 (v1)** · Status: **pre-release** — every v1 feature is built; the release pipeline and the manual charter are what remain
---
@@ -33,7 +39,7 @@
| pip upkeep | Check & update pip itself per environment |
| CLI | `pipdock` — full parity for core operations, JSON output, CI-friendly exit codes |
| i18n | English + Tiếng Việt |
| Privacy | No telemetry. Network traffic goes only to PyPI (package data) and GitHub (app updates) |
| Privacy | No telemetry. **PyPI is the only host PipDock connects to.** It does not check for updates, so it never calls home — GitHub and the ruff docs are only ever handed to your browser as a link you clicked |
## Install
@@ -41,7 +47,13 @@ Download the installer (NSIS `.exe` or `.msi`) from [GitHub Releases](https://gi
PipDock does not update itself — grab a new build from the same page when you want one. That is deliberate: a self-updater is a standing remote-code-execution path into a tool that already runs subprocesses against your interpreters, and it is not worth the convenience (see [docs/SECURITY.md](docs/SECURITY.md) §5).
> Windows SmartScreen may warn on first run because binaries are not EV-code-signed. Verify the SHA-256 checksum published with each release.
> Windows SmartScreen may warn on first run because the binaries are not EV-code-signed. Every release publishes `SHA256SUMS.txt`; verify your download against it before running:
>
> ```powershell
> (Get-FileHash .\PipDock_1.0.0_x64-setup.exe -Algorithm SHA256).Hash.ToLower()
> ```
>
> Compare that against the matching line in `SHA256SUMS.txt`. If they differ, do not run the file.
## Quick start
+1 -1
View File
@@ -42,7 +42,7 @@ Dependency updates use **Dependabot** (`.github/dependabot.yml`) — the portfol
## 3. Release pipeline (tag `v*`)
1. Windows runner: `npm ci && vite build` → `cargo tauri build --locked` producing NSIS `.exe` + `.msi`.
1. Windows runner: `npm ci` → `npx tauri build --bundles nsis,msi -- --locked` producing NSIS `.exe` + `.msi`. **The `--` matters**: `--locked` is cargo's flag and `tauri build` rejects it as its own. The frontend is built by tauri's `beforeBuildCommand`, so the workflow does not run `vite build` itself.
2. Compute and publish `SHA256SUMS.txt`.
3. Draft GitHub Release with generated changelog; manual publish (owner review) → `announce-release.yml` fires the Discord announcement.
4. Post-release checklist issue auto-opened: verify SmartScreen behavior, spot-check EN/VI in the shipped build.
+29
View File
@@ -570,6 +570,35 @@ Six commits. Code Health has an environment to run in, and `PD-HLT-001`'s shippe
Release pipeline live (bundling, checksums), manual charter executed, docs/README screenshots, legal files public, a clean install of the RC verified on a machine that has never run PipDock. **Exit:** RELEASE-CI §5 checklist fully checked; v1.0.0 published + notify fan-out.
### First bundle built locally — 2026-08-13
`npx tauri build --bundles nsis,msi -- --locked` on the dev machine, 3m48s, producing
`PipDock_0.1.0_x64-setup.exe` (5.7 MB) and `PipDock_0.1.0_x64_en-US.msi` (7.6 MB). The workflow's
collect and checksum steps were then run verbatim against those artifacts and produce a correct
`SHA256SUMS.txt`; the README's verification one-liner reproduces the published sum.
**Two defects, both invisible until something was actually built.**
1. **`release.yml` could not have worked.** `npx tauri build --locked --bundles nsis,msi` fails with
*"unexpected argument '--locked' found"* before a single crate compiles — `--locked` is cargo's
flag and everything after `--` is what reaches the runner. No `v*` tag has ever been pushed, so
the release job had never run. Fixed, along with a duplicated frontend build step (`tauri build`
already runs `beforeBuildCommand`).
2. **The installers ship the GUI only.** `tauri.conf.json` declares no `externalBin` and no
`resources`, so the NSIS payload is exactly `pipdock-app.exe` and the MSI's `app.cab` holds one
file. **`pipdock.exe` is not installed at all** — while PRD P0-12 is "CLI core parity", CLI-SPEC
documents the whole surface, and the README's own Quick start tells the user to run
`pipdock env list`. A real install leaves none of that on the machine. **This is a v1 blocker**
and the fix needs an owner decision, because the options differ in how much they touch the
user's system: ship the CLI beside the GUI and leave `PATH` alone; ship it and have NSIS extend
`PATH`; or publish it as a separate archive on the release.
**First-run behaviour was verified against a throwaway app-data root** (`LOCALAPPDATA` redirected):
the app creates `PipDock\index.db` from nothing and spawns a WebView2 host, so the packaged
frontend loads. Note the honest limit — **this machine has run PipDock before**, so isolating the
app-data root approximates the "never run PipDock" criterion rather than meeting it. A genuinely
clean machine is still owed, and so is running the installer itself: nothing here was installed.
## Post-1.0 (P1 wave)
Security tab (pip-audit), pin auto-suggest, requirements/constraints export-import, cache manager, command palette, dependency graph view, scheduled check. Then P2 candidates by demand: macOS/Linux, per-env engine, elevation broker, winget, JP locale.