A venv made with --symlinks is run and stored as itself, not as the base
Python its python.exe links to: validate_interpreter returned the
canonical path, so `--env .venv update --all --yes` would have changed
the system Python. Canonicalizing now only decides where a link leads
and whether it is PipDock's own; a link to another program is refused,
and a Microsoft Store alias (os error 1920) is judged by its own path.
The GUI merges and removes an added row by its path rather than by
envHash, which follows links: a re-add replaces a broken row, removal
sticks for an entry whose file is gone (a share), and neither runs
during a scan. Added entries are validated again on every listing in
both heads (envs::probe_listed), and the CLI checks its stored default
when it uses it. `env remove` makes a typed path absolute first.
SECURITY section 2 and env_probe's doc claimed an enforcement point over
IPC; they now say what is checked, and backlog X36-b records the rest.
notify.yml reports a Triage failure on a pull request.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Qodana for JS (JSNonASCIINames, High): a variable named in Vietnamese
mixed ASCII and non-ASCII. The text it holds is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
triage.yml labels a feature request enhancement and out-of-scope,
answers in English and Vietnamese with CONTRIBUTING linked, and closes
it as not planned — on unmistakable signals only: a title that says it
is one, a feat: pull request, or the enhancement label going on.
Maintainers, bots and policy-exception are never closed. The rules live
in .github/scripts/triage.cjs with node --test cases (run by npm
licences); pull_request_target checks out only the base branch's
scripts; workflow_dispatch is a dry run. notify.yml hears about it.
Templates: a Wording or translation form (i18n), a contact link saying
features are not taken, a maintenance note on the bug form, and the
kinds of change a pull request can be. eslint.config.js lints the
CommonJS helper as Node, outside the type-aware program.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repository now lives in the poli0981org organization, and this makes it at home there.
- main was red since 2026-11-18: RUSTSEC-2026-0543 (chrono), in Cargo.lock only through serde_with's weak features and compiled into nothing; ignored with its reason and exit condition.
- Supersedes #113–#118 (Rust 1.100.0, rusqlite 0.42.0, Tauri 2.12.6, code-health pins, actions, npm) plus jsdom 31.0.1; minimatch 11 closes GHSA-g3hv-75wg-m249. rfd 0.18 (#112) is held again until tauri-plugin-dialog moves.
- Dependabot's tauri groups never worked (it picks the most specific group); exclude-patterns on the catch-alls fix it.
- CI is self-contained: no workflow calls poli0981/.github; every action is pinned by commit; notify.yml vendors the Discord notifier.
- npm licences: scripts/check-licenses.mjs, deny.toml's allowlist for the npm half. Required, with cargo deny and tauri lockstep — eight required checks.
- Qodana in two parts (Rust, TS/JS), full scans, a triaged Rust baseline, fail on anything new. The Rust container needed its toolchain and CARGO_HOME pointed somewhere writable before it analysed anything.
- SonarQube Cloud analyses into poli0981org_pipdock; every npm ci runs with --ignore-scripts (S6505).
- Every repository URL points at the organization. README's attestation command for 1.4.0/1.5.0 had stopped working; it now says --owner poli0981 --signer-repo poli0981/pipdock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There is no zoom in 1.5.0, so asking a reporter for their zoom level asks for
something the application does not have.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
GitHub's community profile listed five things missing, and the ops repository
supplies no defaults despite its description, so they are added here.
ACCESSIBILITY.md is at the root, where GitHub looks and where the README can
link it. It follows the Accessibility Toolkit's structure, rewritten for a
Windows desktop application and a CLI: the target (WCAG 2.2 AA, as a target and
not a conformance claim), what is supported, a table of what was tested and by
whom, what was not tested, the known limitations, and how to report a barrier
without a GitHub account. It commits to an answer within seven days and to no
fix date, because one person cannot honestly promise one.
CONTRIBUTING.md states the rules a contributor actually meets: the checks CI
runs, generated bindings, goldens, both locales, and the invariants that are
not negotiable. CODE_OF_CONDUCT.md is Contributor Covenant 2.1, unmodified
apart from the contact address. The pull request template carries an
accessibility checklist, and accessibility.yml is an issue form that asks for
impact rather than for a diagnosis. bug_report.yml keeps its name: the in-app
Report bug link is built from it.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
- cargo update (~60 bumps, 627 -> 616 crates) clears the yanked async-executor 1.14.0 that
had turned cargo audit red on main and on every Dependabot PR since 2026-11-03 (Linux-only,
never in the shipped binary). rusqlite 0.41.1 (SQLite 3.54.1), no code change. rfd 0.17 with
tauri-plugin-dialog 2.8.4, which met the rfd ignore's own condition, so the ignore goes.
- npm: thirteen packages to latest; TypeScript still held at 6.0.3 (typescript-eslint peers <6.1).
- Tools: ruff 0.17.3, certifi, msgpack, platformdirs; constraints regenerated.
- Actions: taiki-e/install-action v2.87.32, sonarqube-scan-action v8.4.0; Node 24 -> 26 LTS.
"Latest" means the newest release past each ecosystem's Dependabot cooldown.
- pip 26.3 renders an unloadable build backend as `error: backend-unavailable`, which fell
through to PD-BLD-003; a classifier rule restores PD-BLD-002. Found by the drift job; live
corpus re-captured with pip 26.3 / uv 0.13.7, the 26.2.1 capture frozen as pip-26.2/, and a
test holds both renderings to one code.
- Docs: ARCHITECTURE §10 re-verified, ERROR-CATALOG, TESTING, ROADMAP, CLAUDE.md.
Supersedes #97, #98, #99, #100, #101.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automatic analysis could not build, so it never analysed the Rust two
thirds of the code and imported no coverage; it also sent no project
version, leaving the previous-version new-code period anchored to the
first analysis. sonar.yml runs on Windows, produces cargo-llvm-cov and
vitest LCOV plus clippy's JSON, and scans with sonarqube-scan-action
v8.3.0 (pinned), passing the version from package.json. The token
reaches the scan step alone; the job is skipped without one (Dependabot,
forks) and refuses a dispatch off main, which this plan cannot analyse.
Unblocks the required audits, red on main since 2026-10-21:
rustls-webpki 0.103.16, webpki-root-certs 1.0.11, clipboard-win 5.4.3,
zod 4.6.7. Dependabot groups vitest with @vitest/*.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three things have kept CI red since 2026-10-18; none touches the shipped program.
- **cargo audit** (required on every PR, and the daily Security scan) fails on
RUSTSEC-2026-0370/0371/0372: zvariant, zbus_names and zvariant_derive were folded into
zbus 6 on 2026-10-16 and marked unmaintained the same day. zbus reaches the tree only
through tauri-plugin-opener and tauri-plugin-single-instance, for D-Bus on Linux;
`cargo tree -i zbus --target x86_64-pc-windows-msvc` prints nothing. Every release of both
plugins, the 3.0 alphas included, still requires zbus ^5.9, so there is no update to take.
Ignored individually in .cargo/audit.toml with that reason and a removal condition.
`cargo audit --deny warnings` is clean locally.
- **The Monday fixture-drift job** failed on pip/build-backend-failure/stdout.txt: pip 26
ends a finished bar with the bare elapsed time, not `eta 0:00:00`, so `_is_progress` let
the transfer rate through (15.1 MB/s committed, 75.1 MB/s on the next runner). The rule now
keys on a trailing time token. Old vs new over every committed fixture line: exactly this
one line changes verdict. The fixture is restored to `<PROGRESS>` in binary mode, 7 CRLF
before and after; its blob is again b349d1f, the pre-pip-26 bytes.
- **rfd**: Dependabot's 0.17.2 bump (#83) adds a second rfd to the binary, because
tauri-plugin-dialog 2.8.3 requires ^0.16 and src-tauri depends on rfd only because the
plugin already compiles it. dependabot.yml now ignores rfd >= 0.17 until the plugin moves.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The release build was installed and driven before tagging. Two defects showed up that no suite
could see:
- Every dialog opened in the window's top-left corner. Tailwind's preflight sets `margin: 0` on
everything, which removes the `margin: auto` a modal <dialog> is centred by; PdDialog (and so the
uninstall guard, since it was written) and the Ctrl+K palette were both affected. `m-auto` /
`mx-auto`, measured in the dev server: (0,0) before, centred after.
- On a profile that had never downloaded the index, Search said "preparing the package index"
for ever and never offered the download. Moving the load into the background let a failed load
restart on the next search, which reset the slot to Warming before the failure could be read,
and the screen asked again every 150 ms. A failed load now stays failed until a refresh; a test
in state.rs failed first against the old rule.
From the documentation pass, each checked against the code:
- The GUI's snapshot diff used the plain diff while the CLI's and the rollback used the
engine-aware one, so the two heads disagreed about pip and setuptools across engines (G5).
- `--json`'s help still promised NDJSON; `--yes`, `--quiet`, `--verbose`, `--log-file`, the
install spec and `engine` described behaviour they did not have. Corrected, and the 32 help
goldens re-blessed for exactly those lines. `pipdock engine` now marks the configured engine,
as its help always said; `health --fix` printed a dirty-tree warning to stdout before its JSON;
the text preview now lists withdrawn releases, as the GUI's does.
- Copy that promised what the code does not do: a pinned package "can still be updated on its
own" (an Exclude pin filters a named package too), a held pin left only "out of bulk updates",
and an empty Environments screen pointing at a Browse… button that does not exist.
- Stale comments in exec, the pip and uv parsers, index refresh, health, the pin screen, the
status line, the settings store and i18n.ts (whose missing-key warning never fires). The
ExecutionSummary.cancelled description is part of the public schema, so that golden and the
TypeScript bindings move with it.
- Metadata lookups reuse the shared HTTP client (M37 had been half done); insta was a dev
dependency of core that nothing in core used; the integration workflow's checkouts no longer
persist credentials; the capability file cites SECURITY §4, where the rule lives.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- report.rs: the excerpt was capped at 6000 characters *before* percent-encoding, which is what
decides the length GitHub sees - an accented letter costs up to nine bytes, a path separator
three - so a log full of Vietnamese paths built a ~20 KB link and GitHub answered with an error
page instead of the form (M51). Lines are now dropped from the front until the encoded excerpt
fits; a single enormous line is trimmed rather than dropped. Two tests, both failing first.
- run.rs: `pipdock uninstall` dropped its output pump's handle instead of awaiting it, so the
summary could print over the last engine lines - the ones that say how the removal ended (X38).
The other three pumps already waited.
- bug_report.yml: the version placeholder read "1.0.0", which every release since made wrong; it
now says where to find the version instead (X48).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notify-ci-failure.yml lists its workflows by name. `workflows: ['*']` is not a wildcard to
workflow_run: it matched nothing, so `main` was red from 2026-09-23 with no one told.
- cargo audit runs a prebuilt cargo-audit (taiki-e/install-action, pinned by commit) with
`--deny warnings`, replacing rustsec/audit-check@v2 - Node 20, a check-run write token, and on a
pull request a failure only for "critical", which is how September's advisories passed every PR.
.cargo/audit.toml's contract (a new informational advisory fails CI) is now what runs.
- security-scan.yml: both audits daily against `main`, so an advisory against something already
merged is reported the day it is published, not at the next PR.
- cargo deny (licences, sources, bans) with deny.toml: the licence allowlist makes "every bundled
licence is GPL-3.0-compatible" a test. The workspace declares `publish = false`, which it never
had - and without which cargo-deny judged the app crates as published ones.
- CodeQL analyses rust and actions as well as javascript-typescript. The comment saying CodeQL had
no Rust support stopped being true in 2025.
- ci-node.yml: Pages and id-token write move from the workflow to the one job that needs them
(Sonar S8233); the audit installs with --ignore-scripts (S6505); a new `tauri lockstep` job
fails when a Tauri crate and its npm package drift apart on Cargo.lock and package-lock.json.
- release.yml: build (read-only token, no persisted credentials) and publish (attest + draft) are
separate jobs; the tag must match all five version fields; SHA256SUMS.txt is LF, which
`sha256sum -c` elsewhere needs; actions/attest-build-provenance attests the .exe and .msi;
softprops/action-gh-release is pinned by commit; `workflow_dispatch` with `dry_run` builds any
ref without attesting or drafting.
- ci-integration.yml also runs for the CLI, exec, audit, release metadata, errors, store, index,
Cargo.lock and rust-toolchain.toml - every one of which its end-to-end steps run through.
- dependabot.yml: cooldowns, a group per ecosystem for Tauri packages and for actions and pip,
TypeScript held below 6.1 (typescript-eslint's peer range), and the rust-toolchain ecosystem.
A multi-ecosystem group would put both Tauri halves in one PR, but what it does to dependencies
outside its patterns is undocumented; the lockstep job covers the gap instead.
- Sonar: NOSONAR with reasons on the dev scripts' argv and PATH lookups; bundle-cli.mjs no longer
claims to run from beforeBuildCommand. The dev CSP moves out of index.html into a Vite plugin
that reads devCsp from tauri.conf.json, so a release build carries one policy, the strict one
(S7039); checked in the dev server, where React Refresh's preamble still runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The weekly re-capture has failed seven Mondays running (since 2026-08-31), and for most of them no
engine had changed at all:
- `clean-upgrade` asked for the *latest* idna, so 3.18 → 3.20 was "drift". Pinned to idna==3.10.
- pip's "(from versions: …)" listed every scipy release, so the requires-python fixture grew with
each one. Redacted, like the release notice before it; no classifier reads it.
- The capture never upgraded pip: every venv ran the CPython-bundled 25.0.1 while 26.2.1 was
current, so the job meant to catch a pip output change could not see one. `venv.create(...,
upgrade_deps=True)`, and the report's `pip_version` is redacted because it now moves with each
pip release (provenance still records it).
- `python-version: '3.12'` floated with the runner image, and the Python patch is recorded in both
engines' output. Pinned to 3.12.10, the version every committed fixture was captured with.
The job now uploads what it captured whether or not the gate passes, so a real drift is fixed by
reviewing and committing exactly those bytes. `capture.py` also refuses an unknown `--only` name
(it used to capture nothing and exit 0) and exits 1 when nothing was captured; its two
backtracking-prone patterns (SonarCloud S8786) became a `[ \t]` class and a `partition`.
The other half of the red was real: uv 0.13.0 (2026-10-09) replaced its miette rendering — `×`,
`╰─▶`, "Caused by:" — with "error:" / "cause:". `UV_MIN_VERSION` is 0.10, so both renderings stay
under test: the current captures are frozen as `uv-0.11/` (uv 0.11.32, byte-identical copy) before
`uv/` is re-captured against the newest uv. The disposable-venv suite also stops running twice on
Monday mornings (the drift cron matched it too).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`legal/THIRD-PARTY-NOTICES.md` was not the only document listing a dependency the
project deliberately does not have. ARCHITECTURE §9, TESTING §3 and CLAUDE.md all
still say types are generated with specta/tauri-specta; `bindings.rs` has recorded
since M1 that they are not, and why. Each now says what actually happens and points
at that file — including the consequence, which is that drift is a `cargo test`
failure rather than a compile error.
PRD G7 carried the same stale claim as the privacy policy: "network traffic limited
to PyPI + GitHub Releases", from before the self-updater was removed.
SECURITY §7 repeated the `cargo about` / `licenses/` claim; §8's reset advice
pointed at "Settings -> Legal & About", a screen that has never existed; §9 promised
a root SECURITY.md that was never written. The last one is now `.github/SECURITY.md`
— a short pointer so GitHub's Security-policy tab is not empty — carrying the
advisory URL and code@poli0981.dev.
SECURITY §4 gains the poli0981.dev entry ahead of the About tab that needs it, per
its own rule that an allowlist widening belongs in prose and not only in
capabilities/. It also now says what the scope actually defends: the two call sites
that pass data rather than constants, one of which hands over a URL that came out of
ruff's JSON. That is the argument for copying the contact addresses to the clipboard
instead of adding a mailto: scheme.
README dropped a "(add the standard GPL-3.0 text at repo creation)" instruction that
had been shipping for three milestones after the text was added.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI caught two things the previous commits broke, and the first is pointed: I declared the CLI
sidecar in `tauri.conf.json`, and **`tauri-build` validates `externalBin` at build-script
time** — so plain `cargo clippy` and `cargo test` on `pipdock-app` began failing in a fresh
clone with *"resource path `binaries\pipdock-x86_64-pc-windows-msvc.exe` doesn't exist"*.
It passed locally only because I had already staged the file. That is exactly the "works on
my machine" failure the commit that introduced it claimed to be preventing.
`externalBin` moves to `src-tauri/tauri.bundle.conf.json`, merged with `--config` only when
bundling. Compiling the app does not need the sidecar; bundling it does, and the config now
says so. Verified the way it should have been the first time: **`src-tauri/binaries/` deleted**,
then `cargo clippy -p pipdock-app --all-targets` and `cargo test --workspace` both clean —
and `npm run bundle` from that same state stages the sidecar and produces two installers, the
NSIS payload still carrying `pipdock-app.exe` and `pipdock.exe`.
The whole recipe now lives in one `npm run bundle` script the workflow calls, so nobody has
to remember that `--locked` goes after `--` or that the overlay exists. RELEASE-CI §3.1
records both traps rather than just the command.
Second breakage: `ci-integration.yml` hardcoded `%LOCALAPPDATA%\PipDock\tools` in three
places — it quarantines `ruff.exe` there to prove `PD-HLT-001` — and the data root had moved
under `data\`. A test that reaches into a path by hand is a test that has to be told when the
path moves.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The first bundle ever built for this project contained exactly one binary. NSIS payload:
`pipdock-app.exe`. MSI `app.cab`: one file. **`pipdock.exe` was not installed at all** — while
PRD P0-12 is "CLI core parity", CLI-SPEC documents the entire surface, `golden.rs` pins 58
snapshots of its output, and the README's own Quick start opens with `pipdock env list`. A
user who installed PipDock had none of it.
Found by listing the installer. `tauri.conf.json` declared no `externalBin` and no
`resources`, so there was nothing to notice in a diff — the config was correct for a
GUI-only app, and nobody had built one to see what came out.
`scripts/bundle-cli.mjs` builds the CLI and stages it as a sidecar under the host triple,
which Tauri strips at bundle time, so it installs as plain `pipdock.exe` beside the GUI. The
triple is asked of `rustc -vV` rather than assumed, since a guess breaks the moment anyone
cross-compiles.
It runs from `beforeBuildCommand`, not only from the release workflow. A locally built
installer and a released one have to be the same artifact; a bundle that differs by who
built it is how "works on my machine" reaches a release. This build proves the clean-checkout
case too — `src-tauri/binaries/` is gitignored and did not exist when the build started.
**`PATH` is deliberately left alone** (owner decision, 2026-08-13). PipDock does not modify
the user's environment, which is the restraint SECURITY §5 already applies to not shipping a
self-updater; the README says where the binary lands and gives the one-liner to add it if
that is what you want.
Verified by rebuilding and listing both installers: NSIS 5.7 → 8.8 MB carrying
`pipdock-app.exe` and `pipdock.exe`; MSI 7.6 → 11.6 MB carrying `Path` and `Bin_pipdock.exe`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`npx tauri build --locked --bundles nsis,msi` fails with *"unexpected argument '--locked'
found"* before a single crate compiles. `--locked` is **cargo's** flag; `tauri build` passes
everything after `--` to the runner. No `v*` tag has ever been pushed, so the release job had
never executed and this had never surfaced.
Found by building the bundle on the dev machine for the first time — which is the whole point
of Phase 4, and which took one command to expose a pipeline that would have failed on the
tag that was meant to ship v1.
Also removed a duplicated frontend build: `tauri build` runs `beforeBuildCommand`, which is
already `npm run build`, so vite ran twice per release for no benefit. RELEASE-CI §3.1 now
describes the command that exists rather than `cargo tauri build --locked`, which has the
same flag problem.
**Verified against real artifacts**, not just re-read: the corrected command produces
`PipDock_0.1.0_x64-setup.exe` (5.7 MB) and `PipDock_0.1.0_x64_en-US.msi` (7.6 MB) in 3m48s,
and the workflow's own collect and checksum steps, run verbatim in PowerShell, emit a correct
`SHA256SUMS.txt`.
The README gains the badges RELEASE-CI §5 asks for, loses a status line that still said
*design phase*, and gains the command that makes "verify the SHA-256 checksum" actionable —
tested against the real file, and it reproduces the published sum.
One correction there is not cosmetic: the feature table claimed network traffic goes to
"PyPI (package data) and GitHub (app updates)". **PipDock has no self-updater** — SECURITY §5
removed it deliberately, and the paragraph two lines below the table says so. PyPI is the
only host it connects to; GitHub and the ruff docs are only ever handed to the browser as a
link the user clicked.
ROADMAP records both the build numbers and the blocker the build exposed — see the next
commit's absence: the installer ships no CLI, and fixing that needs an owner decision.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The PEP 668 step failed on both legs against a fix that was working. `Get-Command python`
resolves through PATH, and the "Install uv" step earlier in this job puts .uvtools\Scripts
on it — a venv Scripts directory, which holds a python.exe. So the "base" being asked was
that venv, which is correctly not externally managed, and the assertion fired exactly as
designed.
Both interpreters are now named rather than looked up: the marker is planted relative to
$env:pythonLocation's python and the same one is asked about, and .pep668 is created from
it so it is a venv rather than a venv of a venv. The step also ends with an explicit
exit 0, since the runner appends `exit $LASTEXITCODE` to every pwsh step.
The pip upkeep step passed on both legs: pip 22.1.2 -> 26.2.1 on 3.10 where the old pip
runs, and on 3.14 where it cannot and only the ensurepip fallback gets out of it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two steps and a paths entry, all covering things no unit test can reach.
probe.py was not in the filter at all. It sits at src/probe.py rather than under envs/, and
its only tests parse a canned document — so its behaviour against a real interpreter was
never exercised anywhere, which is how the venv/EXTERNALLY-MANAGED bug survived.
The pip upkeep step gets both outcomes out of one matrix: on 3.10 an old pip runs and
upgrades normally, on 3.14 the same pin cannot start and only the ensurepip fallback gets
out of it. It runs with --engine uv, which is meaningful rather than incidental here since
uv is on PATH in this job.
The PEP 668 step plants the marker rather than hoping a runner ships one, and asserts both
directions: a venv must not report managed, and its base must — a fix that simply stopped
looking would pass the first and silently break the code that protects system Pythons.
Both assert through `--env` rather than discovery. envs::venv_scan matches exactly
.venv/venv/env/.env, so a suffixed scratch venv is invisible to `env list` — which the
first draft of these steps got wrong, and which the local dry-run caught.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
health/ was not in the integration job's paths filter, so nothing about the tools venv
would have run on a PR that changed it. tools/ is there too: a Dependabot pin bump has to
re-run the bootstrap, because whether the new pin set still resolves to wheels on both ends
of the supported range is exactly what this job can answer and a unit test cannot.
Four assertions, each one a bug this slice actually had or nearly had: a just-synced venv
reports fresh with all three tools and no pip-audit; a second sync short-circuits in under
10 s; a quarantined ruff.exe reports toolMissing and is repaired by a re-sync; and an
unreachable index gives PD-NET-011, exit 6, and leaves no manifest claiming the venv is
good.
LOCALAPPDATA is overridden to redirect the whole app-data root, so the job never touches a
runner's profile and PipDock needs no test-only configuration knob. Verified locally rather
than assumed, along with the whole script — which is how the `exit 0` at the end was found:
the runner appends `exit $LASTEXITCODE` to every pwsh step and the last command
deliberately exits 6, so without it the step failed with every assertion passing.
.gitignore gains the three scratch directories this job builds in the workspace. Only the
new one is P2's, but ignoring one of three would be odder than ignoring none.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Found by running, not by reading: `pipdock list` on a venv with one editable install
printed the package twice.
`importlib.metadata.distributions()` walks sys.path and yields one entry per metadata
directory. `pip install -e` puts the project's own src/<name>.egg-info on sys.path via the
.pth file, so the package is discovered both there and at the venv's .dist-info. `pip list`
shows it once; PipDock showed it twice.
Deduplicated by normalized name, first occurrence winning — sys.path precedence, which is
the copy an `import` would actually resolve to.
This matters more for S2 than for the CLI. The Installed table joins `pkg_list` against
`pkg_outdated` on the normalized name, so a duplicate is an ambiguous key, and it renders
as two rows a user cannot tell apart.
Covered by a new L2 step rather than a unit test: there is no Python test harness, and the
condition needs a real editable install to exist at all. The step asserts both of this
area's claims — listed once, and reporting no size. **Both halves were exercised**: with
the fix reverted the count assertion throws with "got 2", and with it restored the step
passes and leaves $LASTEXITCODE at 0, which is the trap the guard step hit in L2's first
runs. The pyproject is written as a string array rather than a here-string, because a
here-string's closing '@ has to land at column 0 after YAML strips the block indentation.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Same move as the update flow, and shorter because there is nothing to resolve --
but the same invariant: the reverse-dependency guard runs first, and nothing is
removed before a snapshot exists.
"Remove dependents too" is deliberately not a variant on the flow. It is the caller
starting again with `GuardReport::with_dependents` as the new set, which re-runs
the guard. That is what DATA-FLOW section 5 means by re-guarding, and it stops a
widened removal from skipping the check that justified widening it.
One detail preserved rather than tidied: `execute_uninstall` is given the
*snapshot* id, not `plan_id`. That is what the CLI has always emitted as the
summary's planId, and it is the more useful handle for a removal -- what a user
wants afterwards is the snapshot to roll back to. Noted in a comment so it reads as
a choice rather than an oversight.
Verified against a real venv: removing urllib3 under requests still prints
"removing urllib3 breaks requests", still suggests `pipdock uninstall requests
urllib3`, and still exits 1 -- which is the assertion the L2 job makes. A guard-clear
removal still writes its snapshot first.
213 tests with the L4 goldens unchanged; fmt and clippy clean.
Also adds `crates/pipdock-core/src/flow/**` to ci-integration.yml's path filter, so
a change to the orchestration triggers L2 the way a change to plan/ or graph/ does.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Removes `tauri-plugin-updater` and everything that existed to serve it.
A self-updater is a permanent remote-code-execution path into a tool that already
runs subprocesses against the user's interpreters, and it has to be defended for
the life of the product: a signing key that must never leak, an endpoint that must
never be spoofable, verification logic that must never be bypassable. For something
people open occasionally to tidy an environment, that is a large standing liability
bought for a small convenience.
It was also never actually functional. `plugins.updater.pubkey` has been the literal
string REPLACE_AT_FIRST_RELEASE_WITH_TAURI_SIGNING_PUBLIC_KEY since Phase 0, so the
capability was granted to a plugin that could not verify anything.
What goes:
- tauri-plugin-updater, its `plugins.updater` config block and endpoint, and the
`updater:default` capability
- the release workflow's signing step, `--bundles ...,updater`, and the *.sig /
latest.json artifact globs
- TAURI_SIGNING_PRIVATE_KEY and its password from the secrets bootstrap, and the
keypair generation item from the RELEASE-CI section 5 checklist
Ten crates leave the dependency tree with it: zip, tar, xattr, filetime,
minisign-verify, osakit, objc2-osa-kit, arbitrary, derive_arbitrary and the plugin
itself -- archive extraction, signature verification and AppleScript execution, none
of which PipDock has any other reason to link.
SECURITY section 4 gets simpler as a result: pypi.org is now the *only* host PipDock
connects to. github.com was on that list solely for the updater; the legal gate and
the bug-report deep link hand a URL to the user's browser rather than fetching
anything.
Users move between versions from the GitHub Releases page and verify SHA256SUMS.txt,
which the README already tells them to do because SmartScreen warns on first run.
Recorded in CLAUDE.md as well: Tauri makes adding this back a three-line change, so
the reasoning needs to outlive the commit.
183 tests, fmt and clippy clean, both Tauri JSON files still valid.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
With the rollback assertion fixed, L2 got far enough to reach the uninstall-guard
step, which had the same class of bug waiting behind it.
The step runs `pipdock uninstall urllib3` against an environment where requests
depends on it, and requires a non-zero exit -- CLI-SPEC section 7 makes a guard trip
exit non-zero so `||` works in scripts. The guard did exactly that:
error[PD-PKG-002]: refusing to remove packages other packages depend on.
removing urllib3 breaks requests
But the runner ends a pwsh step with `exit $LASTEXITCODE`, and nothing had reset it
since the deliberately-failing command. So the step reported failure on the very
outcome it was there to prove.
Capture the code, assert on the captured value, and `exit 0` explicitly.
Audited the other seven end-to-end steps for the same pattern; each ends on a
command that legitimately exits 0, so this was the only one.
Verified in run 30454252621: the rollback assertion now passes on both matrix legs
with `{"added": [], "removed": [], "changed": []}` -- PRD section 6's "env diff vs
snapshot = the empty set", checked in CI rather than by hand.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The weekly fixture-drift job has never been able to pass, and could not have.
Every capture built its venv in a `mkdtemp` directory whose name carries a random
suffix, and `redact()` replaced only the temp *root*, so the suffix survived into
every committed sidecar. A 100% false-positive rate, independent of any engine
release.
Four more sources of churn were underneath it, found by running the captures twice
back to back rather than by reasoning about them:
- pip's "[notice] To update, run: <venv>\Scripts\python.exe" embeds the venv
path -- which also shipped the capturing user's home directory to a public repo
- CPython object addresses in urllib3 retry warnings, moved by ASLR
("<HTTPConnection object at 0x000001A92FBCFBC0>")
- pip's download progress bar, which carries a transfer rate and an ETA
- uv's per-phase timings ("Resolved 3 packages in 775ms")
Plus two absolute interpreter paths that can never match a re-capture on CI, where
Python lives in hostedtoolcache rather than under the user profile, and pip's cache
state, which turns "Downloading numpy-1.19.5.zip (7.3 MB)" into "Using cached ..."
depending on what the machine happened to have. A runner is always cold; a dev
machine is usually warm.
So: redact all of it, capture cache-free so both sides take the download path, and
split the sidecar by what each half is for. meta.json is the contract the gate
watches; capture-provenance.json records engine and interpreter versions and argv,
churns on every release, and is excluded from the gate by pathspec -- still
committed, so `git diff` always tells you which engine produced the current bytes.
This is the one place fixtures are not literal engine bytes, against the letter of
TESTING section 1. It is safe because nothing reads a path or a duration out of
them: every CLASSIFIERS entry in errors/catalog.rs keys off message text, and the
uv adapter only tests contains("Resolved "). Line endings are untouched -- `-text`
is what protects those. Verified: 173 tests green, and two full capture passes over
both engines differ in 0 of 96 files.
Two smaller things in the same area, both of which hid the problem:
- .gitattributes set `-diff` as well as `-text` on the fixture tree. `-text` is
what preserves the CRLF bytes the comment argues for; `-diff` only suppresses
the textual diff, so the drift job's own diagnostics could report nothing but
"Binary files differ". Scope byte-exactness to the .txt captures and let the
JSON sidecars be diffable.
- the "weekly, daily would be rude" drift job matched the nightly cron, the only
one in the file, so it ran nightly. Give it its own '17 4 * * 1', and drop the
run_attempt guard -- re-running is how you reproduce a drift failure.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The L2 job did `snapshot create` -> `update --all` -> `snapshot rollback latest`
-> `snapshot diff latest`, and required the prose "matches snapshot". It failed on
every run, and the product was right every time.
`latest` moves twice during that flow. `update --all` writes a Trigger::Plan
snapshot before it mutates, and `snapshot rollback` writes a Trigger::Rollback one
before it restores, because DATA-FLOW section 8 makes rollback itself reversible.
So by the final step `latest` resolved to the pre-rollback safety snapshot, which
had captured the post-update state, and the diff correctly reported all seven
packages as changed. The rollback had worked: it restored pip 23.0.1 and
setuptools 65.5.0, exactly Python 3.10's ensurepip versions.
Pin the id from `snapshot list --json` immediately after `create` -- before either
of the other two snapshots exists -- and assert structurally on `diff --json`
rather than on a sentence. The old assertion would have started passing the moment
anyone reworded run.rs, which is the opposite of what a gate is for.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Three failures from the first push, all of them CI configuration rather
than code.
CodeQL and CI/Node both hit startup_failure with no logs. A caller cannot
grant a called workflow less than its jobs declare, and the run is
rejected before anything starts, so there is nothing to read.
reusable-codeql.yml's analyze job asks for `packages: read` to fetch
CodeQL packs, and reusable-web-react.yml's deploy job asks for `pages:
write` and `id-token: write`. The deploy job is skipped here
(deploy-pages: false), but permissions are validated at startup
regardless of `if:`.
This is the trap RELEASE-CI.md section 1 already records -- "callers
without a permissions block default everything to none" -- met from the
other direction: having a block is not enough if it grants less than the
callee asked for. Both comments now say so at the point of use.
cargo audit failed to compile rather than finding an advisory.
rustsec/audit-check builds cargo-audit from source, and
rust-toolchain.toml pinned that build to PipDock's 1.94.1; cargo-audit's
own dependency tree needs 1.96. The job now builds it with stable, which
is correct in principle too: the pin exists to make PipDock reproducible,
not its tooling, and cargo-audit only reads Cargo.lock.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds the last commands: env use, pip-upgrade, snapshot rollback, schema,
self report-bug, and engine <pip|uv>. Every P0 CLI command now works
except health, which belongs to M3 with the tools venv.
Rollback follows DATA-FLOW section 8 including the part that is easy to
skip: it snapshots the current state before replacing it, because a
rollback is itself reversible. Verified end to end — installing httpx
0.23.0 and rolling back left the environment with pip alone, and the diff
afterwards reported "matches snapshot".
Two things the compiler and the smoke test caught:
- `pipdock engine pip` was never handled. Only the no-argument form was
wired, so the documented setter silently did not exist; the
non-exhaustive match surfaced it once the catch-all arm was removed.
That catch-all had been hiding it.
- engine_for ignored any stored preference and always returned pip, so
configuring an engine would have had no effect. It now reads the store,
and setting an unavailable engine is refused rather than saved —
storing a preference that cannot be honoured just moves the failure to
the next command.
schema generates from the Rust types via schemars rather than being
hand-written, because a hand-written schema drifts the moment a field is
added and then lies to every script pinning against it. A test asserts
every advertised type actually resolves.
ci-integration.yml implements TESTING L2: real pip and uv against
throwaway venvs on Windows, across the 3.10 floor and 3.14 ceiling, with
an end-to-end pass that checks the claims the docs make — the SP-1
conflict is still reported and attributed, update/rollback round-trips
leave the environment matching the snapshot, the guard still refuses to
break requests, and the exit codes still match CLI-SPEC section 5. A
weekly job re-captures fixtures against the newest engines so an output
change surfaces as a failed job rather than as PD-ENG-003 on a user's
machine.
The ROADMAP entry is honest about what is not done: L2 has never actually
run, the L4 golden-output tests are not written, and the SP-5 exit
criterion named a real numpy/scipy/pandas environment that the
httpx/httpcore construction stood in for.
173 tests, clippy -D warnings clean, npm audit clean, all workflows parse.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Completes the Phase 0 scaffold. The app builds, links and renders; no
screens yet.
Frontend (ARCHITECTURE section 9, UI-SPEC section 2):
- React 19 + Vite 8 + Tailwind 4 with the UI-SPEC dark terminal-tech
tokens, plus a contrast test asserting WCAG AA over every
text/surface pair, which UI-SPEC section 8 requires be verified.
- EN and VI catalogs with a test that vi has every en key and no
orphans, standing in for the CI parity script I18N section 1 asks for.
- A local eslint rule enforcing the no-hardcoded-JSX-strings policy.
eslint-plugin-react was the obvious choice but caps at ESLint 9, which
drags in six high-severity advisories that would fail npm audit in CI;
a local rule also implements the documented allowlist (product name,
package names, versions, catalog codes, glyphs) precisely, which
react/jsx-no-literals cannot express. Verified it fires on real copy
and stays quiet on all five allowed shapes.
- no-restricted-imports keeps invoke() out of components, so the
"no component calls invoke directly" rule is enforced, not just stated.
Tauri (ARCHITECTURE section 7): commands and events only, identifier
com.skullmute.pipdock, NSIS and MSI targets, minimal capability set,
placeholder icon pending the Phase 3 branding pass.
CI (docs/RELEASE-CI.md section 1 as corrected):
- ci-rust.yml and release.yml are project-local, on Windows runners,
because no reusable Rust or Tauri workflow exists in the ops repo.
Windows matters here: env discovery reads the PEP 514 registry and the
py launcher, so a Linux run would skip the code most likely to break.
- ci-node.yml calls the ops web-react reusable and adds the npm audit
job that reusable lacks.
- codeql.yml is JS/TS only; CodeQL has no Rust analyzer.
- Discord notifiers replace the six-platform notify.yml that never
existed. Every caller carries an explicit permissions block.
- Action versions checked against the registry rather than assumed:
checkout v7, cache v6, gh-release v3, setup-node v6.
Two toolchain holds, both forced and both recorded:
- TypeScript 6.0.3, not 7: typescript-eslint peers on <6.1.0.
- ESLint 10 with eslint-plugin-react dropped, as above.
Verified: cargo fmt/clippy -D warnings/28 tests green, tsc clean,
18 vitest tests green, eslint clean, npm audit reports 0
vulnerabilities, vite build and both binaries link.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Commits the full v0.1 design suite written during the design phase:
PRD, architecture, data flow, UI/CLI specs, code-health spec, error
catalog, security, testing, release/CI and i18n docs, plus the roadmap.
The legal documents (EULA, disclaimer, privacy policy, third-party
notices) must be committed publicly because the in-app legal gate links
to their GitHub URLs at first run.
Also adds .gitignore, which the repo was missing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>