Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
33c884f0b7 |
No files matched your search
@@ -41,11 +41,14 @@ concurrency:
|
||||
jobs:
|
||||
wiki:
|
||||
# A rehearsal of release.yml (workflow_dispatch) never publishes the wiki: only a run started by a pushed v* tag
|
||||
# that succeeded.
|
||||
# that succeeded - in THIS repository. A fork cannot start this repository's Release run (it runs on a tag push or by
|
||||
# hand), so the head checked out below is always the owner's; the repository check says so in the condition rather
|
||||
# than leaving it to release.yml's triggers (SonarCloud githubactions:S7631, beta.26).
|
||||
if: >-
|
||||
github.event_name == 'workflow_dispatch' ||
|
||||
(github.event.workflow_run.conclusion == 'success' &&
|
||||
github.event.workflow_run.event == 'push' &&
|
||||
github.event.workflow_run.head_repository.full_name == github.repository &&
|
||||
startsWith(github.event.workflow_run.head_branch, 'v'))
|
||||
runs-on: windows-latest
|
||||
timeout-minutes: 10
|
||||
|
||||
+12
-4
@@ -35,15 +35,23 @@ numeric core and does not move; the heading is the full version — corrected 20
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Changed
|
||||
|
||||
- **SonarCloud's last six findings on `main`, triaged** (developers only; D67's follow-up). After the owner's marking,
|
||||
the analysis of 0.1.0-beta.25 left six open: `docs/13_CI_CD.md` §SonarCloud lists them with a verdict and the comment
|
||||
to paste — one to accept as the table already said, four false positives (exact floating-point comparisons that are
|
||||
exact on purpose), and one fixed here: `wiki.yml` publishes only after a Release run started by a tag pushed to this
|
||||
repository, now checked by the repository's name in its condition as well as by the run's trigger.
|
||||
|
||||
### Fixed
|
||||
|
||||
- **A frame-generation "state" of ×1336.0.** The owner's Silent Hill 2 session (0.1.0-beta.25, the NVIDIA App's
|
||||
*Dynamic* multi frame generation) listed a ×1336.0 state — 0.20 → 267.20 FPS for ten seconds — under *Frame
|
||||
generation in this session*, and the DLSS line cited it: *DLSS 4.5 (a ×1336.0 frame-generation state)*. Those ten
|
||||
seconds were presented with one application frame counted per five-second window (a loading screen), and a window
|
||||
needed eight presents but only one counted frame to be read. A window now needs eight application frames and a
|
||||
ratio no higher than ×8 — more than any frame generation produces (DLSS 4.5's ×6 is the most); every other window is
|
||||
*Not classified*, and the steady state reads the same windows. A session-wide or live ratio that held above ×8 is
|
||||
seconds — the game compiling its shaders at start — were presented with one application frame counted per
|
||||
five-second window, and a window needed eight presents but only one counted frame to be read. A window now needs eight
|
||||
application frames and a ratio no higher than ×8 — more than any frame generation produces (DLSS 4.5's ×6 is the
|
||||
most); every other window is *Not classified*, and the steady state reads the same windows. A session-wide or live ratio that held above ×8 is
|
||||
refused and says why (*the ratio is beyond what any frame generation produces*), in en/vi/ja. Sessions already
|
||||
recorded are read by the same rule, so that session now lists ×2.0, ×3.0, ×6.1, no frame generation and 30 seconds
|
||||
not classified, and its DLSS line cites ×6.1. The owner's runs of beta.24 and beta.25 are recorded in
|
||||
|
||||
+2
-1
@@ -68,7 +68,8 @@ shown is recorded too, from outside the game. ([Capture](docs/04_CAPTURE.md))
|
||||
- **The mix of frame-generation states** in a session's summary (since 0.1.0-beta.24) is read over five-second
|
||||
windows: frame generation that changes faster than that — the NVIDIA App's *Dynamic* mode can — reads partly as
|
||||
*Not classified*, and a state shorter than 10 seconds is not listed. A stretch the game presents with almost no frame
|
||||
count of its own — a loading screen or a menu drawn outside frame generation — reads as *Not classified* too. The
|
||||
count of its own — shaders compiling at start, a loading screen, a menu drawn outside frame generation — reads as
|
||||
*Not classified* too. The
|
||||
multiplier chosen in a game's own menu is not read; the measured factor is its evidence. How the NVIDIA App's
|
||||
*Dynamic* ceiling and *Max refresh rate* target are stored by the driver is read from NVIDIA's own setting names,
|
||||
and has been checked against the App on one game. Sessions recorded before 0.1.0-beta.24 have no mix.
|
||||
|
||||
+2
-2
@@ -490,8 +490,8 @@ F_app = Σ fgEvaluations (APPLICATION frames, counted at the
|
||||
>
|
||||
> **Amended 2026-10-19 (beta.26): a window needs application frames, and a ratio frame generation can produce.**
|
||||
> "≥ 8 samples and tokens" was built as eight presents and ONE token, and the owner's Silent Hill 2 session listed a
|
||||
> ×1336.0 state — ten seconds the title presented through with one token per window (`spike-notes` §22); the DLSS line
|
||||
> cited it. A window is now read only with ≥ 8 presents AND ≥ 8 application frames (`FgSlices.Slice.IsReadable`, both
|
||||
> ×1336.0 state — the session's first ten seconds, the game compiling its shaders, presented with one token per window
|
||||
> (`spike-notes` §22); the DLSS line cited it. A window is now read only with ≥ 8 presents AND ≥ 8 application frames (`FgSlices.Slice.IsReadable`, both
|
||||
> active and *no frame generation*), and is active only up to **×8** (`FgWindow.GenerationCeiling`: no shipping
|
||||
> technology generates more than five frames per application frame, DLSS 4.5's ×6); every other window is *not
|
||||
> classified*. The steady state reads the same windows, so it can no longer pick such a stretch either. A session-wide
|
||||
|
||||
+14
-1
@@ -208,7 +208,9 @@ FrameLedger uses the **`poli0981/.github` ops repo** where its templates fit, an
|
||||
writes a footer naming the tag. The same assembly is `build.ps1`'s `wiki-check` gate (`12_BUILD` §Local quality gate,
|
||||
13d), so a dead link is red on the pull request, never on the published wiki.
|
||||
- **When:** `workflow_run` on `Release`, completed — the job runs only when that run succeeded and was started by a
|
||||
pushed `v*` tag, so a `workflow_dispatch` rehearsal of `release.yml` never publishes. It checks out the run's
|
||||
pushed `v*` tag in this repository (`head_repository` is checked since beta.26: a fork cannot start the Release run,
|
||||
and the condition now says so — SonarCloud `githubactions:S7631`), so a `workflow_dispatch` rehearsal of
|
||||
`release.yml` never publishes. It checks out the run's
|
||||
`head_sha` (a `workflow_run` job runs `main`'s copy of this file) and links at `head_branch`, the tag. By hand:
|
||||
`gh workflow run wiki.yml -f ref=main -f publish=false` builds, checks and uploads the pages as an artifact; with
|
||||
`publish=true` it publishes them.
|
||||
@@ -276,6 +278,17 @@ the comment below; the rest are fixed in the same train (beta.24 PR-2).
|
||||
checked is shorter than `MAX_PATH`, so it is terminated.
|
||||
- `fl-baseline-probe/main.cpp:55` — a literal (a developer probe, not shipped).
|
||||
|
||||
**The six left open after the trains (2026-10-19, beta.26)** — the analysis of `main` at `e35b971` (0.1.0-beta.25),
|
||||
after the owner's marking: 366 issues resolved (284 fixed — the exclusions and beta.24 PR-2 —, 49 accepted, 33 false
|
||||
positives) and six open, all in the new-code period, which is why its quality gate read C for reliability and security.
|
||||
Five were written after the analysis of `372389c` the table above was built from.
|
||||
|
||||
| Rule | Issues | Verdict | Comment for the UI |
|
||||
|---|---|---|---|
|
||||
| `csharpsquid:S3869` `DangerousGetHandle` | 1 | **Accept** — the row above; not marked yet | as above |
|
||||
| `csharpsquid:S1244` floating-point equality | 4 | **False positive** | Exact on purpose. `ColorMath.Hsv` compares `max` with `r` and `g` — `Math.Max` returned one of them, the same double; `MarkdownView`'s `next == _wheelTarget` is true only when `next` was assigned `_wheelTarget` (the snap that ends the easing); `SensorsChart.Line`'s `scale == 1.0` compares a parameter with its own default literal to skip a copy. |
|
||||
| `githubactions:S7631` untrusted code from a fork | 1 | **Fixed** in beta.26 | `wiki.yml` checks out `workflow_run.head_sha` only after a successful Release run started by a pushed `v*` tag, and now also only when `workflow_run.head_repository` is this repository. If the analysis still raises it, mark it *Safe* with that sentence. |
|
||||
|
||||
**The owner's steps** after the next analysis of `main`: for each rule above, open
|
||||
`https://sonarcloud.io/project/issues?id=poli0981_frameledger&resolved=false&rules=<rule>`, select all, *Bulk change*,
|
||||
choose *Accept* or *False positive* and paste the comment. Optionally, *Administration ▸ General Settings ▸ Analysis
|
||||
|
||||
+3
-2
@@ -218,8 +218,9 @@ case): 7.6–8.2 ns per UPSCALE dispatch, 1.6 ns per query beside the trampoline
|
||||
rows; close PR #315. (f) The Legal Gate shows **Disclaimer 2.11** and **Privacy Policy 2.12** once. (g) The `ja`
|
||||
strings marked `review`. *(2026-10-19, the owner's first runs — `spike-notes` §22: (a) the Dynamic context line
|
||||
reads the App's own words, and the mix found ×2.0 / ×3.0 / ×6.1 — plus a ×1336.0 row that was a defect, fixed in
|
||||
beta.26; (c) the override loads `160_E658700.bin` 310.9.16.0 and `1B0_E658703.dll` 2.14.16.0 from the NGX folder.
|
||||
The rest is not run yet.)*
|
||||
beta.26; (c) the override loads `160_E658700.bin` 310.9.16.0 and `1B0_E658703.dll` 2.14.16.0 from the NGX folder;
|
||||
(e) most issues marked — the six left open on `main` are triaged in `13_CI_CD` §SonarCloud (beta.26). The rest is
|
||||
not run yet.)*
|
||||
21. **beta.25 on real hardware — FSR's quality mode (D65), decision table written before the run.** Lies of P (FSR
|
||||
through AMD's FidelityFX libraries) launched by FrameLedger, not attached, with the game's own *FSR* at *Quality*,
|
||||
then a second session at *Performance* → the summary's header reads *FSR 3 Quality*, then *FSR 3 Performance* (or
|
||||
|
||||
@@ -16,8 +16,11 @@ Performance); Frame Generation override (×6, preset B, *Dynamic*, target max re
|
||||
- **The mix** under Dynamic multi frame generation: ×2.0 17.70 % (111.83 → 225.83 FPS, 35 s), ×3.0 21.60 % (95.75 →
|
||||
287.18, 42.7 s, the steady state), ×6.1 7.59 % (23.20 → 140.53, 15 s), no frame generation 37.94 % (80.08 FPS, 75 s),
|
||||
not classified 10.12 % (20 s) — and **×1336.0, 5.06 %, 0.20 → 267.20 FPS, 10 s: a defect.** Its two windows held one
|
||||
application-frame token each against 1,336 presents each: a stretch the title presented through outside DLSS-G's frame
|
||||
count (the frame-time chart has a 14-second frame the same minute — a loading screen). A window needed eight presents
|
||||
application-frame token each against 1,336 presents each. They are the session's first fifteen seconds, read from the
|
||||
ledger copy's frames five seconds at a time: 1,369, 4,877 and 1,303 presents with 1, 0 and 1 application frames, then
|
||||
no present for five seconds and one frame of 13,348 ms — Silent Hill 2 compiling its shaders at start (the owner,
|
||||
2026-10-19; the PSO hook was not installed in this session, so no PSO count confirms it). After it, 75 s of menus at
|
||||
~97 FPS with no frame generation, a 3-second stall, then play at ×2 and ×3. A window needed eight presents
|
||||
and one token, so the ratio of one token was the presents themselves, and the steady state's own rule would have
|
||||
picked it had it lasted longest. The DLSS line then cited it: *DLSS 4.5 (a ×1336.0 frame-generation state)*. Fixed in
|
||||
beta.26 (`03_METRICS` §The mix): a window is read only with eight application frames and a ratio up to ×8
|
||||
|
||||
@@ -23,7 +23,7 @@ public sealed record FgMixRecord(IReadOnlyList<FgMixRecordRow> Rows)
|
||||
/// <b>Read by today's rule</b> (beta.26): a stored state no window of this build would form — a factor above
|
||||
/// <see cref="FgWindow.GenerationCeiling"/>, or windows that averaged fewer than <see cref="FgWindow.MinPerBucket"/>
|
||||
/// application frames — is time no state claims, and joins the not-classified row. beta.24 and beta.25 stored such a
|
||||
/// row for a loading screen presented through with one token per window (Silent Hill 2, 2026-10-19: ×1336.0,
|
||||
/// row for a stretch presented through with one token per window (Silent Hill 2, 2026-10-19: ×1336.0,
|
||||
/// 0.20 → 267.20 FPS), and the summary listed it and the DLSS line cited it. Every other row is as stored, and the
|
||||
/// shares still add up to the whole.
|
||||
/// </remarks>
|
||||
|
||||
@@ -22,7 +22,7 @@ internal static class FgSlices
|
||||
/// <summary>
|
||||
/// A window a ratio can be read from: <see cref="FgWindow.MinPerBucket"/> presents AND as many application frames
|
||||
/// (beta.26). Presents alone let a window with ONE token through, and its ratio was the presents themselves: Silent
|
||||
/// Hill 2's loading screen read ×1336.0, a state the mix listed and the DLSS line cited.
|
||||
/// Hill 2's ten seconds at one token a window read ×1336.0, a state the mix listed and the DLSS line cited.
|
||||
/// </summary>
|
||||
public bool IsReadable => Samples >= FgWindow.MinPerBucket && Tokens >= FgWindow.MinPerBucket;
|
||||
|
||||
|
||||
@@ -178,9 +178,9 @@ public sealed record FgWindow
|
||||
/// Above this, a ratio is not frame generation. No shipping technology generates more than five frames per application
|
||||
/// frame (DLSS 4.5 multi frame generation, ×6; measured ×6.06 with DXGI's count, 2026-10-19), and ×8 leaves room for a
|
||||
/// window's edges. A ratio above it is a stretch the title presented through with almost no application-frame token —
|
||||
/// a loading screen or a menu drawn outside the vendor's frame count: Silent Hill 2 (2026-10-19) presented 1,336 times
|
||||
/// per token for ten seconds under the NVIDIA App's Dynamic multi frame generation, and the mix listed it as a ×1336.0
|
||||
/// state. Raised only with a title measured above it (beta.26).
|
||||
/// shaders compiling, a loading screen or a menu, drawn outside the vendor's frame count: Silent Hill 2 (2026-10-19)
|
||||
/// presented 1,336 times per token for the first ten seconds of the session, compiling its shaders, under the NVIDIA
|
||||
/// App's Dynamic multi frame generation, and the mix listed it as a ×1336.0 state. Raised only with a title measured above it (beta.26).
|
||||
/// </summary>
|
||||
public const double GenerationCeiling = 8.0;
|
||||
|
||||
|
||||
@@ -132,7 +132,7 @@ public sealed class DlssTextTests
|
||||
});
|
||||
|
||||
/// <summary>
|
||||
/// beta.26: the owner's Silent Hill 2 session (2026-10-19) stored a ×1336.0 "state" — a loading screen at one token
|
||||
/// beta.26: the owner's Silent Hill 2 session (2026-10-19) stored a ×1336.0 "state" — ten seconds at one token
|
||||
/// per window — and the line read "DLSS 4.5 (a ×1336.0 frame-generation state)". Read by today's rule, the evidence is
|
||||
/// the ×6.1 state the session really held.
|
||||
/// </summary>
|
||||
|
||||
@@ -136,9 +136,10 @@ public sealed class FgMixTests
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// beta.26: Silent Hill 2 (2026-10-19) presented 1,336 times per token for ten seconds — a loading screen drawn outside
|
||||
/// the vendor's frame count — and the mix listed it as a ×1336.0 state, which the DLSS line then cited. A window needs
|
||||
/// application frames, not only presents, and a ratio frame generation can produce.
|
||||
/// beta.26: Silent Hill 2 (2026-10-19) presented 1,336 times per token for ten seconds — its first seconds, compiling
|
||||
/// shaders outside the vendor's frame count — and the mix listed it as a ×1336.0 state, which the DLSS line then
|
||||
/// cited. A window needs application frames, not only presents, and a ratio frame generation can
|
||||
/// produce.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public void AWindowWithOneTokenOrARatioNoFrameGenerationProducesIsNotAState()
|
||||
|
||||
Reference in new issue
Block a user