docs(handoff): 0.1.0-beta.45's release facts - the tag's run, the digests, the delta, the wiki, Qodana; and SonarCloud's gate, failed on the release's commit by 39 duplicated lines of one enum mirrored by design - the Domain's mirror is left out of duplication detection (#432)

- docs/HANDOFF.md: released 2026-11-12T16:40:42Z from the signed tag on 550d830 by run 43257803723; eight assets,
  seven digests equal, the build id in four natives, the delta 1,762,465 bytes, the wiki run, what Qodana said.
- SonarCloud's quality gate failed on 550d830 on duplicated lines on new code (3.7 % against 3 %), with no issue
  open: the six new members of FlHookFamily and of its Domain mirror HookFamilies, which are the same on purpose
  and held together by MetricEnumMirrorTests. SonarQube.Analysis.xml leaves the mirror out of the detection, with
  the reason there and in docs/13_CI_CD.md.

Whether the gate is green again is for the analysis of this commit on main to say.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This commit is contained in:
poli0981andClaude Fable 5.2 authored and GitHub committed 2026-11-13 00:10:24 +07:00
1 parent 550d83089d
commit d3e8dd3609
3 files changed
+33 -5

No files matched your search

+8 -2
View File
@@ -25,8 +25,14 @@
-->
<Property Name="sonar.exclusions">src/native/third_party/**,**/Strings.Designer.cs,src/native/tools/hook-harness/dxr_raygen_dxil.h,src/native/tools/vendor-stubs/**,tests/fixtures/**,legal/licenses/**,docs/vendor-exports.json,src/FrameLedger.Infrastructure/Persistence/Migrations/**,build/**,out/**,**/bin/**,**/obj/**,**/TestResults/**</Property>
<!-- Tests repeat their arrange steps on purpose; duplication there is not a defect. -->
<Property Name="sonar.cpd.exclusions">tests/**,src/native/tests/**</Property>
<!--
Tests repeat their arrange steps on purpose; duplication there is not a defect.
HookFamilies.cs is the Domain's mirror of FlHookFamily (ShmLayout.cs): Domain references nothing, so the enum is
written twice by design and MetricEnumMirrorTests fails when the two differ. Six members added at once
(0.1.0-beta.45) were 39 duplicated lines of 1,063 new ones, 3.7 % against the gate's 3 %, and failed it on the
release's commit with no issue open. The mirror is left out of the detection; FlHookFamily itself is not.
-->
<Property Name="sonar.cpd.exclusions">tests/**,src/native/tests/**,src/FrameLedger.Domain/Metrics/HookFamilies.cs</Property>
<Property Name="sonar.sourceEncoding">UTF-8</Property>
+4 -1
View File
@@ -357,7 +357,10 @@ from CI.
writes into the checkout, since the scanner walks all of it (`build/`, with the sources CMake fetches there, `out/`,
every `bin/` and `obj/`, `TestResults/`) — SonarCloud also drops what `.gitignore` names (the first run: "63 files
ignored because of scm ignore settings"), and the patterns say it in the file rather than rely on that; the same
duplication exclusions; C++20; UTF-8; the OpenCover paths; the compilation database;
duplication exclusions *(and, since 2026-11-12, `src/FrameLedger.Domain/Metrics/HookFamilies.cs`: the Domain's
mirror of `FlHookFamily`, the same enum twice by design and held together by `MetricEnumMirrorTests`. The six
members 0.1.0-beta.45 added to both were 3.7 % duplication on new code against the gate's 3 %, and failed the gate
on the release's commit with no issue open)*; C++20; UTF-8; the OpenCover paths; the compilation database;
**`sonar.cs.roslyn.ignoreIssues`** — Roslynator, Meziantou, the VS threading and the .NET
analyzers already gate the build, warnings as errors, and what they report at a lower severity is this project's
choice, so only SonarCloud's own rules are imported; and **two rules ignored where they apply by design** — `S8417`
+21 -2
View File
@@ -162,8 +162,27 @@ calls, with their measured cost) and [`18_GPU_VENDOR_APIS.md`](18_GPU_VENDOR_API
### Left open by this session
- **This release's own facts** — the tag's run, the digests, the delta — are not in any file yet: the release is cut
after this text. Record them in the next pull request, with what SonarCloud and Qodana said.
- ~~**This release's own facts** — the tag's run, the digests, the delta — are not in any file yet: the release is cut
after this text. Record them in the next pull request, with what SonarCloud and Qodana said.~~ **Recorded
2026-11-12: 0.1.0-beta.45 was released 2026-11-12T16:40:42Z** (23:40 in the owner's time zone) from the signed
tag on `550d830` (#431), by run 43257803723 — green at the first attempt, one run for the one tag push. Eight
assets; the seven digests of `SHA256SUMS.txt` equal the ones GitHub computed; the four shipped natives carry
`FL_BUILD_ID v0.1.0-beta.45`. The delta from beta.44 is 1,762,465 bytes beside a full package of 110,767,499 —
"Delta processed 0452 files. 0024 patched, 0428 unchanged". The wiki was published by run 43261335359. The
rehearsal on the release branch (run 43253780609, at `f4e3fe2`, the released tree) had made a delta of 1,779,418
bytes with the same file counts. **Qodana's two reports are green on `550d830`.** On the way Qodana's native
report found two index products in the harness's probe (#427), fixed before that pull request merged; every
later report was clean, and each was read before its merge. No required check failed on this train.
**SonarCloud's quality gate failed on `550d830`, on one condition: duplicated lines on new code, 3.7 % where the
gate allows 3 %.** No issue is open and coverage on new code is 98.6 %. The 39 lines are the six new members of
`FlHookFamily` (`ShmLayout.cs`) and of its Domain mirror `HookFamilies` — two enums that are the same on purpose
(Domain references nothing, and `MetricEnumMirrorTests` fails when they differ), which six members at once took
over a threshold that two at a time had stayed under. The job is advisory and the release was already cut. The
pull request that records this leaves the Domain's mirror out of duplication detection, with the reason in
`SonarQube.Analysis.xml` and in `13_CI_CD` §SonarCloud; **whether the gate is green again is for the analysis of
that commit on `main` to say**, and it is not in this text. One more thing the train showed: main's branch
protection wants a pull request up to date, so of two that were green at once the second (#430) had to be
rebased after the first merged, and ran its checks again.
- **No real game was run on this build.** Six new patch sites, tested with the harness and the stub; their cost
measured on the headers.
- **Off means off (item 42 (f)) has never been exercised on a real game**; it is item 43 (f) now, for all ten.