Compare commits
2
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
20aa9effaa | ||
|
|
a9b9402825 |
No files matched your search
@@ -1,6 +1,7 @@
|
||||
# CLAUDE.md — Build Instructions (BookmarkMagic)
|
||||
|
||||
A Chrome MV3 extension: offline bookmark import/export/edit.
|
||||
A Chrome MV3 extension — and since v1.3.0 a Firefox one, and on Edge Add-ons —
|
||||
for offline bookmark import/export/edit.
|
||||
This file is the entry point; the `docs/` suite is the specification.
|
||||
**When code and docs disagree, docs win — or stop and ask.**
|
||||
|
||||
@@ -10,7 +11,8 @@ This file is the entry point; the `docs/` suite is the specification.
|
||||
> (v1.0.0 live by 2026-08-03; v1.0.1 live, confirmed on the listing
|
||||
> 2026-10-28; v1.1.0 live, confirmed on the listing 2026-11-06; v1.2.0 live,
|
||||
> confirmed on the listing 2026-11-10; v1.2.1 released on GitHub 2026-11-10,
|
||||
> ⚠️ not yet submitted).
|
||||
> ⚠️ not yet submitted; v1.3.0 — Firefox and Edge, 1.2.1 included — released
|
||||
> on GitHub 2026-11-18, ⚠️ not yet submitted to any of the three stores).
|
||||
> Phases 0–9 are complete; since 2026-11-18 the project is in **maintenance
|
||||
> mode** — `/MAINTENANCE.md` is the policy (Phase 10 below).
|
||||
> That changes the rules of the game:
|
||||
@@ -41,7 +43,7 @@ This file is the entry point; the `docs/` suite is the specification.
|
||||
| docs/05_ALGORITHMS.md | Parser walk, normalize, dedupe, diff, write queue |
|
||||
| docs/06_UI.md | Tokens, layouts per tab, component inventory, a11y (§5 is the spec behind `/ACCESSIBILITY.md`) |
|
||||
| docs/07_I18N.md | chrome.i18n vs runtime store split, EN/VI/JA rules |
|
||||
| docs/08_MV3_COMPLIANCE.md | Manifest, permissions (bookmarks+storage ONLY), CWS rules |
|
||||
| docs/08_MV3_COMPLIANCE.md | Manifest, permissions (bookmarks+storage ONLY), CWS rules; Firefox §9, Edge §10 |
|
||||
| docs/09_SECURITY_PRIVACY.md | Threat model T1–T8, secure-coding bans |
|
||||
| docs/10_CODING_STANDARDS.md | Size limits, tsconfig, biome.json, knip.json, conventions |
|
||||
| docs/11_TESTING.md | Coverage gates, fixtures, suites, manual QA |
|
||||
@@ -222,6 +224,19 @@ with a write token, for pull requests from forks.** It checks out the base
|
||||
branch and only compares event text with constants. Never add a checkout of
|
||||
the pull request's head, a step that runs its code, or a `${{ }}` of a title
|
||||
or body inside a `run:` line to that file.
|
||||
Two more, from the port. **There is no Firefox in CI**: the fake's Firefox
|
||||
flavour (`11 §4`) is a reading of Firefox's source, not evidence, so a change
|
||||
to roots, separators or move indices needs a real Firefox before an AMO
|
||||
upload. And **every change now ships in two packages**: `verify:full` builds
|
||||
and checks both (`build:firefox`, `check:manifest -- --browser firefox`), and a
|
||||
string that names Chrome is false in one of them.
|
||||
**Exit:** ✔ v1.3.0 tagged and released 2026-11-18 (signed tag on `80c7190`,
|
||||
three checksum-verified packages; PR #44 merged at the reviewed head).
|
||||
Human-only ⚠️ (`00 §10` items 19–26): the `11 §5` passes — Chrome with the
|
||||
**1.2.0 → 1.3.0 upgrade over an existing profile**, a real Firefox 140+, Edge
|
||||
signed in with sync on — then the Chrome Web Store upload of 1.3.0 in place
|
||||
of 1.2.1, the first Firefox Add-ons version and the first Edge submission by
|
||||
hand, the store environments if automation is wanted, and native review.
|
||||
|
||||
## Working style
|
||||
|
||||
|
||||
@@ -1,7 +1,9 @@
|
||||
# 00 — Project Overview
|
||||
|
||||
> **Project:** BookmarkMagic
|
||||
> **Type:** Chrome/Chromium MV3 browser extension (open source, Chrome Web Store)
|
||||
> **Type:** MV3 browser extension for Chromium browsers and, since v1.3.0,
|
||||
> Firefox (open source; Chrome Web Store — Firefox Add-ons and Edge Add-ons
|
||||
> pending their first review)
|
||||
> **Owner:** poli0981 (GitHub) / SkullMute
|
||||
> **Repo:** `poli0981/bookmarkmagic` ✔
|
||||
> **License:** GPL-3.0-or-later
|
||||
@@ -33,6 +35,14 @@
|
||||
> the 1.2.0 → 1.2.1 upgrade over an existing profile, and a hand upload to
|
||||
> the store (`13 §1b`); until it clears review, installed users stay on 1.2.0.
|
||||
>
|
||||
> **v1.3.0 — Firefox and Edge — is RELEASED on GitHub, not yet on any store.**
|
||||
> Tagged and released 2026-11-18 (signed tag on `80c7190`, three
|
||||
> checksum-verified packages): a Firefox package (desktop, 140 or later), and
|
||||
> the Chrome package for Edge Add-ons as well, with 1.2.1 inside. ⚠️ Nothing
|
||||
> is submitted yet: the Chrome Web Store upload (in place of 1.2.1), the first
|
||||
> Firefox Add-ons version and the first Edge Add-ons submission are by hand,
|
||||
> after the owner's `11 §5` passes (§10 items 20–22).
|
||||
>
|
||||
> The project is now in **maintenance**, not construction: every change from
|
||||
> here reaches installed users through a store review, so it needs a version
|
||||
> bump, a CHANGELOG entry and an update submission (`13 §1b`). Sequencing lives
|
||||
@@ -43,7 +53,7 @@
|
||||
> upgrades, bug/UI/UX/accessibility/translation fixes, and features only when
|
||||
> they are on `15`'s roadmap or genuinely needed; requests for anything else
|
||||
> are closed by `triage.yml` (`12 §2.6`).
|
||||
> **Doc suite version:** 1.12 (2026-11-18 — maintenance mode)
|
||||
> **Doc suite version:** 1.13 (2026-11-18 — Firefox and Edge, v1.3.0)
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -30,7 +30,7 @@
|
||||
| svelte-check | ^4.7.8 | Type/template authority for `.svelte` files. Runs on the TS 6 API (see TypeScript above). |
|
||||
| **@types/node** | **^26** (matches the Node major) | Types for `node:fs`, `node:path`, `node:child_process` and `process`, which the test suite and `scripts/*.mjs` genuinely use. **Declared explicitly since 2026-08-03** — it used to arrive transitively, and WXT 0.21 stopped providing it. Types only: erased at build, so hard rule 2 (zero *runtime* dependencies) is untouched. |
|
||||
| jsdom | **^31.0** (was ^30 through v1.2.1, ^29 through v1.0.0) | Test DOM. Not interchangeable — `02 §3` picks jsdom over happy-dom because the Netscape walk depends on parse5's implied-end-tag behaviour. A major bump runs `tests/unit/dom-environment.test.ts` first; if that canary fails, pin rather than loosen the test. |
|
||||
| **Knip** | **^6** (6.44.2 as of 2026-11-18) | Dead code: unused files, exports, dependencies. Requires Node ≥ 20.19. v6 swapped the TypeScript backend for oxc-parser — confirm `compilers.svelte` is still the supported `.svelte` hook before scaffold (`10 §4`). |
|
||||
| **Knip** | **^6** (6.45.1 as of 2026-11-18) | Dead code: unused files, exports, dependencies. Requires Node ≥ 20.19. v6 swapped the TypeScript backend for oxc-parser — confirm `compilers.svelte` is still the supported `.svelte` hook before scaffold (`10 §4`). |
|
||||
| **Vitest** | **^5.1.0** (was ^4 through v1.0.1) | Unit tests. 5.0 changed `clearMocks` to default `true`, requires `vi.mock` at top level and fails unawaited async assertions; the suite needed no changes. Requires Node ≥ 22.12. |
|
||||
| @vitest/coverage-v8 | match Vitest | Coverage reporting (`text` + `lcov` for SonarCloud, `12 §2.5`). |
|
||||
|
||||
|
||||
@@ -42,6 +42,8 @@ Build-phase breakdown lives in `CLAUDE.md` (single source for sequencing).
|
||||
| **v1.2.1 released** | ✔ 2026-11-10 | PR #37, merged at the head that was reviewed. Signed tag on `d61318a`, GitHub Release with a `sha256sum -c`-verified zip (`4975b5df…ca13254`, 106 290 bytes). Its manifest differs from 1.2.0's only in `version`, and the file inventory is the same. SonarCloud's new-code gate failed the first push at 73.6 % — the live-sync wiring moved out of `EditTab` had no test — and passed once it had one. `announce` and store publish skipped (variables unset) |
|
||||
| **v1.2.1 submitted** | ⚠️ pending — or skipped | owner: the `11 §5` pass incl. the **1.2.0 → 1.2.1 upgrade over an existing profile**, a Windows contrast theme and a screen-reader pass over Alt+↑/↓, then the zip upload (`13 §1b`). 1.3.0 contains all of 1.2.1, so uploading 1.3.0 instead is the shorter path (`00 §10` item 20) |
|
||||
| 10 — maintenance mode, Firefox + Edge | ✔ 2026-11-18 | PR #42: Dependabot #39–#41 and their hand sync, the unfixable `picomatch` advisory recorded, a lockfile licence gate, `MAINTENANCE.md` with a feature form that classifies and `triage.yml` that closes out-of-policy requests, Qodana (`qodana-js`) beside SonarCloud — 27 first-run findings, none a defect. PR #44: Firefox and Edge Add-ons — Firefox's roots by GUID and the Bookmarks Menu as a fourth root, separators recognised by type, each browser's move index, Firefox's address limit, a second (Firefox) package with its own manifest gate, three store jobs in their own environments (CWS API v2), `BUILD.md` (the sources archive rebuilt the package byte for byte) |
|
||||
| **v1.3.0 released** | ✔ 2026-11-18 | PR #44, merged at the head that was reviewed (`42c78ec`; `main`'s tree identical). Signed tag on `80c7190`, GitHub Release with three packages and `SHA256SUMS.txt`, each `sha256sum -c`-verified after download — chrome `89c01451…fb921561` (107 946 bytes), firefox `45db6de9…8c09ef71` (108 100 bytes), sources `76799878…5fd6a4a4` (413 081 bytes). The Chrome manifest differs from 1.2.1's in `version` alone; the Firefox one adds `browser_specific_settings.gecko` and has no `minimum_chrome_version`. The store jobs and `announce` skipped (variables unset) |
|
||||
| **v1.3.0 submitted** | ⚠️ pending | owner: Chrome Web Store (in place of 1.2.1), the first Firefox Add-ons version and the first Edge Add-ons submission, each after its `11 §5` pass (`00 §10` items 20–22) |
|
||||
|
||||
**Verified on real browsers 2026-07-25:** Chrome and Brave, unpacked build.
|
||||
Until that point every phase had been tested only against a hand-rolled
|
||||
|
||||
Reference in new issue
Block a user