Compare commits

..
Author SHA1 Message Date
poli0981andClaude Opus 5.5 5e084e9cc3 docs(store): Edge listing names no other browser
Partner Center warned on the zh-CN description: "Avoid referencing other
browsers in your extension description such as Firefox". Edge's developer
policy (1.1.2) says a listing must not reference other browsers, and the
first Edge copy was the Chrome Web Store description with two bullets
swapped: the export bullet still listed seven browsers, and the swapped
import bullet itself named Chrome, Brave and Firefox.

- store/listing.*.md: Firefox Add-ons and Edge Add-ons get a heading
  each. The Edge section is a complete description, pasted whole, that
  names no browser but Edge: the profile "Bookmarks" file is the one "Edge
  and similar browsers keep", HTML export is "the standard bookmark file
  every major browser can import". Every other line matches the Chrome
  Web Store copy; the Firefox copy is unchanged.
- tests/unit/store-listing.test.ts: one Edge description per locale, 250
  to 5,000 characters, no other browser's name; and the same pattern must
  find the browsers the Chrome Web Store copy lists, so it cannot pass by
  matching nothing.
- docs/08 §10, docs/13 §9, docs/11 §4, store/README.md: the rule, where it
  is tested, and policy 1.5.2's "should" about the privacy policy, left
  as it is unless review raises it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 23:41:25 +07:00
9 changed files with 37 additions and 90 deletions

No files matched your search

+1 -5
View File
@@ -12,11 +12,7 @@ version bump).
## [Unreleased]
### Changed
- **About → Store listing** on a copy installed from Microsoft Edge Add-ons now
opens BookmarkMagic's Edge Add-ons page, live since 2026-11-19. Until now it
opened the install section of the project's README.
Nothing yet.
## [1.3.0] — 2026-11-18
+2 -7
View File
@@ -11,10 +11,8 @@ This file is the entry point; the `docs/` suite is the specification.
> (v1.0.0 live by 2026-08-03; v1.0.1 live, confirmed on the listing
> 2026-10-28; v1.1.0 live, confirmed on the listing 2026-11-06; v1.2.0 live,
> confirmed on the listing 2026-11-10; v1.2.1 released on GitHub 2026-11-10,
> never submitted on its own; v1.3.0 — Firefox and Edge, 1.2.1 included —
> released on GitHub and submitted to all three stores 2026-11-18, **live on
> Edge Add-ons 2026-11-19**, ⚠️ in review on the Chrome Web Store and Firefox
> Add-ons).
> ⚠️ not yet submitted; v1.3.0 — Firefox and Edge, 1.2.1 included — released
> on GitHub 2026-11-18, ⚠️ not yet submitted to any of the three stores).
> Phases 0–9 are complete; since 2026-11-18 the project is in **maintenance
> mode** — `/MAINTENANCE.md` is the policy (Phase 10 below).
> That changes the rules of the game:
@@ -239,9 +237,6 @@ Human-only ⚠️ (`00 §10` items 19–26): the `11 §5` passes — Chrome with
signed in with sync on — then the Chrome Web Store upload of 1.3.0 in place
of 1.2.1, the first Firefox Add-ons version and the first Edge submission by
hand, the store environments if automation is wanted, and native review.
The three uploads went up 2026-11-18; Edge approved 2026-11-19, the other two
are in review. **An Edge copy's About link is chosen by its CRX ID**
(`links.ts`), so the listing ids in `00 §9` are code, not trivia.
## Working style
+1 -2
View File
@@ -8,7 +8,6 @@
[![Quality gate](https://sonarcloud.io/api/project_badges/measure?project=poli0981_bookmarkmagic&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=poli0981_bookmarkmagic)
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=poli0981_bookmarkmagic&metric=coverage)](https://sonarcloud.io/summary/new_code?id=poli0981_bookmarkmagic)
[![Chrome Web Store](https://img.shields.io/chrome-web-store/v/eghnciphhegekmnofffpgbdfefckdhmg?label=Chrome%20Web%20Store)](https://chromewebstore.google.com/detail/bookmarkmagic/eghnciphhegekmnofffpgbdfefckdhmg)
[![Edge Add-ons](https://img.shields.io/badge/dynamic/json?url=https%3A%2F%2Fmicrosoftedge.microsoft.com%2Faddons%2Fgetproductdetailsbycrxid%2Fnchfchjnlihbifggooggpmmacighmdjg&query=%24.version&prefix=v&label=Edge%20Add-ons)](https://microsoftedge.microsoft.com/addons/detail/nchfchjnlihbifggooggpmmacighmdjg)
[![Runtime dependencies: 0](https://img.shields.io/badge/runtime%20dependencies-0-brightgreen.svg)](#privacy)
Move your bookmarks between browsers the simple way: with a file. No account,
@@ -121,7 +120,7 @@ Full policy: [`legal/PRIVACY.md`](legal/PRIVACY.md).
| Browser | Where | Requires |
|---|---|---|
| Chrome, Brave, Vivaldi, Opera | [Chrome Web Store](https://chromewebstore.google.com/detail/bookmarkmagic/eghnciphhegekmnofffpgbdfefckdhmg) | Chrome 136 or later (April 2025), or a Chromium browser of the same vintage |
| Microsoft Edge | [Edge Add-ons](https://microsoftedge.microsoft.com/addons/detail/nchfchjnlihbifggooggpmmacighmdjg) | Edge 136 or later |
| Microsoft Edge | Edge Add-ons — **not listed yet**; until it is, Edge installs from the Chrome Web Store link above | Edge 136 or later |
| Firefox (desktop) | Firefox Add-ons — **not listed yet**; the link will be here when it is | Firefox 140 or later. Firefox for Android has no bookmarks API for extensions |
On an older browser the store keeps the version you already have and simply
+21 -34
View File
@@ -2,8 +2,8 @@
> **Project:** BookmarkMagic
> **Type:** MV3 browser extension for Chromium browsers and, since v1.3.0,
> Firefox (open source; Chrome Web Store and, since 2026-11-19, Microsoft Edge
> Add-ons — Firefox Add-ons pending its first review)
> Firefox (open source; Chrome Web Store — Firefox Add-ons and Edge Add-ons
> pending their first review)
> **Owner:** poli0981 (GitHub) / SkullMute
> **Repo:** `poli0981/bookmarkmagic` ✔
> **License:** GPL-3.0-or-later
@@ -28,21 +28,20 @@
> `e2f36bc`); the listing was observed showing **version 1.2.0** (`Updated:
> November 7, 2026`, 5 languages) on 2026-11-10. Installed users are on 1.2.0.
>
> **v1.2.1 — accessibility — is RELEASED on GitHub, never on a store on its
> own.** Tagged and released 2026-11-10 (signed tag on `d61318a`,
> checksum-verified zip): an accessibility statement (`/ACCESSIBILITY.md`) and
> the fixes an audit found (`06 §5`). 1.3.0 carries all of it and went to the
> Chrome Web Store in its place (submitted 2026-11-18); until that clears
> review, Chrome users stay on 1.2.0.
> **v1.2.1 — accessibility — is RELEASED on GitHub, not yet on the store.**
> Tagged and released 2026-11-10 (signed tag on `d61318a`, checksum-verified
> zip): an accessibility statement (`/ACCESSIBILITY.md`) and the fixes an
> audit found (`06 §5`). ⚠️ It still needs the owner's manual pass, including
> the 1.2.0 → 1.2.1 upgrade over an existing profile, and a hand upload to
> the store (`13 §1b`); until it clears review, installed users stay on 1.2.0.
>
> **v1.3.0 — Firefox and Edge — is RELEASED, and LIVE on Edge Add-ons.**
> **v1.3.0 — Firefox and Edge — is RELEASED on GitHub, not yet on any store.**
> Tagged and released 2026-11-18 (signed tag on `80c7190`, three
> checksum-verified packages): a Firefox package (desktop, 140 or later), and
> the Chrome package for Edge Add-ons as well, with 1.2.1 inside. The owner
> submitted it to all three stores on 2026-11-18. **Edge Add-ons approved it
> on 2026-11-19** — the first Edge version, live in five languages (§9 has the
> listing). ⚠️ The Chrome Web Store update (in place of 1.2.1) and the first
> Firefox Add-ons version are still in review (§10 items 20–21).
> the Chrome package for Edge Add-ons as well, with 1.2.1 inside. ⚠️ Nothing
> is submitted yet: the Chrome Web Store upload (in place of 1.2.1), the first
> Firefox Add-ons version and the first Edge Add-ons submission are by hand,
> after the owner's `11 §5` passes (§10 items 20–22).
>
> The project is now in **maintenance**, not construction: every change from
> here reaches installed users through a store review, so it needs a version
@@ -194,9 +193,6 @@ Derived identifiers (canonical across docs and code):
| Safety-backup filename | `bookmarkmagic-backup-YYYYMMDD-HHmm.json` |
| Chrome Web Store item id | `eghnciphhegekmnofffpgbdfefckdhmg` (also the value `CHROME_EXTENSION_ID` needs — `12 §3`) |
| Store listing URL | `https://chromewebstore.google.com/detail/bookmarkmagic/eghnciphhegekmnofffpgbdfefckdhmg` |
| Edge Add-ons item id ("CRX ID") | `nchfchjnlihbifggooggpmmacighmdjg` — the `runtime.id` of an install from Edge Add-ons, mapped in `links.ts` (`06 §3.5`) |
| Edge Add-ons Product ID | `3bf2e086-99ee-4f8b-a8db-e13827f04ca1` (the value `EDGE_PRODUCT_ID` needs — `12 §3`) · Store ID `0RDCKC9LZ41P` |
| Edge Add-ons listing URL | `https://microsoftedge.microsoft.com/addons/detail/nchfchjnlihbifggooggpmmacighmdjg` (live 2026-11-19) |
## 10. Manual action items (human-only) ⚠️
@@ -306,23 +302,17 @@ Derived identifiers (canonical across docs and code):
19. ⚠️ **Pin the maintenance announcement** (Discussions #43) — the API cannot.
20. ⚠️ **v1.3.0 to the Chrome Web Store** instead of 1.2.1, which never went
up — **submitted 2026-11-18, in review**. The `11 §5` pass with the
**1.2.0 → 1.3.0 upgrade over an existing profile**, then the Chrome
package from the Release (`13 §1b`). The CWS
up: the `11 §5` pass with the **1.2.0 → 1.3.0 upgrade over an existing
profile**, then the Chrome package from the Release (`13 §1b`). The CWS
listing text may keep its Chrome wording; it is the Chrome store.
21. ⚠️ **The first Firefox Add-ons version, by hand** (`13 §8`) — **submitted
2026-11-18, in review**. The `11 §5` Firefox section on a real Firefox
140+, then the Developer Hub upload of
21. ⚠️ **The first Firefox Add-ons version, by hand** (`13 §8`): the `11 §5`
Firefox section on a real Firefox 140+, then the Developer Hub upload of
the Firefox package **and** the sources archive, desktop only, with
`BUILD.md` in the notes to reviewers. AMO's upload validator report is the
first outside check of the package.
22. ✔ **The first Edge Add-ons submission, by hand** (`13 §9`) — submitted
2026-11-18, **approved and live 2026-11-19** (§9). Partner Center flagged
the first description for naming another browser; the Edge copy now names
none (PR #47, `08 §10`). ⚠️ Still open: the `11 §5` Edge items have no
recorded result — above all a profile **signed in with sync on**
(`08 §10`, unverified). An Edge user who meets `NO_WRITABLE_ROOTS` would be
the first sign.
22. ⚠️ **The first Edge Add-ons submission, by hand** (`13 §9`): a Partner
Center account, the `11 §5` Edge items — above all a profile **signed in
with sync on** (`08 §10`, unverified) — then the Chrome package.
23. ⚠️ **Store automation, when wanted** (`12 §3`): the three environments,
each with a required reviewer, deployments limited to `v*` tags, and its
secrets (Chrome: API v2 service
@@ -330,10 +320,7 @@ Derived identifiers (canonical across docs and code):
then the `*_AUTOPUBLISH` variables.
24. ⚠️ **After the listings go live**: their URLs for the README and the
About link (`06 §3.5` — Edge's needs its listing id), and the AMO/Edge
badges. **Edge ✔ 2026-11-19**: README install table and badge, and the
About link's mapping (ships with the next release — CHANGELOG
`[Unreleased]`). AMO still to come: its About link is already the gecko-id
URL, so only the README row and a badge remain.
badges.
25. ⚠️ **Evidence for the Firefox fake** (`11 §4`): a sanitized `getTree()`
dump from a real Firefox 140+ profile, committed as a fixture the fake is
checked against; and a Firefox column in `11 §6`'s parse timing.
+4 -6
View File
@@ -398,12 +398,10 @@ only route a user has from inside the product to rate or review it, which
`13 §6` depends on. Since v1.3.0 one package serves the Chrome Web Store and
Edge Add-ons, so the link is chosen at run time (`links.ts` `storeUrlFor`):
the Firefox build → the AMO listing, addressed by the gecko id; a Chromium
copy whose `runtime.id` is a store's item id (`00 §9`) → that store's
listing — the Chrome Web Store's, or Edge Add-ons' (mapped after the listing
went live on 2026-11-19, so from the release after 1.3.0); anything else — an
unpacked build → the README's install section, which lists every store. 1.3.0
itself sends an Edge Add-ons install to that section, which links the Edge
listing too. The label was "Chrome Web Store" until v1.3.0.
copy whose `runtime.id` is the Chrome Web Store item id (`00 §9`) → that
listing; anything else — an Edge Add-ons install, an unpacked build → the
README's install section, which lists every store. The label was "Chrome Web
Store" until then.
**No email address appears anywhere in the product.** Since v1.1.0 the
project's addresses are per purpose (`security@` in `SECURITY.md`, `privacy@` in
+1 -5
View File
@@ -340,11 +340,7 @@ Still ship the fix forward.
`08 §5`; privacy policy URL as above; screenshots from `store/screenshots/`.
5. Submit; record the outcome in `15`. Note the **Product ID** on the
extension's overview page — `EDGE_PRODUCT_ID` — and the listing URL, which
the About link and the README can then use (`06 §3.5`). The About link
matches the **CRX ID** (the `runtime.id` an install reports), not the
Product ID.
Done for 1.3.0: submitted 2026-11-18, live 2026-11-19 — ids and listing
in `00 §9`.
the About link and the README can then use (`06 §3.5`).
**Later versions:** by hand (*Update* → upload the new package), or from
`release.yml`'s `store-edge` job once `edge-add-ons` has its secrets and
+2 -4
View File
@@ -40,12 +40,10 @@ Build-phase breakdown lives in `CLAUDE.md` (single source for sequencing).
| **v1.2.0 published** | ✔ observed 2026-11-10 | the listing shows version 1.2.0 (`Updated: November 7, 2026`), 3 users, "5 languages" — English, Tiếng Việt, română, 中文(中国), 日本語. ⚠️ As for 1.0.1 and 1.1.0, `13 §1b` step 10 (clean-profile install of the published build + upgrade re-check) has no recorded result |
| 9 — v1.2.1 accessibility | ✔ 2026-11-10 | `ACCESSIBILITY.md` and its intake (issue form, PR checklist, `accessibility@`); the defects an audit of `src/` found that a keyboard-and-Narrator pass had not — an invisible focus ring on the theme control, no forced-colours support, drag-only reordering (Alt+↑/↓), focus dropped on `<body>` in three places, targets under 24 px; dependency sync after Dependabot #31/#32/#35/#36 (`06 §5`) |
| **v1.2.1 released** | ✔ 2026-11-10 | PR #37, merged at the head that was reviewed. Signed tag on `d61318a`, GitHub Release with a `sha256sum -c`-verified zip (`4975b5df…ca13254`, 106 290 bytes). Its manifest differs from 1.2.0's only in `version`, and the file inventory is the same. SonarCloud's new-code gate failed the first push at 73.6 % — the live-sync wiring moved out of `EditTab` had no test — and passed once it had one. `announce` and store publish skipped (variables unset) |
| **v1.2.1 submitted** | skipped — 1.3.0 went up in its place on 2026-11-18 | owner: the `11 §5` pass incl. the **1.2.0 → 1.2.1 upgrade over an existing profile**, a Windows contrast theme and a screen-reader pass over Alt+↑/↓, then the zip upload (`13 §1b`). 1.3.0 contains all of 1.2.1, so uploading 1.3.0 instead is the shorter path (`00 §10` item 20) |
| **v1.2.1 submitted** | ⚠️ pending — or skipped | owner: the `11 §5` pass incl. the **1.2.0 → 1.2.1 upgrade over an existing profile**, a Windows contrast theme and a screen-reader pass over Alt+↑/↓, then the zip upload (`13 §1b`). 1.3.0 contains all of 1.2.1, so uploading 1.3.0 instead is the shorter path (`00 §10` item 20) |
| 10 — maintenance mode, Firefox + Edge | ✔ 2026-11-18 | PR #42: Dependabot #39–#41 and their hand sync, the unfixable `picomatch` advisory recorded, a lockfile licence gate, `MAINTENANCE.md` with a feature form that classifies and `triage.yml` that closes out-of-policy requests, Qodana (`qodana-js`) beside SonarCloud — 27 first-run findings, none a defect. PR #44: Firefox and Edge Add-ons — Firefox's roots by GUID and the Bookmarks Menu as a fourth root, separators recognised by type, each browser's move index, Firefox's address limit, a second (Firefox) package with its own manifest gate, three store jobs in their own environments (CWS API v2), `BUILD.md` (the sources archive rebuilt the package byte for byte) |
| **v1.3.0 released** | ✔ 2026-11-18 | PR #44, merged at the head that was reviewed (`42c78ec`; `main`'s tree identical). Signed tag on `80c7190`, GitHub Release with three packages and `SHA256SUMS.txt`, each `sha256sum -c`-verified after download — chrome `89c01451…fb921561` (107 946 bytes), firefox `45db6de9…8c09ef71` (108 100 bytes), sources `76799878…5fd6a4a4` (413 081 bytes). The Chrome manifest differs from 1.2.1's in `version` alone; the Firefox one adds `browser_specific_settings.gecko` and has no `minimum_chrome_version`. The store jobs and `announce` skipped (variables unset) |
| **v1.3.0 submitted** | ✔ 2026-11-18 | by the owner, to all three stores: the Chrome Web Store (in place of 1.2.1), the first Firefox Add-ons version and the first Edge Add-ons submission. Partner Center flagged the first Edge description for naming another browser — the Edge copy now names none (PR #47). ⚠️ The `11 §5` passes (`00 §10` items 20–22) have no recorded result |
| **v1.3.0 on Edge Add-ons** | ✔ live 2026-11-19 | approved on the first submission: listing `microsoftedge.microsoft.com/addons/detail/nchfchjnlihbifggooggpmmacighmdjg`, category Productivity, public, five languages. Policy 1.5.2 (a privacy policy that refers "primarily" to Edge, `08 §10`) did not block it. README install row and badge, and the About link's mapping for the next release, followed the same day (`00 §10` item 24) |
| **v1.3.0 on the Chrome Web Store / Firefox Add-ons** | ⚠️ in review | — |
| **v1.3.0 submitted** | ⚠️ pending | owner: Chrome Web Store (in place of 1.2.1), the first Firefox Add-ons version and the first Edge Add-ons submission, each after its `11 §5` pass (`00 §10` items 20–22) |
**Verified on real browsers 2026-07-25:** Chrome and Brave, unpacked build.
Until that point every phase had been tested only against a hand-rolled
+3 -20
View File
@@ -33,22 +33,6 @@ const CWS_ITEM_ID = 'eghnciphhegekmnofffpgbdfefckdhmg';
/** The published Chrome Web Store listing. */
const CWS_URL = `https://chromewebstore.google.com/detail/bookmarkmagic/${CWS_ITEM_ID}`;
/**
* The Edge Add-ons item id — Partner Center's "CRX ID", and the `runtime.id`
* of every copy installed from Edge Add-ons (docs/00 §9). Not the Product ID,
* which is what the `EDGE_PRODUCT_ID` secret needs.
*/
const EDGE_ITEM_ID = 'nchfchjnlihbifggooggpmmacighmdjg';
/** The published Edge Add-ons listing (live since 2026-11-19). */
const EDGE_URL = `https://microsoftedge.microsoft.com/addons/detail/${EDGE_ITEM_ID}`;
/** Each Chromium store's item id → its listing. */
const CHROMIUM_LISTINGS: ReadonlyMap<string, string> = new Map([
[CWS_ITEM_ID, CWS_URL],
[EDGE_ITEM_ID, EDGE_URL],
]);
/**
* The Firefox Add-ons listing, addressed by the gecko id, which AMO resolves
* (docs/13 §8). The "@" is percent-encoded on purpose: AMO decodes it, and the
@@ -65,9 +49,8 @@ const INSTALL_URL = `${REPO_URL}#install`;
* The only route from inside the product to rating or reviewing it, which
* docs/13 §6 lists as a post-launch channel. One Chromium package serves the
* Chrome Web Store and Edge Add-ons, so the Chromium choice is made at run
* time, by extension id: each store's own id gets its listing (an Edge user
* who installed from the Chrome Web Store has that store's id, and gets that
* listing), any other id (an unpacked build) the install section.
* time, by extension id: the Chrome Web Store's own id gets its listing, any
* other (an Edge Add-ons install, an unpacked build) the install section.
*
* There is deliberately **no support email here.** Putting an address on an
* in-product surface invites users to mail their real bookmarks file, which is
@@ -78,7 +61,7 @@ const INSTALL_URL = `${REPO_URL}#install`;
*/
export function storeUrlFor(install: { firefox: boolean; extensionId: string }): string {
if (install.firefox) return AMO_URL;
return CHROMIUM_LISTINGS.get(install.extensionId) ?? INSTALL_URL;
return install.extensionId === CWS_ITEM_ID ? CWS_URL : INSTALL_URL;
}
export interface LabelledLink {
+2 -7
View File
@@ -116,13 +116,8 @@ describe('store listing', () => {
const amo = storeUrlFor({ firefox: true, extensionId: 'anything' });
expect(amo).toBe('https://addons.mozilla.org/firefox/addon/bookmarkmagic%40poli0981.dev/');
expect(decodeURIComponent(amo)).toContain('bookmarkmagic@poli0981.dev');
// Edge Add-ons assigns its own id — Partner Center's "CRX ID", not the
// Product ID — and an install from there gets the Edge listing.
expect(storeUrlFor({ firefox: false, extensionId: 'nchfchjnlihbifggooggpmmacighmdjg' })).toBe(
'https://microsoftedge.microsoft.com/addons/detail/nchfchjnlihbifggooggpmmacighmdjg',
);
// A Chromium copy with any other id — an unpacked build gets a random
// one — goes to the list of every store.
// A Chromium copy with any other id — Edge Add-ons assigns its own, an
// unpacked build gets a random one — goes to the list of every store.
expect(storeUrlFor({ firefox: false, extensionId: 'abcdefghijklmnopabcdefghijklmnop' })).toBe(
`${REPO_URL}#install`,
);