chore(deps): take the two open Dependabot bumps, with the manifest proved unchanged
Applied directly rather than merged: both branches predate this phase and would have reverted `verify:full`. **wxt ^0.20.27 → ^0.21.3.** A 0.x minor is semver's breaking slot, and WXT is what emits the shipped manifest — so the acceptance test was a byte diff of the built artifact, not a green suite. Manifest, file inventory (content hashes stripped) and bundle size all came out identical, permissions unchanged, zip name unchanged. It *did* break two things, both dev-only: `wxt/testing` split into `wxt/testing/fake-browser` and `wxt/testing/vitest-plugin`, and `tabs.create` is now typed as returning void. That split is the point of the ritual. `npm run test` passed before the bump and the *config load* failed after it — while `tests/unit/manifest.test.ts`, the test that looks like it guards the manifest, would have stayed green whatever WXT emitted, because it reads wxt.config.ts and a WXT upgrade cannot change that file. The check-manifest key-set gate added in the previous commit is what makes the next one CI's problem rather than a manual comparison someone has to remember to do. **jsdom ^29.1.1 → ^30.0.1.** Canary first: tests/unit/dom-environment.test.ts pins the parse5 behaviour the Netscape walk depends on — implied end tags, and `:scope >` from an element root. It passed, then the parser, fixture and round-trip suites, then coverage, all unchanged. The 2 869 ms figure in docs/11 §6 is now labelled as a jsdom 29 number; a DOM major invalidates it rather than updating it. **svelte-check ^4.7.3 → ^4.7.4.** A patch. npm audit stays at 0, and none of the six `overrides` can be dropped yet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
10 files changed
+151
-3283
No files matched your search
@@ -19,12 +19,13 @@
|
||||
|---|---|---|
|
||||
| Node.js | **24.x (Active LTS)** | Build runtime. Active LTS until Oct 2026, maintained to 2028-04-30. Node 26 is *Current*, not LTS — do not use for production tooling yet. |
|
||||
| npm | bundled with Node 24 (v11) | Package manager. Commit `package-lock.json`. |
|
||||
| **WXT** | **^0.20.27** | Extension framework: entrypoints, manifest generation, HMR, `wxt zip`, `wxt submit`. |
|
||||
| **WXT** | **^0.21.3** (was ^0.20.27 through v1.0.0) | Extension framework: entrypoints, manifest generation, HMR, `wxt zip`, `wxt submit`. **0.x, so a minor is semver's breaking slot** — and 0.21 was: `wxt/testing` split into `wxt/testing/fake-browser` and `wxt/testing/vitest-plugin`, and `tabs.create` is now typed as returning `void`. Both are dev-only. Never take a WXT bump without diffing the **built** manifest before and after (`12 §2.3`); `tests/unit/manifest.test.ts` reads `wxt.config.ts` and is structurally incapable of noticing. |
|
||||
| **TypeScript** | **~6.0.3** (strict) | Deliberate exception to "latest stable": TS **7.0 went GA 2026-07-08** (7.0.2 is `dist-tags.latest`), but the Go-native compiler exposes no stable programmatic API yet and Microsoft's own GA post says Svelte/Volar toolchains "can only currently rely on TypeScript 6.0" — full support is deferred to 7.1. Since `svelte-check` is our template type authority, we hold on 6.x. Pin with `~` (patch-only). Revisit when TS 7.1 ships **and** svelte-check declares support. |
|
||||
| **Svelte** | **^5.56.4** | UI, runes mode only (`$state`, `$derived`, `$effect`, `$props`). |
|
||||
| @wxt-dev/module-svelte | latest at scaffold | WXT ↔ Svelte integration. |
|
||||
| **Biome** | **2.5.2 (pinned exact)** | Lint + format (replaces ESLint + Prettier). Install with `npm i -D -E @biomejs/biome` per Biome guidance. |
|
||||
| svelte-check | ^4.7.1 | Type/template authority for `.svelte` files. |
|
||||
| svelte-check | ^4.7.4 | Type/template authority for `.svelte` files. |
|
||||
| jsdom | **^30** (was ^29 through v1.0.0) | Test DOM. Not interchangeable — `02 §3` picks jsdom over happy-dom because the Netscape walk depends on parse5's implied-end-tag behaviour. A major bump runs `tests/unit/dom-environment.test.ts` first; if that canary fails, pin rather than loosen the test. |
|
||||
| **Knip** | **^6** (6.29.0 latest as of 2026-07) | Dead code: unused files, exports, dependencies. Requires Node ≥ 20.19. v6 swapped the TypeScript backend for oxc-parser — confirm `compilers.svelte` is still the supported `.svelte` hook before scaffold (`10 §4`). |
|
||||
| **Vitest** | latest stable at scaffold | Unit tests for `src/lib/core`. |
|
||||
| @vitest/coverage-v8 | match Vitest | Coverage reporting. |
|
||||
|
||||
+1
-1
@@ -196,7 +196,7 @@ failure mode that would hit every installed user at once.
|
||||
### Measured 2026-07-26 — Phase 5
|
||||
|
||||
A generated 100 000-node Netscape file (11.2 MB, 99 000 bookmarks in 1 000
|
||||
folders), timed **under jsdom**:
|
||||
folders), timed **under jsdom 29**:
|
||||
|
||||
| Stage | Time |
|
||||
|---|---|
|
||||
|
||||
@@ -201,4 +201,7 @@ independently of the package (`13 §5`), though the copy should still go through
|
||||
| 2026-08-03 | **`NO_WRITABLE_ROOTS` is its own error, not `BROWSER`.** A profile with no writable root is an absence, not a refusal; reporting "the browser refused" sends the user looking for the wrong thing | 02 §7 |
|
||||
| 2026-08-03 | **Search-driven expansion is undone when the search clears**, tracked separately from folders the user opened by hand. Merging into `expanded` was deliberate (a render-time union broke the disclosure button) — the missing half was the un-merge | 03 §3, 06 §3.3 |
|
||||
| 2026-08-03 | **The "if you contact us" paragraph in `legal/PRIVACY.md` is a clarification, not a material change** — it describes what happens to data a user chooses to send, which was never inside "what the extension collects". `LEGAL_VERSION` deliberately **not** bumped: re-showing the gate to every installed user over a patch is a worse outcome than the ambiguity it fixes | 14 §2, 14 §3 |
|
||||
| 2026-08-03 | **A WXT bump is accepted only after diffing the BUILT manifest**, not on a green test run. `tests/unit/manifest.test.ts` reads `wxt.config.ts`, which a WXT upgrade cannot change, so it stays green no matter what WXT emits. 0.21.3 was verified byte-identical in manifest, file inventory and bundle size; it did break `wxt/testing` into two subpaths and retype `tabs.create` as `void`, both dev-only. `check-manifest.mjs` now asserts the exact top-level key set so the next one is caught by CI rather than by hand | 01 §2, 12 §2.3 |
|
||||
| 2026-08-03 | **jsdom 30 accepted after running `dom-environment.test.ts` first.** The canary exists because the Netscape walk depends on parse5's implied-end-tag behaviour; the rule is that a failing canary pins the dependency, never loosens the test. The 2 869 ms figure in `11 §6` is a jsdom **29** number and a major bump adds a column rather than overwriting it | 01 §2, 11 §6 |
|
||||
| 2026-08-03 | **A notification must never change the colour of the thing it reports on.** `notify-ci-failure.yml` had been failing on *every* CI completion, success included, because the reusable declares a secret that does not exist and GitHub validates that before the reusable's own success filter runs. Same lesson as `5f4c6e7`, learned twice | 12 §2.4 |
|
||||
| 2026-08-03 | **No support email on any in-product surface.** About links to the store listing, the repo, issues and the changelog. Publishing an address inside the extension invites unsanitized bookmark files by mail, which is the exact receipt-of-personal-data problem the privacy clause exists to bound. The address stays in `SECURITY.md`, `CONTRIBUTING.md` and the privacy policy | 06 §3.5, 09 §6 |
|
||||
Generated
+125
-3267
File diff suppressed because it is too large.
Load diff
+3
-3
@@ -41,13 +41,13 @@
|
||||
"@sveltejs/vite-plugin-svelte": "^7.2.0",
|
||||
"@vitest/coverage-v8": "^4.1.10",
|
||||
"@wxt-dev/module-svelte": "^2.0.5",
|
||||
"jsdom": "^29.1.1",
|
||||
"jsdom": "^30.0.1",
|
||||
"knip": "^6.29.0",
|
||||
"svelte": "^5.56.8",
|
||||
"svelte-check": "^4.7.3",
|
||||
"svelte-check": "^4.7.4",
|
||||
"typescript": "~6.0.3",
|
||||
"vitest": "^4.1.10",
|
||||
"wxt": "^0.20.27"
|
||||
"wxt": "^0.21.3"
|
||||
},
|
||||
"overrides": {
|
||||
"shell-quote": "^1.9.0",
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { fakeBrowser } from 'wxt/testing';
|
||||
import { fakeBrowser } from 'wxt/testing/fake-browser';
|
||||
import { openBookmarkUrl } from '@/lib/browser/open-url';
|
||||
|
||||
/**
|
||||
@@ -8,18 +8,24 @@ import { openBookmarkUrl } from '@/lib/browser/open-url';
|
||||
* `javascript:` bookmark and the browser acting on it. It had no test.
|
||||
*/
|
||||
|
||||
let created: { url?: string }[] = [];
|
||||
/**
|
||||
* Recorded `tabs.create` calls.
|
||||
*
|
||||
* `url?: string | undefined` rather than `url?: string`: the API's own
|
||||
* `CreateProperties` declares it that way, and under
|
||||
* `exactOptionalPropertyTypes` the two are different types.
|
||||
*/
|
||||
let created: { url?: string | undefined }[] = [];
|
||||
|
||||
beforeEach(() => {
|
||||
fakeBrowser.reset();
|
||||
vi.restoreAllMocks();
|
||||
created = [];
|
||||
// fakeBrowser stubs tabs.* with "not implemented" throws.
|
||||
// fakeBrowser stubs tabs.* with "not implemented" throws. The mock resolves
|
||||
// with nothing because the API's return type is void — the caller ignores it,
|
||||
// and only the recorded call matters.
|
||||
vi.spyOn(fakeBrowser.tabs, 'create').mockImplementation(async (props) => {
|
||||
created.push(props);
|
||||
// SAFETY: the caller ignores the return value; only the recorded call
|
||||
// matters, and building a full Tab here would assert nothing.
|
||||
return {} as Awaited<ReturnType<typeof fakeBrowser.tabs.create>>;
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { fakeBrowser } from 'wxt/testing';
|
||||
import { fakeBrowser } from 'wxt/testing/fake-browser';
|
||||
import {
|
||||
DEFAULT_SETTINGS,
|
||||
readLegal,
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { fakeBrowser } from 'wxt/testing';
|
||||
import { fakeBrowser } from 'wxt/testing/fake-browser';
|
||||
import { LEGAL_VERSION } from '@/lib/core/limits';
|
||||
import {
|
||||
acceptLegal,
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { fakeBrowser } from 'wxt/testing';
|
||||
import { fakeBrowser } from 'wxt/testing/fake-browser';
|
||||
import { DEFAULT_SETTINGS } from '@/lib/browser/storage';
|
||||
import { getLocale } from '@/lib/i18n/index.svelte';
|
||||
import {
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
import { svelte } from '@sveltejs/vite-plugin-svelte';
|
||||
import { defineConfig } from 'vitest/config';
|
||||
import { WxtVitest } from 'wxt/testing';
|
||||
import { WxtVitest } from 'wxt/testing/vitest-plugin';
|
||||
|
||||
/**
|
||||
* jsdom, not happy-dom (docs/02 §3). The Netscape parser walk depends on
|
||||
|
||||
Reference in new issue
Block a user