feat(about): link the Chrome Web Store listing
docs/13 §6 counts store ratings and reviews as one of the three post-launch channels this project has, and there was no way to reach the listing from inside the extension — the listing URL appeared in exactly one place in the repo, the README, which a user who installed from the store never reads. Deliberately no support email alongside it. Publishing an address on an in-product surface invites people to mail their real bookmarks file, and a bookmarks export is a browsing history — the exact receipt of personal data legal/PRIVACY.md and docs/09 §6 are written to bound. contact@poli0981.dev stays in SECURITY.md and CONTRIBUTING.md, where it arrives next to the instruction to sanitize first. A test asserts links.ts contains no address, so the decision has to be made again on purpose rather than by accident. docs/06 §3.5 sanctioned the fourth link in PR A, before the code added it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
6 files changed
+53
-3
No files matched your search
@@ -1,7 +1,7 @@
|
||||
<script lang="ts">
|
||||
import { getAppVersion } from '../browser/app-info';
|
||||
import { dateTime, t } from '../i18n/index.svelte';
|
||||
import { CHANGELOG_URL, DONATE_LINKS, ISSUES_URL, LEGAL_URLS, REPO_URL } from '../links';
|
||||
import { CHANGELOG_URL, DONATE_LINKS, ISSUES_URL, LEGAL_URLS, REPO_URL, STORE_URL } from '../links';
|
||||
import { getAcceptance } from '../stores/legal.svelte';
|
||||
|
||||
const version = getAppVersion();
|
||||
@@ -33,6 +33,7 @@
|
||||
{t('about.changelog')} ↗
|
||||
</a>
|
||||
</li>
|
||||
<li><a href={STORE_URL} target="_blank" rel="noopener noreferrer">{t('about.store')} ↗</a></li>
|
||||
</ul>
|
||||
|
||||
<h2>{t('about.thirdParty')}</h2>
|
||||
|
||||
@@ -190,6 +190,7 @@ const dict = {
|
||||
repo: 'GitHub repository',
|
||||
issues: 'Report an issue',
|
||||
changelog: 'Releases and changelog',
|
||||
store: 'Chrome Web Store listing',
|
||||
thirdParty: 'Third-party dependencies: None',
|
||||
thirdPartyNote: 'BookmarkMagic ships no runtime libraries at all.',
|
||||
donate: 'Support development',
|
||||
|
||||
@@ -175,6 +175,7 @@ export default {
|
||||
repo: 'GitHub リポジトリ',
|
||||
issues: '問題を報告',
|
||||
changelog: 'リリースと変更履歴',
|
||||
store: 'Chrome ウェブストアのページ',
|
||||
thirdParty: 'サードパーティ依存: なし',
|
||||
thirdPartyNote: 'BookmarkMagic は実行時ライブラリを一切同梱していません。',
|
||||
donate: '開発を支援する',
|
||||
|
||||
@@ -174,6 +174,7 @@ export default {
|
||||
repo: 'Kho mã trên GitHub',
|
||||
issues: 'Báo lỗi',
|
||||
changelog: 'Bản phát hành và nhật ký thay đổi',
|
||||
store: 'Trang trên Chrome Web Store',
|
||||
thirdParty: 'Thư viện bên thứ ba: Không có',
|
||||
thirdPartyNote: 'BookmarkMagic không đi kèm bất kỳ thư viện chạy nào.',
|
||||
donate: 'Ủng hộ dự án',
|
||||
|
||||
@@ -19,6 +19,22 @@ export const ISSUES_URL = `${REPO_URL}/issues`;
|
||||
|
||||
export const CHANGELOG_URL = `${REPO_URL}/blob/main/CHANGELOG.md`;
|
||||
|
||||
/**
|
||||
* The published Chrome Web Store listing (item id — docs/00 §9).
|
||||
*
|
||||
* The only route from inside the product to rating or reviewing it, which
|
||||
* docs/13 §6 lists as a post-launch channel.
|
||||
*
|
||||
* There is deliberately **no support email here.** Putting an address on an
|
||||
* in-product surface invites users to mail their real bookmarks file, which is
|
||||
* a browsing history and exactly the receipt of personal data that
|
||||
* `legal/PRIVACY.md` and docs/09 §6 are written to bound. The address lives in
|
||||
* SECURITY.md, CONTRIBUTING.md and the privacy policy, where it arrives with
|
||||
* the instruction to sanitize first (docs/15 decision log, 2026-08-03).
|
||||
*/
|
||||
export const STORE_URL =
|
||||
'https://chromewebstore.google.com/detail/bookmarkmagic/eghnciphhegekmnofffpgbdfefckdhmg';
|
||||
|
||||
export interface LabelledLink {
|
||||
labelKey: string;
|
||||
url: string;
|
||||
|
||||
@@ -1,10 +1,17 @@
|
||||
import { existsSync } from 'node:fs';
|
||||
import { existsSync, readFileSync } from 'node:fs';
|
||||
import { basename, join } from 'node:path';
|
||||
import { afterEach, describe, expect, it } from 'vitest';
|
||||
import { getAppVersion } from '@/lib/browser/app-info';
|
||||
import { setLocale, t } from '@/lib/i18n/index.svelte';
|
||||
import type { Locale } from '@/lib/i18n/resolve-locale';
|
||||
import { CHANGELOG_URL, DONATE_LINKS, ISSUES_URL, LEGAL_URLS, REPO_URL } from '@/lib/links';
|
||||
import {
|
||||
CHANGELOG_URL,
|
||||
DONATE_LINKS,
|
||||
ISSUES_URL,
|
||||
LEGAL_URLS,
|
||||
REPO_URL,
|
||||
STORE_URL,
|
||||
} from '@/lib/links';
|
||||
|
||||
const LOCALES: Locale[] = ['en', 'vi', 'ja'];
|
||||
/** Vitest runs with cwd at the project root, which is where `legal/` lives. */
|
||||
@@ -83,6 +90,29 @@ describe('outbound links', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('store listing', () => {
|
||||
it('is the published item, and is the only in-product route to a review', () => {
|
||||
// docs/13 §6 counts store ratings as a post-launch channel; before this
|
||||
// there was no way to reach the listing from inside the extension at all.
|
||||
expect(STORE_URL.startsWith('https://chromewebstore.google.com/detail/')).toBe(true);
|
||||
// The item id doubles as the CHROME_EXTENSION_ID secret (docs/00 §9), so a
|
||||
// typo here is a typo in two places.
|
||||
expect(STORE_URL).toContain('eghnciphhegekmnofffpgbdfefckdhmg');
|
||||
});
|
||||
|
||||
it('puts no email address on any in-product surface', () => {
|
||||
// Deliberate — docs/15 decision log, 2026-08-03. An address inside the
|
||||
// extension invites users to mail their real bookmarks file, which is the
|
||||
// receipt of personal data legal/PRIVACY.md exists to bound. The address
|
||||
// belongs in SECURITY.md and CONTRIBUTING.md, where it arrives alongside
|
||||
// the instruction to sanitize first.
|
||||
const source = readFileSync(join(REPO_ROOT, 'src', 'lib', 'links.ts'), 'utf8');
|
||||
const code = source.replace(/\/\*\*[\s\S]*?\*\//g, '');
|
||||
expect(code).not.toMatch(/mailto:/);
|
||||
expect(code).not.toMatch(/@poli0981\.dev/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('getAppVersion', () => {
|
||||
it('returns an empty string rather than throwing when the manifest is unreadable', () => {
|
||||
// fakeBrowser has no packaged manifest, so this exercises the fallback.
|
||||
|
||||
Reference in new issue
Block a user