Files
youtube-generator/.github/workflows/release-desktop.yml
T
poli0981andClaude Opus 5.5 886d25b588 fix(quality): clear the 44 open SonarCloud issues
Regexes with super-linear backtracking (S8786 x16) are rewritten to stay
linear on long runs; each new pattern gives the same results as the old one
on 150k-450k fuzzed inputs (except where noted) and finishes adversarial
50k-character inputs in under 3 ms:
- tag-generator QUALIFIER_SUFFIX_RE starts just before a `:`/space run
  (`(^|[^:\s])…` + "$1"), never inside one
- timeline-parser matches `line.trimEnd()` with a greedy label, and renders
  with trimEnd(); cleanCpuName collapses whitespace before the patterns
- editor-store endings, Google Play urlPattern (lookahead for `id=`),
  channel-phrase punctuation, SPDX OR/AND split, legal-docs slug and link
  stripping (link text/URL may not contain `[`), base64url padding, and a
  loop for trailing slashes in the worker router

Others:
- S2871: sorts take the shared code-unit comparator (same order as before;
  THIRD_PARTY_NOTICES is unchanged)
- S4822: ErrorBoundary catches the logger import with .catch(), which a
  try/catch never could
- S3516: migrateProfilesState returns a new object
- S7773: Number.parseInt (x10)
- S9379: Modal takes an initialFocusRef (Radix onOpenAutoFocus), so the
  shortcut search box gets focus without an autoFocus attribute
- S2245: generateId drops the Math.random fallback; getRandomValues exists
  everywhere the app runs, and a non-random ID is worse than an error
- S4036: NOSONAR on the dev script's `git` call (PATH lookup by design)
- S6505/S8543: every workflow installs with `npm ci --ignore-scripts`, and CI
  runs `npm run cf:check` instead of `npx wrangler …`
- S6358: Android sets allowBackup="false" — app data is no longer copied to
  Google Drive backups; Backup & Restore moves it to a new phone

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 15:05:16 +07:00

135 lines
5.7 KiB
YAML

name: Release Desktop
on:
push:
tags: ["v*"]
# Manual re-run hook — lets us rebuild a release without deleting +
# recreating the tag. Useful when a transient runner failure (e.g.
# the macOS DMG bundler hitting an AppleScript flake) costs us one
# arch's binary on an otherwise-shipped tag.
workflow_dispatch:
inputs:
tag:
description: "Tag to build (e.g. v1.0.0). The job still expects the manifests to already carry this version."
required: true
type: string
permissions:
contents: read
jobs:
# Nothing gets built for a tag whose code does not pass the gate or whose
# six version fields disagree with the tag itself.
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ github.event.inputs.tag || github.ref }}
persist-credentials: false
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version-file: .node-version
# Release artifacts are built from a clean install: a cache written
# by any other workflow must not be able to feed into them.
package-manager-cache: false
- run: npm ci --ignore-scripts
- run: npm run typecheck
- run: npm run test:run
- run: npm run check:version
- run: npm run check:tauri
- name: Tag matches the manifests
env:
TAG: ${{ github.event.inputs.tag || github.ref_name }}
run: |
version="v$(node -p "require('./package.json').version")"
if [ "$version" != "$TAG" ]; then
echo "::error::Tag $TAG does not match package.json ($version)"
exit 1
fi
build:
needs: verify
permissions:
contents: write # create the draft release and upload the binaries
strategy:
fail-fast: false
matrix:
include:
# windows-latest serves the windows-2025-vs2026 image (VS 2026
# toolchain) from June 15, 2026. Tauri build (MSI + NSIS)
# verified on that exact image 2026-06-12, actions run
# 27388695090 — no runner pin needed.
- os: windows-latest
target: x86_64-pc-windows-msvc
# Default Windows bundles: MSI + NSIS (.exe). Both ship.
bundleArgs: ""
- os: macos-14
target: aarch64-apple-darwin
# macOS DMG bundling on hosted runners flakes inside
# `bundle_dmg.sh` (the AppleScript that sets icon
# positions in the DMG window times out on the headless
# runner). Build only the `.app` bundle; tauri-action
# tar.gzips it into a `.app.tar.gz` for upload. Users
# expand and drag-drop into /Applications.
#
# Intel macOS (x86_64) is NOT built — the `macos-13`
# free runner queue is functionally unavailable since
# GitHub started deprecating it. Revisit with a
# `universal-apple-darwin` build on this same runner if
# Intel support becomes a priority.
bundleArgs: "--bundles app"
- os: ubuntu-latest
target: x86_64-unknown-linux-gnu
# Default Linux bundles: AppImage + deb. Both ship.
bundleArgs: ""
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
# On `workflow_dispatch` checkout the requested tag; on a
# tag push we already get the tag commit by default.
ref: ${{ github.event.inputs.tag || github.ref }}
persist-credentials: false
# No dependency caches in a release job: a poisoned cache entry written
# by any other workflow would otherwise flow straight into the binaries.
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version-file: .node-version
# Release artifacts are built from a clean install: a cache written
# by any other workflow must not be able to feed into them.
package-manager-cache: false
# A master commit, not the regenerated `stable` branch — see rust.yml.
- uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8
with:
toolchain: stable
targets: ${{ matrix.target }}
- name: Install Linux dependencies
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install -y \
libwebkit2gtk-4.1-dev \
libgtk-3-dev \
libayatana-appindicator3-dev \
librsvg2-dev \
patchelf
- run: npm ci --ignore-scripts
- uses: tauri-apps/tauri-action@1deb371b0cd8bd54025b384f1cd735e725c4060f # v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# AppImage bundling on hosted runners flakes: linuxdeploy (itself
# an AppImage) needs FUSE to mount, which GitHub runners don't
# reliably provide → "failed to run linuxdeploy". Extract-and-run
# avoids FUSE; NO_STRIP skips a strip pass that also intermittently
# fails. (No-op on Windows / macOS.) Transient CDN 504s while
# *fetching* linuxdeploy are handled by re-running the job.
APPIMAGE_EXTRACT_AND_RUN: 1
NO_STRIP: true
with:
tagName: ${{ github.event.inputs.tag || 'v__VERSION__' }}
releaseName: "YTDescGen ${{ github.event.inputs.tag || 'v__VERSION__' }}"
releaseBody: "See the assets to download the installer for your platform."
releaseDraft: true
args: ${{ matrix.bundleArgs }} --target ${{ matrix.target }}