CI ran typecheck/lint/locales/test/build. Everything else the repo owned was
configured but never executed — `knip` was installed and configured yet ran
nowhere, Prettier had a config and no gate, and the six version fields the
release ritual bumps by hand had nothing watching them. This wires all of it
into the pipeline.
Correctness gaps this immediately caught:
- `tsconfig.json` covers only `src`, so tests/ and scripts/ were NEVER
type-checked. Adding `tsconfig.check.json` (+ `typecheck:all`) surfaced 53
errors, including three fields silently missing from the editor→engine
parity fixture: `videoStyleEra` (v0.22.0), `adEmail` + `gameKeyEmail`
(v0.34.0), and the four `endings*` fields (v0.16.0/v0.17.1). The fixture is
the guard against exactly that class of drift, and it had drifted itself.
- `vitest.config.ts` `include` matched only `*.test.ts`, so any `.test.tsx`
would have been collected by nobody and "passed" silently. Now `{ts,tsx}`.
New gates in ci.yml: `typecheck:all`, `format:check`, `knip`, `check:version`,
and an advisory `npm audit --audit-level=high` (advisory so a fresh transitive
advisory cannot redden every unrelated PR before Dependabot opens its fix).
Plus least-privilege `permissions: contents: read` — which also clears the
`actions/missing-workflow-permissions` code-scanning alert — and a
concurrency group that cancels superseded runs everywhere except `main`.
New scripts:
- `scripts/check-version-sync.ts` — asserts all SIX version fields agree
(package.json, package-lock root AND packages[""], tauri.conf.json,
Cargo.toml, Cargo.lock self-entry). Nothing else notices a missed one, and a
stale tauri.conf.json ships an installer that disagrees with its tag.
- `scripts/generate-locale-template.ts` — `npm run generate:locale` has been
advertised in package.json and docs/I18N.md step 1 since v0.1, but the file
was never committed, so the documented first step of adding a language
failed outright. Blocks the planned pt-BR + id work.
Dead code removed: the Rust `ensure_dir` command and its two scoped `opener:`
capabilities. Its documented caller, `openSettingsFolder()`, no longer exists
in `src/` — `opener:default` (all `openExternal` needs) is untouched. Also
`@tauri-apps/plugin-opener` left knip's ignore list now that it is genuinely
imported, and `DroppedReasonId` went from unused export to typing
PlaylistPage's dropped-reason state.
Security: the `js/incomplete-url-substring-sanitization` alert in
description-builder.test.ts was a real (if low-stakes) weak assertion —
`includes("itch.io")` also matches `https://itch.io.example.com/`, so the
test could pass on the wrong line. Now matches the full URL.
CHANGELOG: v0.31.0, v0.32.0 and v0.32.1 shipped as tagged releases but were
never logged, leaving the file jumping v0.33.0 → v0.30.0. Reconstructed from
the release commits in the file's existing house style.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>