main
4
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
ad523ea0fb |
chore(typescript): move to TypeScript 7 with an ES2025 target
TypeScript 7.0 is the native compiler and ships no JavaScript API, which typescript-eslint still needs. Install both, as Microsoft documents it: - "@typescript/native": "npm:typescript@^7.0.2" gives `tsc` = 7.0 - "typescript": "npm:@typescript/typescript6@^6.0.2" gives the 6.0 API that typescript-eslint loads (its peer range stops below 6.1), and `tsc6` CI fails if `tsc` ever resolves to TypeScript 6 (@typescript/old, pulled in by the 6.0 package, ships a `tsc` too). tsconfig.json (src): - target ES2025: the newest year TypeScript 7.0, esbuild and Vite all know - lib ES2022 + DOM: the browser floor (Vite's baseline-widely-available, Chrome 111 / Safari 16.4 / Firefox 114), because nothing polyfills - baseUrl removed (gone in 7.0; paths were already relative), DOM.Iterable dropped (merged into DOM), `types: []` spelled out, erasableSyntaxOnly and verbatimModuleSyntax on (both clean) tsconfig.check.json: lib ES2025 for tests, scripts, worker and build plugins. Platform floor: the Tauri build no longer lowers to es2020; it shares the web build's baseline (the stylesheet already needed Chromium 99+ / Safari 15.4+). macOS minimumSystemVersion is 11.0 (the build is arm64). Also: eslint.config.js uses ESLint's defineConfig (tseslint.config is deprecated); THIRD_PARTY_NOTICES names the real package behind an npm alias, sorted with a shared code-unit comparator (src/utils/sort.ts); Dependabot groups typescript + @typescript/*; a test's typed-array annotation follows TypeScript 7's lib.dom. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0c7fb31165 |
chore(release): v0.37.0 — dependency modernization
Every major the project had been sitting on, brought current. No user-facing
feature changes; the app should behave identically.
React 18 → 19 (+ types, @vitejs/plugin-react 6)
Tailwind 3 → 4
ESLint 9 → 10 (+ eslint-plugin-react-hooks 5 → 7)
Zustand 4 → 5
i18next 23 → 26, react-i18next 15 → 17
@testing-library/*, typescript-eslint 8.67, Vite/Vitest/tsx/knip patches
**React 19** needed exactly one source change: `useRef<T>(null)` is now typed
`RefObject<T | null>` rather than `RefObject<T>`. The old type quietly claimed a
ref was non-null before its element mounted; ScrollToTopButton now matches,
which makes its existing null check honest rather than defensive.
**Tailwind 4** moves configuration from `tailwind.config.ts` (deleted) into
CSS. The tokens live in an `@theme` block that maps Tailwind's names onto the
existing `:root` / `.light` variables, so the runtime theme toggle still owns
the values and keeps working untouched. `darkMode: "class"` becomes
`@custom-variant dark` — the app toggles a class on <html> rather than
following the OS, so the default prefers-color-scheme variant would be wrong.
Verified in the browser in both themes; a CSS migration fails visually, not at
build time.
**The lint upgrade earned its keep.** `react-hooks/set-state-in-effect` (new in
v7, React Compiler-aware) flagged seven sites. Four were real extra render
passes:
- use-online-status rewritten to `useSyncExternalStore`. It had been
re-reading `navigator.onLine` inside an effect to close the gap between
first render and the listeners attaching — subscribing properly removes the
gap instead of patching it.
- ShortcutHelpModal derives its filter from `open` instead of resetting state
in an effect, so a modal that is closed most of the time stops scheduling
work on unrelated parent updates.
- DraftIndicator and use-languages-ready now guard their setters.
Three remain as warnings, deliberately. They genuinely sync state FROM an
external source (i18next bundle readiness, a text mirror of a numeric store
field, a useMemo the compiler cannot preserve) and need a restructure rather
than a guard. Recorded in eslint.config.js with the reason — downgraded, not
silenced, and not a reason to hold back ESLint 10.
**lucide-react deliberately stays at 0.577.0.** 1.x removes every brand icon;
upstream dropped them for trademark reasons. Taking it would mean either a
generic globe beside a Facebook link or re-adding the marks ourselves and
inheriting the exposure lucide just shed. 0.577 already delivered the win —
main bundle 175 kB → 137 kB.
knip now ignores `tailwindcss`: after the migration its only reference is
`@import "tailwindcss"` in CSS, which knip does not follow.
Full gate green — typecheck, typecheck:all, lint, format:check,
validate:locales, knip, check:version, 692 tests, build — plus a browser check
of both themes with the editor and batch pages functional.
0.36.0 is reserved for the two new locales.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|
|
d2100d2d40 |
ci: enforce the checks the repo already had, and close the CHANGELOG gap
CI ran typecheck/lint/locales/test/build. Everything else the repo owned was
configured but never executed — `knip` was installed and configured yet ran
nowhere, Prettier had a config and no gate, and the six version fields the
release ritual bumps by hand had nothing watching them. This wires all of it
into the pipeline.
Correctness gaps this immediately caught:
- `tsconfig.json` covers only `src`, so tests/ and scripts/ were NEVER
type-checked. Adding `tsconfig.check.json` (+ `typecheck:all`) surfaced 53
errors, including three fields silently missing from the editor→engine
parity fixture: `videoStyleEra` (v0.22.0), `adEmail` + `gameKeyEmail`
(v0.34.0), and the four `endings*` fields (v0.16.0/v0.17.1). The fixture is
the guard against exactly that class of drift, and it had drifted itself.
- `vitest.config.ts` `include` matched only `*.test.ts`, so any `.test.tsx`
would have been collected by nobody and "passed" silently. Now `{ts,tsx}`.
New gates in ci.yml: `typecheck:all`, `format:check`, `knip`, `check:version`,
and an advisory `npm audit --audit-level=high` (advisory so a fresh transitive
advisory cannot redden every unrelated PR before Dependabot opens its fix).
Plus least-privilege `permissions: contents: read` — which also clears the
`actions/missing-workflow-permissions` code-scanning alert — and a
concurrency group that cancels superseded runs everywhere except `main`.
New scripts:
- `scripts/check-version-sync.ts` — asserts all SIX version fields agree
(package.json, package-lock root AND packages[""], tauri.conf.json,
Cargo.toml, Cargo.lock self-entry). Nothing else notices a missed one, and a
stale tauri.conf.json ships an installer that disagrees with its tag.
- `scripts/generate-locale-template.ts` — `npm run generate:locale` has been
advertised in package.json and docs/I18N.md step 1 since v0.1, but the file
was never committed, so the documented first step of adding a language
failed outright. Blocks the planned pt-BR + id work.
Dead code removed: the Rust `ensure_dir` command and its two scoped `opener:`
capabilities. Its documented caller, `openSettingsFolder()`, no longer exists
in `src/` — `opener:default` (all `openExternal` needs) is untouched. Also
`@tauri-apps/plugin-opener` left knip's ignore list now that it is genuinely
imported, and `DroppedReasonId` went from unused export to typing
PlaylistPage's dropped-reason state.
Security: the `js/incomplete-url-substring-sanitization` alert in
description-builder.test.ts was a real (if low-stakes) weak assertion —
`includes("itch.io")` also matches `https://itch.io.example.com/`, so the
test could pass on the wrong line. Now matches the full URL.
CHANGELOG: v0.31.0, v0.32.0 and v0.32.1 shipped as tagged releases but were
never logged, leaving the file jumping v0.33.0 → v0.30.0. Reconstructed from
the release commits in the file's existing house style.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|
|
a763f7c78a |
feat: Phase 1 MVP scaffold — core engine, i18n, UI, CI/CD
Complete Phase 1 implementation of YTDescGen: - Project setup: Vite 5 + React 18 + TypeScript strict + Tailwind CSS dark theme - Config layer: 7 video types, 10 genres, 7 platforms, rig/social fields - i18n: EN/VI/JA with separate UI and template namespaces + validation script - Core engine: title-builder, description-builder, tag-generator (pure TS, zero React) - 42 unit tests covering all engine functions - Zustand stores: editor + settings with localStorage persistence - UI: 6 primitives, 11 editor components, 4 output components, 3 layout components - Pages: Editor (form + quick preview) and Output (title/desc/tags + copy) - CI/CD: GitHub Actions for lint/typecheck/test/build + GitHub Pages deploy Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |