From d24bf1192e34f9790e2d92c25e14c60cce2e49e3 Mon Sep 17 00:00:00 2001 From: poli0981 <127664709+poli0981@users.noreply.github.com> Date: Sat, 3 Oct 2026 09:09:00 +0700 Subject: [PATCH] ci: pin dtolnay/rust-toolchain to a master commit workflow-lint started failing on every pull request: zizmor reports impostor-commit for dtolnay/rust-toolchain@6bed076 (# stable). The action's `stable` branch is regenerated from master (last on 2026-10-01), so the commit pinned from it no longer belongs to the repository's history, and the `# stable` comment no longer matches either. Pin 7e38f4b, the current master head (the regenerated `stable` is that commit plus a default toolchain), in rust.yml and both release workflows. Master keeps its history, and every step already passes `toolchain: stable`, which master's action.yml requires. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release-android.yml | 3 ++- .github/workflows/release-desktop.yml | 3 ++- .github/workflows/rust.yml | 5 ++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release-android.yml b/.github/workflows/release-android.yml index e8b50b4..d8a1454 100644 --- a/.github/workflows/release-android.yml +++ b/.github/workflows/release-android.yml @@ -73,7 +73,8 @@ jobs: - name: Install Android NDK (r27 LTS) run: sdkmanager "ndk;27.3.13750724" - - uses: dtolnay/rust-toolchain@6bed0761d98439e5a578e2877258200ad565ba87 # stable + # A master commit, not the regenerated `stable` branch — see rust.yml. + - uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 with: toolchain: stable targets: aarch64-linux-android,armv7-linux-androideabi,i686-linux-android,x86_64-linux-android diff --git a/.github/workflows/release-desktop.yml b/.github/workflows/release-desktop.yml index 068eb92..167bd8d 100644 --- a/.github/workflows/release-desktop.yml +++ b/.github/workflows/release-desktop.yml @@ -99,7 +99,8 @@ jobs: # Release artifacts are built from a clean install: a cache written # by any other workflow must not be able to feed into them. package-manager-cache: false - - uses: dtolnay/rust-toolchain@6bed0761d98439e5a578e2877258200ad565ba87 # stable + # A master commit, not the regenerated `stable` branch — see rust.yml. + - uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 with: toolchain: stable targets: ${{ matrix.target }} diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6bc0ba0..aa77633 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -36,7 +36,10 @@ jobs: sudo apt-get update sudo apt-get install -y libwebkit2gtk-4.1-dev libgtk-3-dev \ libayatana-appindicator3-dev librsvg2-dev patchelf - - uses: dtolnay/rust-toolchain@6bed0761d98439e5a578e2877258200ad565ba87 # stable + # Pinned to a commit on master, with the toolchain passed explicitly: the + # action's `stable` branch is regenerated from master, which orphans any + # SHA pinned there (zizmor: impostor-commit). Master keeps its history. + - uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 with: toolchain: stable components: rustfmt, clippy