- notify-ci-failure.yml lists its workflows by name. `workflows: ['*']` is not a wildcard to
workflow_run: it matched nothing, so `main` was red from 2026-09-23 with no one told.
- cargo audit runs a prebuilt cargo-audit (taiki-e/install-action, pinned by commit) with
`--deny warnings`, replacing rustsec/audit-check@v2 - Node 20, a check-run write token, and on a
pull request a failure only for "critical", which is how September's advisories passed every PR.
.cargo/audit.toml's contract (a new informational advisory fails CI) is now what runs.
- security-scan.yml: both audits daily against `main`, so an advisory against something already
merged is reported the day it is published, not at the next PR.
- cargo deny (licences, sources, bans) with deny.toml: the licence allowlist makes "every bundled
licence is GPL-3.0-compatible" a test. The workspace declares `publish = false`, which it never
had - and without which cargo-deny judged the app crates as published ones.
- CodeQL analyses rust and actions as well as javascript-typescript. The comment saying CodeQL had
no Rust support stopped being true in 2025.
- ci-node.yml: Pages and id-token write move from the workflow to the one job that needs them
(Sonar S8233); the audit installs with --ignore-scripts (S6505); a new `tauri lockstep` job
fails when a Tauri crate and its npm package drift apart on Cargo.lock and package-lock.json.
- release.yml: build (read-only token, no persisted credentials) and publish (attest + draft) are
separate jobs; the tag must match all five version fields; SHA256SUMS.txt is LF, which
`sha256sum -c` elsewhere needs; actions/attest-build-provenance attests the .exe and .msi;
softprops/action-gh-release is pinned by commit; `workflow_dispatch` with `dry_run` builds any
ref without attesting or drafting.
- ci-integration.yml also runs for the CLI, exec, audit, release metadata, errors, store, index,
Cargo.lock and rust-toolchain.toml - every one of which its end-to-end steps run through.
- dependabot.yml: cooldowns, a group per ecosystem for Tauri packages and for actions and pip,
TypeScript held below 6.1 (typescript-eslint's peer range), and the rust-toolchain ecosystem.
A multi-ecosystem group would put both Tauri halves in one PR, but what it does to dependencies
outside its patterns is undocumented; the lockstep job covers the gap instead.
- Sonar: NOSONAR with reasons on the dev scripts' argv and PATH lookups; bundle-cli.mjs no longer
claims to run from beforeBuildCommand. The dev CSP moves out of index.html into a Vite plugin
that reads devCsp from tauri.conf.json, so a release build carries one policy, the strict one
(S7039); checked in the dev server, where React Refresh's preamble still runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three failures from the first push, all of them CI configuration rather
than code.
CodeQL and CI/Node both hit startup_failure with no logs. A caller cannot
grant a called workflow less than its jobs declare, and the run is
rejected before anything starts, so there is nothing to read.
reusable-codeql.yml's analyze job asks for `packages: read` to fetch
CodeQL packs, and reusable-web-react.yml's deploy job asks for `pages:
write` and `id-token: write`. The deploy job is skipped here
(deploy-pages: false), but permissions are validated at startup
regardless of `if:`.
This is the trap RELEASE-CI.md section 1 already records -- "callers
without a permissions block default everything to none" -- met from the
other direction: having a block is not enough if it grants less than the
callee asked for. Both comments now say so at the point of use.
cargo audit failed to compile rather than finding an advisory.
rustsec/audit-check builds cargo-audit from source, and
rust-toolchain.toml pinned that build to PipDock's 1.94.1; cargo-audit's
own dependency tree needs 1.96. The job now builds it with stable, which
is correct in principle too: the pin exists to make PipDock reproducible,
not its tooling, and cargo-audit only reads Cargo.lock.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Completes the Phase 0 scaffold. The app builds, links and renders; no
screens yet.
Frontend (ARCHITECTURE section 9, UI-SPEC section 2):
- React 19 + Vite 8 + Tailwind 4 with the UI-SPEC dark terminal-tech
tokens, plus a contrast test asserting WCAG AA over every
text/surface pair, which UI-SPEC section 8 requires be verified.
- EN and VI catalogs with a test that vi has every en key and no
orphans, standing in for the CI parity script I18N section 1 asks for.
- A local eslint rule enforcing the no-hardcoded-JSX-strings policy.
eslint-plugin-react was the obvious choice but caps at ESLint 9, which
drags in six high-severity advisories that would fail npm audit in CI;
a local rule also implements the documented allowlist (product name,
package names, versions, catalog codes, glyphs) precisely, which
react/jsx-no-literals cannot express. Verified it fires on real copy
and stays quiet on all five allowed shapes.
- no-restricted-imports keeps invoke() out of components, so the
"no component calls invoke directly" rule is enforced, not just stated.
Tauri (ARCHITECTURE section 7): commands and events only, identifier
com.skullmute.pipdock, NSIS and MSI targets, minimal capability set,
placeholder icon pending the Phase 3 branding pass.
CI (docs/RELEASE-CI.md section 1 as corrected):
- ci-rust.yml and release.yml are project-local, on Windows runners,
because no reusable Rust or Tauri workflow exists in the ops repo.
Windows matters here: env discovery reads the PEP 514 registry and the
py launcher, so a Linux run would skip the code most likely to break.
- ci-node.yml calls the ops web-react reusable and adds the npm audit
job that reusable lacks.
- codeql.yml is JS/TS only; CodeQL has no Rust analyzer.
- Discord notifiers replace the six-platform notify.yml that never
existed. Every caller carries an explicit permissions block.
- Action versions checked against the registry rather than assumed:
checkout v7, cache v6, gh-release v3, setup-node v6.
Two toolchain holds, both forced and both recorded:
- TypeScript 6.0.3, not 7: typescript-eslint peers on <6.1.0.
- ESLint 10 with eslint-plugin-react dropped, as above.
Verified: cargo fmt/clippy -D warnings/28 tests green, tsc clean,
18 vitest tests green, eslint clean, npm audit reports 0
vulnerabilities, vite build and both binaries link.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>