The five places the version lives, moved together: Cargo.toml, Cargo.lock,
package.json, package-lock.json and tauri.conf.json. `cargo metadata
--locked` agrees.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repository now lives in the poli0981org organization, and this makes it at home there.
- main was red since 2026-11-18: RUSTSEC-2026-0543 (chrono), in Cargo.lock only through serde_with's weak features and compiled into nothing; ignored with its reason and exit condition.
- Supersedes #113–#118 (Rust 1.100.0, rusqlite 0.42.0, Tauri 2.12.6, code-health pins, actions, npm) plus jsdom 31.0.1; minimatch 11 closes GHSA-g3hv-75wg-m249. rfd 0.18 (#112) is held again until tauri-plugin-dialog moves.
- Dependabot's tauri groups never worked (it picks the most specific group); exclude-patterns on the catch-alls fix it.
- CI is self-contained: no workflow calls poli0981/.github; every action is pinned by commit; notify.yml vendors the Discord notifier.
- npm licences: scripts/check-licenses.mjs, deny.toml's allowlist for the npm half. Required, with cargo deny and tauri lockstep — eight required checks.
- Qodana in two parts (Rust, TS/JS), full scans, a triaged Rust baseline, fail on anything new. The Rust container needed its toolchain and CARGO_HOME pointed somewhere writable before it analysed anything.
- SonarQube Cloud analyses into poli0981org_pipdock; every npm ci runs with --ignore-scripts (S6505).
- Every repository URL points at the organization. README's attestation command for 1.4.0/1.5.0 had stopped working; it now says --owner poli0981 --signer-repo poli0981/pipdock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The five places the version lives, moved together: Cargo.toml, Cargo.lock,
package.json, package-lock.json and tauri.conf.json. `cargo metadata --locked`
agrees.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The version in all five places it lives — Cargo.toml, Cargo.lock, package.json,
package-lock.json and tauri.conf.json — checked with `cargo metadata --locked` and with the
release workflow's own tag check run locally against v1.4.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notify-ci-failure.yml lists its workflows by name. `workflows: ['*']` is not a wildcard to
workflow_run: it matched nothing, so `main` was red from 2026-09-23 with no one told.
- cargo audit runs a prebuilt cargo-audit (taiki-e/install-action, pinned by commit) with
`--deny warnings`, replacing rustsec/audit-check@v2 - Node 20, a check-run write token, and on a
pull request a failure only for "critical", which is how September's advisories passed every PR.
.cargo/audit.toml's contract (a new informational advisory fails CI) is now what runs.
- security-scan.yml: both audits daily against `main`, so an advisory against something already
merged is reported the day it is published, not at the next PR.
- cargo deny (licences, sources, bans) with deny.toml: the licence allowlist makes "every bundled
licence is GPL-3.0-compatible" a test. The workspace declares `publish = false`, which it never
had - and without which cargo-deny judged the app crates as published ones.
- CodeQL analyses rust and actions as well as javascript-typescript. The comment saying CodeQL had
no Rust support stopped being true in 2025.
- ci-node.yml: Pages and id-token write move from the workflow to the one job that needs them
(Sonar S8233); the audit installs with --ignore-scripts (S6505); a new `tauri lockstep` job
fails when a Tauri crate and its npm package drift apart on Cargo.lock and package-lock.json.
- release.yml: build (read-only token, no persisted credentials) and publish (attest + draft) are
separate jobs; the tag must match all five version fields; SHA256SUMS.txt is LF, which
`sha256sum -c` elsewhere needs; actions/attest-build-provenance attests the .exe and .msi;
softprops/action-gh-release is pinned by commit; `workflow_dispatch` with `dry_run` builds any
ref without attesting or drafting.
- ci-integration.yml also runs for the CLI, exec, audit, release metadata, errors, store, index,
Cargo.lock and rust-toolchain.toml - every one of which its end-to-end steps run through.
- dependabot.yml: cooldowns, a group per ecosystem for Tauri packages and for actions and pip,
TypeScript held below 6.1 (typescript-eslint's peer range), and the rust-toolchain ecosystem.
A multi-ecosystem group would put both Tauri halves in one PR, but what it does to dependencies
outside its patterns is undocumented; the lockstep job covers the gap instead.
- Sonar: NOSONAR with reasons on the dev scripts' argv and PATH lookups; bundle-cli.mjs no longer
claims to run from beforeBuildCommand. The dev CSP moves out of index.html into a Vite plugin
that reads devCsp from tauri.conf.json, so a release build carries one policy, the strict one
(S7039); checked in the dev server, where React Refresh's preamble still runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Five stable releases behind (1.94.1, 2026-03-25). Two reasons to move now rather than on the next
Dependabot nudge:
- The rustls fix for RUSTSEC-2026-0285 (>= 0.23.45) does not resolve under `rust-version = "1.94"`:
resolver 3 is MSRV-aware and stops at 0.23.43, so `main`'s red `cargo audit` cannot be fixed on
the old pin at all.
- `cfg_select!` is stable since 1.95, which is the condition ARCHITECTURE §10 set for lifting the
rusqlite 0.37 hold.
`rust-version` moves with the pin, so the workspace never claims a floor it is not built with.
Clippy 1.99 adds `chunks_exact_to_as_chunks`; the build script's SHA-256 now uses `as_chunks`, which
also removes two `try_into().unwrap_or` fallbacks that could never fire.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UI-SPEC §4 gains the screen and **loses the sentence it contradicted**.
It said the third row action folds all three into a `⋮` menu "with the
budget intact"; that makes uninstall four clicks where §5's table
records three, hand-counted. The correction is written as a correction
rather than an overwrite, because the reason it slipped through is the
useful part: four is under the ceiling of five, and a ceiling is not a
ratchet — a table of measured counts is. §5 gains the row, §6 the
component, ARCHITECTURE §4 the forward direction and the whole-graph
value.
**The dangling cross-reference is repaired by writing what it promised.**
`ROADMAP.md` has pointed at "the analysis above" for what blocks P1-6
and P1-7 since 1.2.0, and no such analysis was anywhere in the document
— the survey lived only outside the repository, and the sentence had
been copied into CLAUDE.md as well. P1-6's half is its slice record.
P1-7's is now written too, and counted against the tree rather than
recalled: no toast component, no notification/autostart/tray dependency,
one plan-scoped `tokio::spawn` and zero intervals in either head, and no
surface that can report a failure at 03:00 while `logs_tail` is still
`NOT_YET`. Drafting this commit I nearly shipped a CLAUDE.md line
claiming that survey existed before I had written it, which is the same
defect one layer up.
Version in five places, moved together: the workspace inherits it, so
`Cargo.toml`, `package.json` and `tauri.conf.json` are the only hand
edits and the two lockfiles are regenerated. Hand-editing `Cargo.lock`
would have been wrong twice over — `scopeguard` and `simd_cesu8` are
also at 1.2.0 and `fs_extra` was already at 1.3.0. `cargo metadata
--locked` passes, which is the one-command check.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Version in all five places — `Cargo.toml`, `Cargo.lock`, `package.json`,
`package-lock.json`, `tauri.conf.json` — and `cargo metadata --locked` verified after,
which is the one-command check that would have caught the `thiserror` lockfile
breakage that had `main` red for a day in Phase 4.
The ROADMAP stage record, and three rules in CLAUDE.md that the diff does not show:
- **A spec can promise a field that has never existed.** SECURITY §6 and PRD P1-1 both
asked for a severity pip-audit publishes under neither vulnerability service, and §6
named a venv the code had refused since P2. Found by running the tool and reading its
JSON, not by reading the specs against each other. When a spec describes an external
tool, the tool is the authority.
- **A watchdog is a unit, not a number.** Borrowing Code Health's 120 s gave an audit a
linter's budget for a network fetch, and it fired on the first real run. A borrowed
constant carries its original units with it.
- **Adding a field to a struct that is summed is a bug the suite will not see.**
`total_bytes` kept adding three entries after a fourth arrived, with every cache test
green.
Post-1.0 is down to two items: the dependency-graph view and the scheduled check.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Five places again — Cargo.toml, Cargo.lock, package.json, package-lock.json,
tauri.conf.json — and `cargo metadata --locked` earned its place in the checklist by
failing on the first attempt, exactly the way `main` was broken this morning. The
shipped CLI reports `pipdock 1.1.0`.
The stage record covers all four slices and the four things running them said that
reading could not: 94 suggestions on a real environment, a parser that turns prose
into a package name, a cache manager for a logs directory that does not exist, and a
palette that ranked an action above the screen it belongs to.
**One PRD row corrected rather than ticked.** P1-4 asked for the engine caches
(`pip cache`, `uv cache`) as well as PipDock's own. Those belong to the engine, live
outside `%LOCALAPPDATA%\PipDock\`, and purging them is a subprocess rather than a
file delete — a different feature wearing the same word. The row says "partly
shipped" and names what is missing, and the roadmap's open list carries it.
UI-SPEC §1's "signature moves" sentence stops saying the palette is P1; §8 gains
Ctrl+K; §4 gains the Disk usage section and why it lists three artefacts.
Two rules into CLAUDE.md, both paid for this afternoon: a parser correct for trusted
input is a hole for untrusted input, and check a thing exists before shipping a size
and a Clear button for it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Five places, and they have to move together — a stale lockfile is exactly how `main`
has been red since 3eeda05. `cargo metadata --locked` is the check that they did, and
it passes.
The 58 CLI goldens do not churn: `golden.rs` filters any x.y.z to [VERSION], which is
why that filter was added.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`uv::parse_dry_run` had no callers and a `todo!("SP-1: pin uv's text plan format against
captured fixtures before parsing it")` body. The spike it was waiting for happened: the uv
adapter parses `--dry-run` output through `engine::parse`, against captured fixtures, and has
since M1. What was left was a function that would panic if anything ever called it, kept
alive by a comment about work that was already done.
With it gone `clippy::todo` goes from `allow` to `warn`, which its own comment has asked for
since the scaffold ("flip to warn once M1 lands"). Zero `todo!()` in the workspace, and the
next one has to be argued for rather than inherited — a `todo!()` is a panic with a promise
attached, and the promise is the part that expires.
Both were named in P2's stage record as clean follow-ups deliberately kept out of a feature
diff. This is that diff.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ARCHITECTURE section 9 says the frontend types are "generated with
specta/tauri-specta to prevent drift". This generates them from schemars instead,
and the deviation is recorded in the module doc rather than left to be discovered.
Why not specta: it is still 2.0.0-rc, and a project that holds rusqlite at 0.37
because 0.38 needs nightly, and refuses eslint-plugin-react over a transitive
advisory chain, cannot coherently take a pre-1.0 dependency into the crate that IS
the product. It would also mean a second derive stack beside the working one --
specta::Type on ~40 types plus hand-written impls for the newtypes. Meanwhile
schemars is already a dependency, the types already derive JsonSchema, and
`pipdock schema <T>` is already a documented public contract (CLI-SPEC section 6),
so this is additive.
What is given up: tauri-specta makes drift a compile error and this makes it a test
failure. One notch weaker at roughly a tenth of the cost, and the generated file
and wrapper layer are identical either way, so adopting specta later is a generator
swap rather than a redesign.
The staleness check lives in `cargo test`, not a bespoke CI step, so it fires
locally too. Its failure names the fixing command and reports the first differing
line -- assert_eq! over 400 lines of generated TypeScript buries the one thing the
reader needs.
Two things the emitter had to get right, both found by looking at the output rather
than by reasoning about it:
- An externally-tagged variant's payload arrives as an inline object with
`properties`, which the first draft rendered as `Record<string, never>`.
`Strategy` and `Trigger` both silently lost their contents -- generated code
that typechecks and is wrong, which is worse than none. `Strategy` now reads
`'compatible' | { 'force-latest': { overrides: PkgName[] } }`, and the kebab-case
tag is quoted because unquoted it parses as a subtraction.
- A union inside an array needs parentheses: `(string | null)[]`, not
`string | null[]`.
One limitation, asserted rather than papered over: schemars marks every `Option<T>`
as not-required regardless of serde attributes, so the schema cannot distinguish
`skip_serializing_if` ("key absent") from `serde(default)` ("key present holding
null"). Both emit `?: T | null`, which is a superset of what the wire can carry and
forces the UI to handle either. Narrowing one would assert something the schema
does not say.
Codegen lives in a new `xtask` crate rather than behind a `pipdock` flag:
regenerating TypeScript is a contributor's job, not a user's, and CLI-SPEC section 3
is a contract about what users can run.
206 tests, fmt and clippy clean; npm typecheck, lint and test green over the
generated file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Completes the Phase 0 scaffold. The app builds, links and renders; no
screens yet.
Frontend (ARCHITECTURE section 9, UI-SPEC section 2):
- React 19 + Vite 8 + Tailwind 4 with the UI-SPEC dark terminal-tech
tokens, plus a contrast test asserting WCAG AA over every
text/surface pair, which UI-SPEC section 8 requires be verified.
- EN and VI catalogs with a test that vi has every en key and no
orphans, standing in for the CI parity script I18N section 1 asks for.
- A local eslint rule enforcing the no-hardcoded-JSX-strings policy.
eslint-plugin-react was the obvious choice but caps at ESLint 9, which
drags in six high-severity advisories that would fail npm audit in CI;
a local rule also implements the documented allowlist (product name,
package names, versions, catalog codes, glyphs) precisely, which
react/jsx-no-literals cannot express. Verified it fires on real copy
and stays quiet on all five allowed shapes.
- no-restricted-imports keeps invoke() out of components, so the
"no component calls invoke directly" rule is enforced, not just stated.
Tauri (ARCHITECTURE section 7): commands and events only, identifier
com.skullmute.pipdock, NSIS and MSI targets, minimal capability set,
placeholder icon pending the Phase 3 branding pass.
CI (docs/RELEASE-CI.md section 1 as corrected):
- ci-rust.yml and release.yml are project-local, on Windows runners,
because no reusable Rust or Tauri workflow exists in the ops repo.
Windows matters here: env discovery reads the PEP 514 registry and the
py launcher, so a Linux run would skip the code most likely to break.
- ci-node.yml calls the ops web-react reusable and adds the npm audit
job that reusable lacks.
- codeql.yml is JS/TS only; CodeQL has no Rust analyzer.
- Discord notifiers replace the six-platform notify.yml that never
existed. Every caller carries an explicit permissions block.
- Action versions checked against the registry rather than assumed:
checkout v7, cache v6, gh-release v3, setup-node v6.
Two toolchain holds, both forced and both recorded:
- TypeScript 6.0.3, not 7: typescript-eslint peers on <6.1.0.
- ESLint 10 with eslint-plugin-react dropped, as above.
Verified: cargo fmt/clippy -D warnings/28 tests green, tsc clean,
18 vitest tests green, eslint clean, npm audit reports 0
vulnerabilities, vite build and both binaries link.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Phase 0 scaffold per ARCHITECTURE section 2. Everything compiles; nothing
resolves or mutates yet.
Implemented rather than stubbed, because the spikes need them and they are
the parts the invariants rest on:
- errors/catalog.rs: all 30 launch codes with their wire forms, plus tests
that the wire codes are unique and match the PD-<AREA>-<NNN> grammar.
Code::ALL drives the future "no code without fixture" gate.
- model.rs: PkgName::parse does PEP 508 validation and PEP 503
normalization. This is the only way a name reaches an argv array, which
makes SECURITY section 2 structural rather than aspirational; the test
table rejects flags, separators and quoting attempts.
- probe.py: stdlib-only, Python 3.10 floor, per ARCHITECTURE section 4.
- The pip/uv argv builders, with tests asserting one token per argument.
- ExecutionSummary::tally, so the "13 successful, 2 failed" headline is
derived from the rows rather than accumulated alongside them.
Stubbed with todo!() and a pointer to the milestone that fills them: the
Engine trait impls, discovery, index, graph, snapshot, pins, health.
UvEngine::parse_dry_run stays unimplemented on purpose — SP-1 must pin
uv's text plan format before anything parses it.
Two findings recorded in spikes/README.md:
- probe.py under -I hides user-site packages: 352 dists vs 376 without it
and 375 from pip list, on a non-venv system Python. Venvs are unaffected.
The fix trades a documented security control against list accuracy, so
it is left as an open SP-6 decision rather than settled here.
- Python 3.14 deprecates subscripting absent metadata headers, which wrote
DeprecationWarning to stderr on most distributions. probe.py now uses
.get(); the probe must stay stderr-clean because noise reads as
PD-ENV-003.
rusqlite is held at 0.37: 0.40 pulls libsqlite3-sys 0.38.1, whose build
script needs the unstable cfg_select! and will not build on stable 1.94.1.
Recorded in the ARCHITECTURE version manifest.
cargo fmt, clippy -D warnings and 23 tests are green.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>