PRD P0-1, UI-SPEC §4, CLI-SPEC (env add/remove, their JSON, --env's new
refusal), CLI-GUIDE, ERROR-CATALOG (PD-ENV-001's new cases, and the
first button its advice ever had) and TESTING's golden count. SECURITY
§2 claimed for two milestones that interpreter paths were canonicalized
before use while the only check was existence; it now describes the
validator that makes it true. PRD also records P0-9's first-run uv
detection, P1-7 and P2 as not planned in maintenance mode.
legal/PRIVACY-POLICY.md 1.3 names the interpreter paths a person adds,
kept until removed, in both languages. With the repository URL it
already changed, the first-run gate shows once in 1.6.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automatic analysis could not build, so it never analysed the Rust two
thirds of the code and imported no coverage; it also sent no project
version, leaving the previous-version new-code period anchored to the
first analysis. sonar.yml runs on Windows, produces cargo-llvm-cov and
vitest LCOV plus clippy's JSON, and scans with sonarqube-scan-action
v8.3.0 (pinned), passing the version from package.json. The token
reaches the scan step alone; the job is skipped without one (Dependabot,
forks) and refuses a dispatch off main, which this plan cannot analyse.
Unblocks the required audits, red on main since 2026-10-21:
rustls-webpki 0.103.16, webpki-root-certs 1.0.11, clipboard-win 5.4.3,
zod 4.6.7. Dependabot groups vitest with @vitest/*.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dead code, each checked for callers first:
- graph::ReverseDeps::leaves (only its own test called it), health::run::sink_for (no caller,
and a doc describing something else), SnapshotProof::id and is_waived (no caller).
- Two whitespace collapsers become one, errors::catalog::collapse_whitespace; the classifier's
normalize is that plus lowercase. Three hand-folded SHA-256 hex digests become
model::sha256_hex (build.rs keeps its own: a build script cannot use the crate it builds).
- Six copies of asPdError become one, beside isPdError in ipc/errors.ts.
- Thirteen strings no screen renders, from both catalogs (status.resolving/executing/ready,
actions.confirm/browse/retry/openLogs, env.requiresPython/unusable,
packages.updateSelectedSoon, health.notInstalled, settings.localeSystem/saved).
- fixtures.rs is compiled only for tests and for xtask (feature `fixtures`), not into release.
Half-wired, finished rather than deleted: engine_info had a typed wrapper and no caller, while
ARCHITECTURE §7 promised a version beside each engine radio. Settings now shows it for the
selected environment, and says "not found" for an engine that is not installed.
Docs that described another project: core's "Phase 0" status, model.rs's specta, pip.rs's "lands
in M1", snapshot.rs's "execute takes a Snapshot" (it takes a SnapshotProof), declared_source's
doc stranded on validate_project, the pin validators' "character-class check" (they share
pep440::is_version now), three health wrappers in ipc/index.ts each under another's doc, and
three %LOCALAPPDATA% paths missing the data\ folder.
Repo: production builds carry no source maps - Tauri embeds dist/ in the executable, so
`sourcemap: true` shipped 2 MB of them to every user (X51). .gitignore covers insta's pending
snapshots and a downloaded SHA256SUMS.txt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first bundle ever built for this project contained exactly one binary. NSIS payload:
`pipdock-app.exe`. MSI `app.cab`: one file. **`pipdock.exe` was not installed at all** — while
PRD P0-12 is "CLI core parity", CLI-SPEC documents the entire surface, `golden.rs` pins 58
snapshots of its output, and the README's own Quick start opens with `pipdock env list`. A
user who installed PipDock had none of it.
Found by listing the installer. `tauri.conf.json` declared no `externalBin` and no
`resources`, so there was nothing to notice in a diff — the config was correct for a
GUI-only app, and nobody had built one to see what came out.
`scripts/bundle-cli.mjs` builds the CLI and stages it as a sidecar under the host triple,
which Tauri strips at bundle time, so it installs as plain `pipdock.exe` beside the GUI. The
triple is asked of `rustc -vV` rather than assumed, since a guess breaks the moment anyone
cross-compiles.
It runs from `beforeBuildCommand`, not only from the release workflow. A locally built
installer and a released one have to be the same artifact; a bundle that differs by who
built it is how "works on my machine" reaches a release. This build proves the clean-checkout
case too — `src-tauri/binaries/` is gitignored and did not exist when the build started.
**`PATH` is deliberately left alone** (owner decision, 2026-08-13). PipDock does not modify
the user's environment, which is the restraint SECURITY §5 already applies to not shipping a
self-updater; the README says where the binary lands and gives the one-liner to add it if
that is what you want.
Verified by rebuilding and listing both installers: NSIS 5.7 → 8.8 MB carrying
`pipdock-app.exe` and `pipdock.exe`; MSI 7.6 → 11.6 MB carrying `Path` and `Bin_pipdock.exe`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`errors.logPrivacy` rendered as its own key in the error row — spotted by making a
pip-upgrade fail in the running app and reading what came back.
`common.json` and `errors.json` both have a top-level `errors` object: the catalog codes in
one, the row's own furniture in the other. `{ ...common, ...errors }` is a shallow spread,
so the second replaced the first outright and five strings vanished in both languages —
`title`, `retry`, `unknown`, `logPrivacy`, `logCopied`.
`errors.unknown` is the one that matters. PdErrorRow falls back to it deliberately rather
than leaking PdError.message, which is English developer text — so the single thing
standing between a user and an untranslated internal string was itself rendering as the
literal `errors.unknown`.
Neither existing test could see it. The catalog test only asks about Code::ALL, and the
parity test compares en against vi — which agreed perfectly, because both locales lost
exactly the same keys. The new test compares the merge against its own inputs, which is the
only comparison that catches a merge discarding one of them; checked by reverting the fix
and watching it name all five.
The i18n.ts comment already claimed the keys "land exactly where common.json used to hold
them". They did not.
Also gitignores `.claude/`, which holds worktrees and a local launch config.
Found while verifying P1 and fixed here rather than filed: it is five lines, and one of
them is an error path that S7 built specifically so this could not happen.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
P0-10 wants pip's version on every Environments row. The obvious source is engine_info —
and it is the wrong one: it spawns two subprocesses per call, pip's --version and uv's, so
per row that is 2N spawns added to the landing screen on top of the N probe.py runs already
happening there.
The data was already computed and thrown away. pip is an ordinary distribution in
site-packages, `probe_row` holds `probed.dists`, and `packages` is that same list's length.
Reading one more field off it costs nothing and needs no probe.py change, so CLAUDE.md's
hot-path warning does not apply.
env_probe carries it too, and that is load-bearing rather than tidy: refreshing one row
after an upgrade is exactly what that command is for in the next commit, and a refresh
through a path that omitted the field would blank the thing it was refreshing to update.
The compiler caught it, which is the argument for the field not being Option-defaulted.
`pipdock env list --json` grows the same field off the same list, so the two heads cannot
disagree about which pip is installed.
Absent means the probe found no pip — a --without-pip venv, or -I hiding a user-site
install — which is a real state, not "not yet known".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`pipdock pip-upgrade --engine uv` failed at PD-ENG-001 — while the line immediately below
had already reached past the abstraction to call PipEngine.info directly for the version.
Upgrading pip is a pip operation by definition. There is no uv way to do it, which is why
UvEngine::upgrade_pip exists only to refuse, and the engine setting is a preference about
the *user's* environments. Dispatching on it meant the one command with no resolver
between the user and the result was also the one that could be blocked by an unrelated
choice. Same reasoning P2 applied to the tools venv: pip is present wherever Python is.
Both heads now call PipEngine::upgrade_pip directly. The uv refusal stays rather than
becoming an unreachable!() — the trait is public and for_id can still hand a caller that
adapter, where a catalog code beats a panic.
That refusal was also the only thing standing in front of this path, so PipEngine now
carries its own PEP 668 guard, copied verbatim from UninstallFlow::start rather than
reworded so the three cannot drift. DATA-FLOW §2's preamble is "all mutating flows" and
replacing pip in site-packages is one; UpdateFlow has refused since S1 and UninstallFlow
since S5, and this had no guard at all. It stayed harmless only while nothing but a CLI
command could reach it — the next commit gives it a button.
Verified by running: `pip-upgrade --engine uv` on a 3.12 venv reports pip 25.0.1 -> 26.2.1
and exits 0, and a second run is idempotent.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
health/ was not in the integration job's paths filter, so nothing about the tools venv
would have run on a PR that changed it. tools/ is there too: a Dependabot pin bump has to
re-run the bootstrap, because whether the new pin set still resolves to wheels on both ends
of the supported range is exactly what this job can answer and a unit test cannot.
Four assertions, each one a bug this slice actually had or nearly had: a just-synced venv
reports fresh with all three tools and no pip-audit; a second sync short-circuits in under
10 s; a quarantined ruff.exe reports toolMissing and is repaired by a re-sync; and an
unreachable index gives PD-NET-011, exit 6, and leaves no manifest claiming the venv is
good.
LOCALAPPDATA is overridden to redirect the whole app-data root, so the job never touches a
runner's profile and PipDock needs no test-only configuration knob. Verified locally rather
than assumed, along with the whole script — which is how the `exit 0` at the end was found:
the runner appends `exit $LASTEXITCODE` to every pwsh step and the last command
deliberately exits 6, so without it the step failed with every assertion passing.
.gitignore gains the three scratch directories this job builds in the workspace. Only the
new one is P2's, but ignoring one of three would be odder than ignoring none.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
18 fixtures (9 scenarios x 2 engines) plus a reproducible capture harness.
Findings written up in spikes/README.md and summarised in the ROADMAP
Phase 0 table. Verdict: GO for shipping both engines, but for a different
reason than the roadmap anticipated.
SP-1 asked whether uv's plan output is too lossy to ship uv in v1.0. The
question turned out to be the wrong shape. Neither engine holds packages
back on `install -U <pkg>` — seeded with httpx 0.23.0, which requires
httpcore<0.16, both pip and uv plan httpcore 1.0.9 and exit 0, silently
breaking it. Restating the installed set as explicit requirements is what
produces the correct held-back plan. That makes it a hard requirement on
both adapters, not an optimisation: without it PipDock would preview a
plan that breaks the environment. uv also writes its entire plan to
stderr, and its conflict attribution is markedly better than pip's — uv
names the exact blocking constraint where pip says only that versions
conflict.
SP-2 found a blocker. `pip install --dry-run --report -` crashes with
UnicodeEncodeError on Windows under cp1252, because pip routes the report
JSON through vendored rich and the console codec. Confirmed on pip 25.0.1
and 26.1.2, so it is current, not legacy. It is data-dependent — an
all-ASCII report succeeds — which means it would pass local testing and
fail on users' machines. PYTHONIOENCODING=utf-8 plus PYTHONUTF8=1 fixes
it, and the crash is kept as a fixture so a regression is recognisable.
Also: yanked releases exit 0 in both engines, so PD-PKG-003 belongs in
the preview as a warning rather than in the failure path the catalog
implies; and the two engines disagree on Requires-Python enforcement.
SP-3 passes: 858k projects, 2.95s cold refresh against a 60s budget,
42.1ms worst keystroke against 50ms. But only in memory — scanning
SQLite per keystroke costs 218ms, four times over. Two cautions recorded:
16% headroom on fast hardware is thin for the low-end VM the spike asked
about, and raw nucleo ranking puts requests-ntlm above requests, so the
Search screen needs an exact/prefix boost to be usable.
SP-4 confirms SECURITY section 6 as written: --path cannot combine with
--no-deps, so freeze-file mode is the only option for a foreign env.
SP-5 is answered by SP-1 — no engine reports held-back items at all, so
resolved version, latest version and blocker must all be derived by
PipDock, for pip as much as for uv.
SP-6 avoided two identity bugs. `uv python list` returns downloadable
entries and shims that duplicate real interpreters, and the same
interpreter reports different path casing depending on how it was
launched, so env_hash must lowercase on Windows or a single environment
silently splits its pins and snapshot history in two. Microsoft Store
Python is not installed here and remains unverified.
Four decisions are queued for the owner at the end of spikes/README.md;
two of them change adapter behaviour and should land before M1.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Commits the full v0.1 design suite written during the design phase:
PRD, architecture, data flow, UI/CLI specs, code-health spec, error
catalog, security, testing, release/CI and i18n docs, plus the roadmap.
The legal documents (EULA, disclaimer, privacy policy, third-party
notices) must be committed publicly because the in-app legal gate links
to their GitHub URLs at first run.
Also adds .gitignore, which the repo was missing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>