From 7ee00893a7c9f7d70963ad4f86a295b33efb3965 Mon Sep 17 00:00:00 2001 From: poli0981 <127664709+poli0981@users.noreply.github.com> Date: Tue, 10 Nov 2026 19:38:23 +0700 Subject: [PATCH] fix(a11y): four defects from an independent review of the diff - Visually-hidden text is position: absolute, and with no positioned ancestor it is laid out against the viewport, outside every scroller above it. A pin chip's hidden sentence did that on Pins: a long list made the whole window scroll and took the header with it. Every parent of hidden text is relative. - A run that failed before producing a summary rendered no

, so the focus rule had nothing to land on. The branch has a heading. - The console drawer stays open across runs, so the next run mounts it with no opener to return focus to. It falls back to the Console button. - Under forced-colors the selection outline followed the focus ring at equal specificity and replaced it on a focused current tab. Co-Authored-By: Claude Fable 5.2 --- CLAUDE.md | 3 +++ docs/ROADMAP.md | 16 ++++++++++++ ui/src/components/PdBadge.tsx | 5 +++- ui/src/components/PdConsoleDrawer.test.tsx | 29 ++++++++++++++++++++++ ui/src/components/PdConsoleDrawer.tsx | 9 ++++++- ui/src/components/PdHealthReport.tsx | 2 +- ui/src/components/PdPackageTable.test.tsx | 10 +++++--- ui/src/components/PdPackageTable.tsx | 4 +-- ui/src/screens/PdPlanPanel.test.tsx | 21 ++++++++++++++++ ui/src/screens/PdPlanPanel.tsx | 6 +++++ ui/src/screens/PdSearch.tsx | 2 +- ui/src/styles.css | 9 ++++--- 12 files changed, 104 insertions(+), 12 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index b9c36f0..74c8667 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -198,6 +198,9 @@ driving the installed build: - **An accessible name is assembled without spaces.** Inline spans join as `Updates(5)`; put a literal `{' '}`. A browser *adds* one before visually-hidden text, so `: numpy` in an `sr-only` span read "Remove packages : numpy" — use `aria-label` for a name with punctuation in it. +- **`sr-only` text needs a positioned parent.** It is `position: absolute`, so with no positioned + ancestor it is laid out against the viewport, outside every scroller: a list of pin chips on + Pins made the whole window scroll. Put `relative` on whatever holds the hidden text. - **`ACCESSIBILITY.md` is hand-kept and says who tested what.** A change to keyboard, focus, names or contrast is a change to it, the way a behaviour change is a change to `legal/`. It currently says Narrator was not re-run on 1.5.0, and only a person can change that sentence. diff --git a/docs/ROADMAP.md b/docs/ROADMAP.md index 972248a..955bd47 100644 --- a/docs/ROADMAP.md +++ b/docs/ROADMAP.md @@ -1588,6 +1588,22 @@ was clipped, and it was — on three sides, in normal mode, fixed here. The forc carried that exact fix since M2, with a comment saying why: the knowledge was in the stylesheet, scoped to the one mode someone had looked at. +**And what a second reader found**, in the diff, after the smoke had passed — an independent review +run while CI was going: + +- **`sr-only` text needs a positioned parent.** It is `position: absolute`; with no positioned + ancestor it is laid out against the viewport and escapes every scroller above it. A pin chip's + new hidden sentence did exactly that on Pins, where nothing between the chip and `` is + positioned: a long list made the whole window scroll and took the header with it. Package rows + hid it, because a row is `absolute`. Every parent of hidden text is `relative` now. +- **An error-only summary had no `

`**, so the new focus rule had nothing to land on — on the + one screen where a run had just failed. +- **A drawer that mounts already open has no opener.** `consoleOpen` outlives a run; closing the + drawer in the next one dropped focus as it had before the fix. It falls back to the *Console* + button. +- Under forced-colors, the selection outline followed the focus ring at equal specificity, so a + focused current tab got a 1 px line in place of its 2 px ring. + **What it did not establish.** The assistant cannot run a screen reader. Everything above about what assistive technology receives is the accessibility tree, which is what is *exposed*, not what is *said*. Narrator on 1.5.0, NVDA, JAWS and each contrast theme by hand are backlog A7 and are diff --git a/ui/src/components/PdBadge.tsx b/ui/src/components/PdBadge.tsx index 169ff01..65e914d 100644 --- a/ui/src/components/PdBadge.tsx +++ b/ui/src/components/PdBadge.tsx @@ -39,7 +39,10 @@ export function PdBadge({ tone, label, glyph, title }: PdBadgeProps) { const explained = title !== undefined && title !== label return (