From 73a67a62435f489df03f87f2f13945da7a4f6de5 Mon Sep 17 00:00:00 2001 From: poli0981 <127664709+poli0981@users.noreply.github.com> Date: Thu, 13 Aug 2026 19:35:47 +0700 Subject: [PATCH] feat(ui): reach the row's actions with a keyboard, and stop saying things twice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit UI-SPEC §8's remaining keyboard work, and it turned out to be hiding a WCAG 2.1.1 failure. **Pin and uninstall were unreachable without a mouse.** Every control in a package row is `tabIndex={-1}` so that 200 rows do not become 600 tab stops — a sound trade for the checkbox, whose job `Space` already does from the row. Applied to the two action buttons it removed the actions entirely: the row was the only tab stop, and from it there was nowhere further to go. Found by tabbing to a row in the running app and pressing every key that should have done something. The ARIA grid pattern's answer is a roving tabindex, so that is what this is: `ArrowRight` and `ArrowLeft` walk the row's controls, `Escape` comes back out to the row, and no tab stops are added. Verified in the browser — the focus walk is checkbox → *Pin this package* → *Remove this package* → row. **`Enter` is the row's primary action, and it is pin rather than uninstall.** A row has one reversible annotation and one irreversible removal; a destructive operation one keypress away from a focused row is not a primary action, it is an accident waiting. `Space` still toggles selection independently — checked, because a new binding on the same element is exactly how an old one stops working. Note what the audit actually found: `Enter` already worked everywhere else in the app, because every other primary action is a real `