From 283605a4a08783b68357021481028d19901a2609 Mon Sep 17 00:00:00 2001 From: poli0981 <127664709+poli0981@users.noreply.github.com> Date: Sat, 17 Oct 2026 01:16:31 +0700 Subject: [PATCH] chore(sonar): NOSONAR on the line SonarCloud flags (#80) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SonarCloud honours a NOSONAR only on the flagged line. 1.4.0 put this one on the line above the `cargo` call, so S4036 stayed open on `main` and kept the project's security rating at B while the PR gate reported "0 new issues" — the issue was old, not new. The call now fits on one line, with the marker on it. The two in `spikes/` were already on their flagged lines and are cleared. Co-authored-by: Claude Opus 5.5 --- scripts/bundle-cli.mjs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/bundle-cli.mjs b/scripts/bundle-cli.mjs index 6c18e6d..e191a5f 100644 --- a/scripts/bundle-cli.mjs +++ b/scripts/bundle-cli.mjs @@ -38,11 +38,10 @@ const target = join('src-tauri', 'binaries') mkdirSync(target, { recursive: true }) // `--locked` for the reason the release workflow passes it: a bundle is not the place to discover -// that a dependency resolved differently than the lockfile says. -// NOSONAR: see the header — the developer's own cargo. -execFileSync('cargo', ['build', '--release', '--locked', '-p', 'pipdock-cli'], { - stdio: 'inherit', -}) +// that a dependency resolved differently than the lockfile says. The NOSONAR is on the call itself: +// SonarCloud reads one only on the flagged line, and on the line above it suppressed nothing. +const cargoArgs = ['build', '--release', '--locked', '-p', 'pipdock-cli'] +execFileSync('cargo', cargoArgs, { stdio: 'inherit' }) // NOSONAR: see the header — the developer's own cargo const from = join('target', 'release', 'pipdock.exe') const to = join(target, `pipdock-${triple}.exe`)