SonarCloud's gate wants 80% coverage on new code, and the PR's changed
lines were at 71.8%: ten of them were never run by a test. Now they are:
- appdetails' failures told apart (no answer, 404, success: false, a
body that is not JSON) and the store page's two network_error paths;
- the leaderboards' stars, for a percentage and for "N/A", "No reviews"
and a missing field (both scripts);
- mark_dead_games.parse_players() on the stored formatted strings;
- backfill_discover.parse_released() on every date shape, the year-only
one included.
pytest: 501 passed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each qodana.yaml now fails its job on any problem (failureConditions,
any: 0), as in free-games-itchio-list, and names what it leaves out and
why:
- Python: DuplicatedCode in the two discovery and two leaderboard
scripts (sharing them is a refactor); broad excepts where a failed
request is "no answer" by design (steam_client, the Access diagnosis);
PyCharm's sorted() typing in edit_game.py; the escaped bracket pair in
normalize.py's `\[hover-add\]`.
- JS/TS: ES6UnusedImports (the Svelte plugin cannot resolve
`@lucide/svelte/icons/*` and calls all 122 icon imports unused; every
tsconfig has noUnusedLocals, enforced by svelte-check and tsc), the
admin's relative imports of the public app, `}` escapes kept for
unicode-mode parsing, fetcher.ts's throw-to-own-catch fallback, and
keyCode 229 for IME composition.
- Rust: CargoUnusedDependency, which cannot see the ::serde_json paths
generate_context!() expands to.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No behaviour changes; each is what the inspection asked, or the type
information it lacked.
Python (scripts/):
- `return (a, b)` -> `return a, b` (12, steam_client, store_items,
backfill_discover).
- `log=print` parameters annotated `Callable[[str], None]`: PyCharm could
not type the overloaded builtin as a default and called every log(...)
"not callable" (10, budget, purge_unhealthy, refresh_anticheat,
refresh_peaks).
- fetch_full()'s docstring names all its parameters.
- Nested helpers no longer shadow the loop variables of the function
around them (purge_unhealthy judge(), update_reviews ask()).
- The leaderboards' bare `except:` catches what a reviews string can
raise (AttributeError, TypeError, ValueError), not SystemExit and
KeyboardInterrupt too.
- edit_game.py: unused `import json` dropped; mark_dead_games `[^\d]` ->
`\D`; the DLC section regex loses a group around the whole pattern
(only ever used with search()).
TypeScript / Svelte (web/):
- Two comma expressions written as statements (pipeline route's run
dedupe, CandidateDialog's Reopen button).
- shouldIgnore() returns its last condition instead of if/return.
- Resource's constructor-only private fields are readonly.
- The admin mock seed says HOUR, not 1 * HOUR.
Rust (web/src-tauri/): `serde` dropped - nothing in the crate or in what
generate_context!() expands uses it (only `::serde_json` paths are
generated). serde_json stays, with a comment: Qodana calls it unused
too, but the generated code needs it and the crate does not compile
without it.
Checked: pytest 467, typecheck, vitest 747, knip, cargo test --lib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What the first runs showed, and the changes:
- Python: SDKs.json was empty - native mode finds no interpreter by
itself, and without one every `dict[int, str]` and `X | None` was an
"invalid type hint" (11 of the 50 problems). The job now builds .venv
from the hashed requirements and passes QODANA_PYTHON_PATH.
- Rust: "Analysis scope: 0 packages" and a Critical "Cargo project
loading" sanity problem: the image has no C linker and none of
Tauri's libraries, and runs as the runner's user, who can neither
apt-get install nor write the image's CARGO_HOME. Now `-u root`,
CARGO_HOME in the cached Qodana cache dir, and a bootstrap that
installs the build packages.
- JS/TS: installing the Svelte plugin fails in native mode with every
released CLI up to 2026.2.3 ("qodana.build.date system property must
be set"; fixed upstream as QD-16701 on 2026-11-05, unreleased), so
this project runs in the Qodana image, on the node_modules and
generated files the job prepared.
One workflow (qodana.yml) with a job per project, as in
free-games-itchio-list: the token check covers all three, triggers skip
data and Markdown-only commits, no PR comment (annotations, Qodana
Cloud and the report artifact carry the results), --repository-root .
for the subdirectory projects, and each job keeps its own cache keys.
The qodana.yaml files use `exclude` and name their Qodana Cloud project.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three workflows, one per Qodana Cloud project and token
(QODANA_TOKEN_PYTHON, QODANA_TOKEN_TS_JS, QODANA_TOKEN_RUST), each with
the qodana.yaml of its project directory:
- qodana-python.yml: Qodana for Python over scripts/, native mode on the
runner's Python 3.15 with the hashed requirements installed.
- qodana-js.yml: Qodana for JS over web/, native mode on Node 26 after
`npm ci --ignore-scripts` and `npm run build:admin`, with the Svelte
plugin so .svelte files are read.
- qodana-rust.yml: Qodana for Rust (EAP, Docker only) over web/src-tauri/,
with a stand-in web/dist so generate_context!() expands.
Each runs on pushes to main and pull requests that touch its files, and
by hand. The scan is skipped when its token is not available (forks,
Dependabot), as sonarcloud.yml does; the action is pinned by SHA, the
job's token can read contents and write only checks and PR comments, and
each workflow has its own cache keys so the three do not collide.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved automatically by the /admin schedule (at most 500 a day), enabled by admin.
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.
Approved in /admin by admin.
Reason: pass
Queued for scripts/ingest_new.py, which decides whether each game is actually free, reachable and not already present. This commit is a request, not a publication.