10 Commits
Author SHA1 Message Date
poli0981andClaude Opus 5.5 6e7d1bcf15 chore(pipeline): retire Check Dead Links
It sent a HEAD request to every store page every five days, 5.5 hours at
9,847 games, and flagged 404/410. Steam sends a delisted app's page to
the store front, which answers 200: scripts/dead_links.log never existed
and no game ever became "delisted". The purge's GetItems screen sees
delisted games (unlisted) instead.

Removes the workflow, bash/dead_links.sh, scripts/check_dead_links.py
and DEAD_LINKS_LOG, and the workflow from web/shared/pipeline.ts and the
failure notifier's list. check_store_page() stays: it is the health
check's last resort.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 22:22:08 +07:00
poli0981andClaude Opus 5.5 df91b42c4f ci(sonar): import test coverage instead of excluding it
The scan job now runs both suites with coverage before scanning:
pytest --cov (pyproject.toml: scripts/ without its tests, relative
paths, coverage.xml) and `npm run test:coverage` (vite.config.ts: v8,
lcov with projectRoot "..", so paths start web/). sonar-project.properties
names both reports and drops sonar.coverage.exclusions.

requirements-test.txt gains pytest-cov 7.1.0 and coverage 7.16.2 with
every file's hash (uv pip compile --universal --generate-hashes
--python-version 3.15; the existing pins are unchanged). web gains
@vitest/coverage-v8 5.0.5, matching vitest; none of its packages has an
install script. Coverage stays off for a plain `npm test`.

The token check is its own job, so the scan steps no longer each repeat
the condition; the workflow grants nothing at the top and the scan job
contents: read. `npm run build:admin` replaces the bare `svelte-kit
sync`: it syncs too, and writes the admin bundle the Worker's tests load.

Locally: 576 vitest tests at 58.35% of lines, 299 pytest tests at 57.7%.
Against main's new-code lines (SonarCloud's isNew), the reports cover
92 of 114 coverable lines, 80.7%: the 80% gate is borderline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 19:34:51 +07:00
poli0981andClaude Opus 5 3f9447711d fix(repo): close .gitignore gaps that would leak credentials, untrack 3 files
You spotted .wrangler cache in the repo. It was not a one-off: the root
.gitignore had no .wrangler rule at all (only web/.gitignore did), so anything
run with wrangler from the REPO ROOT rather than web/ lands unignored. That is
how .wrangler/cache/wrangler-account.json — Cloudflare account id and account
email — reached a public repo.

Auditing outward from that found three more credential shapes with no rule,
all of which this project's own docs tell you to create:

- .dev.vars / .dev.vars.*  `wrangler dev` reads GH_APP_PRIVATE_KEY from here,
  and the PEM is INLINE, so the existing *.pem and *.key rules never see it.
  That App can commit to this repo. Highest-consequence gap of the three.
- *.jks / *.keystore / *.p12 / *.pfx  web/src-tauri/TAURI.md walks you through
  `keytool -genkeypair -keystore f2p-tracker-release.jks` using a RELATIVE path
  inside gen/android/, and reassures you keystore.properties is ignored — while
  the keystore itself was covered by nothing. Leak it and Android signing is
  compromised; lose it and the app can never be updated.
- .env.production / .env.development matched none of .env, .env.local or
  .env.*.local.

Two rules were silently hiding real source, verified with check-ignore:

- `env/` and `ENV/` are unanchored Python-virtualenv rules, so they matched
  web/worker/env/ at ANY depth — Worker source would vanish from `git add .`.
  (On this Windows checkout core.ignorecase makes ENV/ match env/ as well.)
- `[Nn]otes.md` matched docs/notes.md and docs/i18n/*/notes.md, the likeliest
  filename for real documentation in a repo whose output is markdown.
Both anchored to the repo root. `build/`, `dist/` and the one-off script rules
anchored for the same reason; web/dist stays covered by web/.gitignore.

Two rules did not do what their comments claimed:

- `*.log` matches scripts/dead_games.log, which mark-dead-games.yml explicitly
  stages and mark_dead_games.py appends to. It survives only because ignore
  rules do not apply to already-tracked files — rename or recreate it once and
  it disappears with no error. Now an explicit negation with the reason.
- `.vscode/` excludes the DIRECTORY, and git will not descend into an excluded
  directory, so the four `!.vscode/*.json` negations under it were dead code.
  Changed to `.vscode/*` so the exceptions actually apply.

Untracked (files left on disk, none referenced by any build):
- .wrangler/cache/wrangler-account.json  account id + email, the reported file
- web/src-tauri/.tauri-signing.key.pub   minisign F6E36504EAE8E3A2, which is
  NOT the updater key in tauri.conf.json (9F39774AE5453C53). A stale pre-
  rotation public key that web/src-tauri/.gitignore already forbids.
- .idea/.gitignore                       tracked despite the .idea/ rule

Verified: 21 check-ignore assertions both ways; the index delta is exactly
those three deletions (386 -> 383 files); no remaining tracked file is matched
by any ignore rule; nothing untracked is left unignored.

Also documents in docs/ADMIN.md that every new Access application needs its AUD
appended to ACCESS_AUD — omitted before, and it fails only after the
application starts working, which makes it look like an unrelated bug.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 19:03:36 +07:00
poli0981andClaude Opus 5 96b2d2d69d fix: correct two stale claims that a wildcard add swept in
The previous commit staged these with `git add -A`; both had been left
uncommitted because they were wrong, so correct them rather than carry them.

username.txt said the Telegram QR codes were untracked. They are tracked —
assets/qr/telegram-bot.png and assets/qr/telegram-user.png — and CONTRIBUTING.md
and AUTHORS.md already link to those paths.

.gitignore carried a block ignoring app/dist, app/release and friends under the
heading "F2P Tracker desktop app (Electron + Vite)". There is no app/ directory
in this repo and the desktop shell is Tauri 2 with a Rust backend, so the block
ignored nothing and described the wrong technology. Replaced with the paths
Tauri actually produces. Verified the new rules match no already-tracked file.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 16:09:04 +07:00
poli0981andClaude Opus 5 5ab4f27347 docs: split the licence, correct the legal docs, add deployment and admin guides
The docs had drifted badly from the code. This makes them true.

LICENCE SPLIT. Code stays MIT; the dataset moves to CC BY 4.0 in a new
LICENSE-DATA, which is explicit about what the project cannot license: the
`description` field is the publisher's own store blurb stored verbatim (median
213 characters), `header_image` is a URL to publisher artwork, and game names
are trademarks used nominatively. Blanket-MIT over that material was a claim
the project was never entitled to make. Facts — player counts, review
percentages, platform support — are noted as unownable; the CC BY grant covers
the compilation and the project's own derived fields.

PRIVACY POLICY, rewritten rather than patched. The previous one said "no
backend, no server-side log, no cookies, no server other than GitHub's CDN".
Every clause of that is now false: the site runs on a Cloudflare Worker that
processes IP and User-Agent and keeps operational logs. It also documents the
one honest exception — the Activity page still calls api.github.com and loads
GitHub avatars from the browser, so GitHub sees a visitor's IP there while no
other page does — and lists every localStorage, IndexedDB and Cache Storage key
with why it exists.

SECURITY.md, rewritten. The old one claimed "no executable code, no
dependencies, no backend, no user data" and said there was no contact address,
while four other files publish one. It also told people to report
vulnerabilities in public issues. There is now a real scope (the Worker, the
proxies, D1, Actions secrets, the Tauri signing key), a private channel via
GitHub's vulnerability reporting, and specific things worth probing.

EULA corrected on two counts: it asserted a single MIT licence over everything,
and claimed there is "no installable software" despite the signed desktop and
Android builds. ToS and DISCLAIMER updated for the licence split, the new
domain, and the removal of in-browser editing and GPG signing — the disclaimer
described a signing flow that no longer exists.

README contradictions fixed: 1.2k games -> 3,424 across 5 shards not 2, 11
workflows -> 24, two scripts listed that were never in the tree, a TanStack
Table dependency the project does not use, and nine links to the old Pages URL.

New: docs/DEPLOYMENT.md (how a push becomes a deploy, the two wrangler.jsonc
fields that silently break it, and the stale-service-worker trap when verifying)
and docs/ADMIN.md (Cloudflare Access plus the GitHub App, with the exact
permission set — Contents write and Metadata only, and why Actions and
Workflows are deliberately withheld).

Two live fixes came out of writing this. GitHub Pages was serving a blank page:
it had the new index.html, which references assets at `/`, while Pages serves
under /free-steam-games-list/, so every asset 404'd — and deploy-pages.yml kept
redeploying it. That workflow now publishes a redirect that preserves the #/
fragment, since Pages cannot issue a 301. And CI pinned Python at 3.11, 3.12
and 3.14 across different workflows while the docs claimed 3.12 was pinned;
all fourteen references are now 3.12, which makes the claim true.

TERMS_VERSION 1 -> 2, so everyone re-consents. A privacy policy that now
discloses edge logging where it previously promised none is not a change to
apply silently.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 16:09:04 +07:00
poli0981andClaude Opus 4.7 00d9dc0fb5 Phase 7: date-sort fix + hamburger nav + About expansion + legal rewrite + Node 24 (#54)
date-sort fix
  Steam release_date strings ("22 Aug, 2012", "Dec 19, 2025", "Coming
  Soon", "TBA", year-only "2025"…) were sorted as strings, which mixes
  alphabet-first chars ahead of numeric prefixes and scrambles years.
  New parseReleaseDate() in lib/utils.ts hands back a comparable
  timestamp via Date.parse with a 4-digit-year fallback. Unparseable /
  TBA values get -Infinity so they cluster out of the way regardless of
  sort direction. GamesTable's released column now uses it.

hamburger mobile nav
  Sidebar was hidden below the lg breakpoint with no way back. New
  ui/sheet.tsx Radix-Dialog-based drawer that slides in from the left,
  Sidebar refactored into shared SidebarBody + desktop / mobile wrappers,
  Topbar gets a Menu button (mobile-only). Drawer auto-closes on route
  change so tapping a nav entry doesn't require an extra X click.

About page expansion
  • New "Heads-up before you trust this" card with the four accuracy
    caveats from the maintainer's notes:
       - genre is best-effort (tags+description heuristic)
       - English-only assumption (regional storefronts can break parsing)
       - test data may have leaked in during development
       - "unsigned" Activity entries are dev artefacts, not malicious
  • New "AI disclosure" card naming Grok (v1) + Claude (v2+) and noting
    that LLM calls only happen on the maintainer's dev machine, never
    from the visitor's browser at runtime.
  • New "Legal & license" card linking MIT + DISCLAIMER + ToS + EULA +
    PRIVACY + ACKNOWLEDGEMENTs + Contact, all opening on GitHub.
  • Per-third-party SPDX licence badges in the stack list, each linking
    to the dep's actual LICENSE file.
  • Added echarts-wordcloud + idb-keyval to the deps roster.

Legal docs rewrite (DISCLAIMER, EULA, ToS, PRIVACY)
  Tightened wording while keeping the casual voice. Each doc now
  explicitly references the four accuracy caveats, the third-party
  trademark situation (Steam, Akamai, GitHub), and the AI-assistance
  status. PRIVACY_POLICY enumerates exactly what the static site does
  and does not do (no analytics, no fingerprinting, lists the four
  third-party endpoints touched at runtime + their privacy links).
  EULA + ToS now name-check Steam Subscriber Agreement / Akamai
  appropriately rather than just shrugging.

Node 24 / refreshed actions
  Phase 5+ deploy-pages was running on Node 20 (which deprecates June
  2026). Bumped:
    actions/checkout         v4 → v5
    actions/setup-node       v4 → v5  (node-version 20 → 24)
    actions/upload-pages-artifact  v3 → v4
    actions/deploy-pages     v4 → v5

notes.txt
  The maintainer's local working notes that they explicitly didn't want
  pushed. Added [Nn]otes.txt / [Nn]otes.md to .gitignore (the existing
  rule only matched the singular [Nn]ote.txt).

Build 4.87 s; bundle index 113 KB gz (+4 KB for Sheet primitive +
About expansions). All other chunks unchanged.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-07 10:07:18 +07:00
poli0981 057a922432 chore: update .gitignore to exclude .claude/ directory 2026-04-16 19:57:04 +07:00
poli0981andClaude Opus 4.6 abc4681086 Sharded data store + cleanup
- Replace single data.jsonl with sharded data/ directory (800 records/file)
- load_main()/save_main() handle sharding transparently
- Add migration script (migrate_to_shards.py)
- Remove CSV export (export_data.py, csv_export.sh, update_csv.yml, data.csv)
- Remove legacy scripts (check_duplicate.py, migrate_schema.py, migrate.sh)
- Clean dependencies: remove DateTime, jsonlines, pandas from requirements
- Remove jsonlines from all bash pip installs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-16 19:28:58 +07:00
poli0981 de0ad0a9ea update with 200+ games. 2025-12-28 19:29:10 +07:00
poli0981 65ce52e432 add .gitignore file. 2025-12-26 18:31:38 +07:00