6 Commits
Author SHA1 Message Date
poli0981andClaude Opus 5.5 0f600a99aa build(web): migrate to SvelteKit 3 and adapter-static 4
@sveltejs/kit 2.70.3 -> 3.1.0, @sveltejs/adapter-static 3.0.10 -> 4.0.0.
Closes GHSA-27mw-82g8-phjj and GHSA-pfhg-q3qv-9q6r (dismissed in v4.4.1
as not applicable), and drops the cookie override kit 2 needed: npm audit
reports nothing.

- Config: svelte.config.js is refused by kit 3. Its options are now
  sveltekitConfig(tauri) in build/sveltekit-config.ts, passed by
  vite.config.ts as sveltekit(sveltekitConfig(IS_TAURI)), with tests for
  both CSP flavours, paths.relative, the sitemap entry and the prerender
  404 handler. The unused, now-deprecated "@" alias and typescript.config
  hook are gone; tsconfig.json extends $app/tsconfig and owns `include`.
- $lib -> #lib (package.json imports), with .js on module imports.
  tsconfig repeats the mapping in `paths`: svelte-check --tsgo only maps
  .svelte imports through `paths`, and without it every #lib component
  fell back to the *.svelte shim (props unchecked; proven with a planted
  error).
- Param matchers: src/params/legaldoc.ts -> src/params.ts (defineParams).
  vite build imports that file with Node's own import(), so it imports
  #lib/legal.ts and legal.ts imports ./schema.ts by their real names.
- PWA: @vite-pwa/sveltekit never supported kit 3 and wrote the worker when
  the SERVER build closed, which kit 3's environment build does first.
  build/pwa.ts wires vite-plugin-pwa in a buildApp hook after kit's
  prerender and before its adapter, with the same globs and URL mapping.
- goto options renamed (replace, reset: false, refreshAll); the /games
  filter write is a shallow goto; a legacy /#/ path that matches no route
  falls back to location.replace (kit 3's goto rejects it). Hook types
  from @sveltejs/kit/hooks; the client handleError returns nothing to keep
  kit's message.
- runed 0.35 (bits-ui) peers kit ^2: overridden to our kit, as for
  echarts-wordcloud.

Verified against a kit 2 build of the same commit: same 11,037 files bar
hashed chunks, same non-immutable precache URLs, navigateFallback "/",
identical CSP per page (hashes masked), manifest and sitemap byte-equal,
same visible text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 14:35:49 +07:00
poli0981andClaude Opus 5.5 d057e3f620 fix(deps): patch the open advisories in npm, cargo and pip; Node 24 actions
npm (web/):
- undici 7.30.1 through a "miniflare" override (GHSA-xjj6-f33q-929c,
  GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472). miniflare pins undici exactly
  and wrangler 4.152.0, the newest, still ships 7.29.1. Local tooling only.
- zod 4.6.7 (GHSA-mrhx-c7xc-m3w5, via knip).
- Minor/patch: @lucide/svelte 1.61.0, @tanstack/svelte-virtual 3.13.48,
  bits-ui 2.20.2, vite 8.3.5, wrangler 4.152.0, knip 6.43.0,
  @tauri-apps/cli 2.12.4.

cargo (web/src-tauri/Cargo.lock, targeted updates only):
- rustls 0.23.46 (RUSTSEC-2026-0346..0349), rustls-webpki 0.103.16
  (RUSTSEC-2026-0382), webpki-root-certs 1.0.11 (RUSTSEC-2026-0383),
  tokio 1.54.1 (RUSTSEC-2026-0386), anyhow 1.0.104 (RUSTSEC-2026-0190),
  event-listener 5.4.2 (RUSTSEC-2026-0221), plist 1.10.3 -> quick-xml
  0.42.0 (RUSTSEC-2026-0194/0195). Dependabot had none of these.
- Left upstream: zip 4 (tauri-plugin-updater 2.14.0 asks for ^4), glib 0.18
  (GTK 3), unmaintained proc-macro-error/zbus_names/zvariant.

pip: certifi 2026.10.23, coverage 7.17.0 (tests), with every file's hash.

CI: actions/checkout v4/v5 -> v6 and actions/setup-python v5 -> v6
everywhere (the Node 20 majors warned on every data job), rust-cache 2.9.3
by SHA. dependabot.yml says why those majors are taken by hand.

CLAUDE.md: the undici override and when to drop it; why SvelteKit stays on 2
(GHSA-27mw-82g8-phjj and GHSA-pfhg-q3qv-9q6r need setHeaders or use:enhance,
which the app does not have).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 13:50:58 +07:00
poli0981andClaude Opus 5.5 f3585fe8e6 build(web): Node 26, and TypeScript 7 beside TypeScript 6
Node:
- web/.node-version (26) is the pin. The five setup-node steps say '26' as
  a literal, not node-version-file: release-android.yml checks out the tag
  it rebuilds, and older tags have no such file.
- engines.node >=26 (advisory) and @types/node ^26.6.5; TypeScript 6 still
  type-checks clean with the new types.

TypeScript:
- TypeScript 7.0 has no JavaScript API, and svelte-check (which refuses
  `typescript` 7) and `svelte-kit sync` (route $types) need one, so
  `typescript` stays ^6.0.3 and 7 is the alias
  "@typescript/native": "npm:typescript@~7.0.2", the layout svelte-check
  documents. ~7.0 because 7.1 breaks svelte-check's experimental mode.
- `check` runs svelte-check --tsgo, on TypeScript 7. `check:admin` stays on
  6: --tsgo maps a tsconfig outside the workspace root onto the app's
  components (seen: false errors in src/routes instead of the admin's).
- The four `tsc -p` steps and typecheck:worker call
  node node_modules/@typescript/native/bin/tsc: both packages declare a
  `tsc` bin, so node_modules/.bin/tsc could be either.
- "DOM.Iterable" leaves the admin tsconfigs (an empty lib since 6.0).
- Dependabot ignores the alias (it mishandles npm: aliases) and keeps
  ignoring `typescript` majors, now with the reason.

Checked: type errors planted in a route's script, as a wrong prop on
src/lib/ui/Badge.svelte, in a +page.ts and in one file per tsc config were
each reported by TypeScript 7 (the admin's by 6), every step exiting 1;
--listFilesOnly gives the same programs on 6 and 7; the four tsc checks take
0.5 s instead of 6.0 s. From a clean `npm ci --ignore-scripts` on Node
26.12.1: typecheck, the tests, build, verify-dist (web and tauri), cf:check
and knip (report unchanged) pass, with still exactly three packages that
have install scripts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 10:19:38 +07:00
poli0981andClaude Opus 5.5 988e4f4ce6 ci: pin third-party actions, install without lifecycle scripts, hash Python deps
SonarCloud's GitHub Actions and shell findings, all supply-chain hardening
for jobs that hold a write token (and, in the release workflows, the
signing keys):

- The six third-party actions in release-desktop.yml and release-android.yml
  are pinned to the commit their major tag points at today, with the version
  in a comment for Dependabot. dtolnay/rust-toolchain is pinned to a master
  commit and given `toolchain: stable`: its `stable` branch is regenerated
  on top of master, so a commit of it can vanish.
- Every `npm ci` is `npm ci --ignore-scripts`. Only fsevents, workerd and
  wrangler's esbuild have install scripts; the last two find their binary in
  their optional platform package without them, and fsevents is only file
  watching. `npx` is gone from the workflows (`npm run cf:check`,
  `npm test -- <file>`).
- requirements.txt pins every runtime package, transitive ones included
  (certifi, charset-normalizer, idna), with the sha256 of every file on
  PyPI; every install is `--require-hashes --only-binary :all:`. The new
  requirements-test.txt holds pytest the same way. python-tests.yml runs the
  data jobs' exact install line first, so a Dependabot bump is proven before
  a data job meets it.
- `[[ ]]` instead of `[ ]` in the bash wrappers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 09:31:40 +07:00
poli0981andClaude Opus 5.5 986077d3f1 feat(pipeline): data/blocklist.jsonl - save_main drops and logs removed games
A game the maintainer removes is now a standing instruction in Git, like an
override, instead of a one-time deletion that the browser extension or the
next ingest could undo.

- core/blocklist.py reads data/blocklist.jsonl (one line per game, written by
  /admin and by delete_game.py). save_main() applies it FIRST on every write,
  for all 14 callers, without touching the caller's list, and whatever
  apply_human_overrides says.
- A dropped game is logged once in scripts/removed_games.jsonl as
  status_code "admin_removed", built from the blocklist line alone with
  removed_at = blocked_at, so writing it again changes no byte. A later purge
  line for the same game keeps winning, as dedup_removed() decides.
- More than 500 drops in one save raises BlocklistError before anything is
  written: a damaged file fails the job instead of emptying the catalogue.
- remove_games.py applies the blocklist now and heals a missing log line.
  bash/ingest.sh runs it before ingest_new.py, and ingest-new.yml also
  triggers on blocklist pushes and checks out the tip of main. One workflow
  on purpose: data-write keeps one pending run, so a second workflow and the
  ingest would keep evicting each other.
- ingest_new.py skips blocked links before any Steam request, and a link
  that is not text ({"link": 730}) no longer crashes the run (and every
  three-hourly retry after it).
- Discovery counts blocked appids as known.
- delete_game.py is a non-interactive CLI writing the same bytes as /admin
  (golden fixture), with --list and --check; check-overrides.yml runs --check.
- mark-dead-games.yml commits through bash/commit_push.sh, like every other
  data job: it rebases and retries, and commits the log with the shards.
- dependabot.yml ignores Svelte-era framework majors and @types/node majors
  instead of the React-era names.

With an empty blocklist every path is a no-op.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 12:33:53 +07:00
poli0981andClaude Opus 5 72d00c1014 fix(ci): drop the expired PAT, close an unauthenticated write path, land snapshots
The scheduled pipeline has been failing daily since 2026-08-13 (last successful
`Auto update` was e8b7d1b2). Root cause: `secrets.GH_TOKEN`, a PAT, expired.
Every workflow passing it to actions/checkout dies at fetch with exit 128.

No workflow actually needs a PAT. Each already declares
`permissions: {contents: write}`, so the built-in GITHUB_TOKEN has push rights —
proven by mark-dead-games.yml, the only green data workflow and the only one
with a bare checkout. Removed the `token:` input from all 12 sites. This also
ends the silent-expiry failure mode rather than rescheduling it a year out.

`workflow_run` triggers are unaffected: GITHUB_TOKEN suppression applies to
push/issues/release events, and update-daily.yml plus the three notify-*
workflows all key off workflow_run, which the Actions service emits on run
completion regardless of the checkout token.

Also in this commit:

- ingest-from-issue.yml gated on `author_association`. Without it, any user
  could open an issue titled [add-game] and have their JSON committed and
  pushed to main with `contents: write`. A title match is not an authorization
  check. Its `&&`/`||` commit chain is also parenthesised — left-associativity
  meant it pushed even when there was nothing staged.

- bot-ingest.yml's final step deleted. It referenced `secrets.BOT_TOKEN` while
  the rest of the file uses TELEGRAM_BOT_TOKEN, `cat`-ed a result.txt no step
  creates, ran under `if: always()`, and interpolated a secret straight into a
  shell command line. The Python step above it already does the same Telegram
  callback correctly. `secrets.BOT_TOKEN` is now unreferenced.

- The snapshot feature is committed. snapshot-daily.yml gains the
  `concurrency: {group: data-write}` guard every other data-writing workflow
  has — without it a 23:00 run can push against jobs that take ~2 hours. The
  `pip install requests` in bash/snapshot.sh is dropped: snapshot.py and
  scripts/core/* import only stdlib.

- New web-ci.yml. deploy-pages.yml was the only thing running `npm run
  typecheck`, so deleting it during the Cloudflare migration would leave the
  frontend unchecked. Uses a plain `npm ci` — the old `npm ci || npm install`
  fallback is what let the lockfile conflict above go unnoticed.

- New dependabot.yml. NOTE: an in-repo config replaces the one in repo
  settings and supersedes open PR #111. Groups security updates so the
  transitive backlog collapses into one PR instead of one per package.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 13:46:38 +07:00