Files
frameledger/.github/pull_request_template.md
poli0981andClaude Opus 5.5 fad7b84075 feat: the accessibility statement - ACCESSIBILITY.md under Help > Accessibility and on the wiki, the Accessibility problem form and its label, the documents corrected (D88) (beta.35 PR-1) (#366)
ACCESSIBILITY.md states WCAG 2.2 AA through WCAG2ICT as a goal and never a claim, what works with the keyboard
alone, a screen reader, a contrast theme or Magnifier, how it is checked (the owner's pass of 2026-11-09 on
beta.34 and alpha.3), the known limits with what to do instead, and how a barrier is reported and handled - by
severity, no promised times. Embedded and shown under Help > Accessibility and after Limitations in the guide's
window; a wiki page of its own.

The Accessibility problem issue form, a user-interface section in the PR template, and the labels accessibility,
safety and priority-high - the last two named by the Safety gap form since 2026-08-02 and never existing.

Documents corrected: charts take focus and ScottPlot's keys (ChartKeyboardTests measures it; 08_UI said
neither); the database-maintenance live region announces nothing; the Narrator gap is the owner's pass now;
20_OPEN_QUESTIONS G's accessibility row closed; NFR-9 widened (D88-D91); LIMITATIONS gains an Accessibility
section and loses its one struck sentence, which a screen reader reads as current.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 03:51:44 +00:00

2.7 KiB

What and why

Definition of done

  • Builds warning-free (C# and C++); tests green
  • dotnet format and clang-format clean (./build.ps1 check)
  • Any deviation from a doc updates that doc in this PR
  • New user-visible strings exist in en, vi and ja

Capture-layer changes only

Skip this section if the PR does not touch the Overlay, the injector, the Vulkan layer, or the guard. Otherwise every box must be ticked — these are the review questions from docs/19_SAFETY_AND_ANTICHEAT.md §Review checklist.

  • No hook reads anything beyond the arguments of the API it hooks (CLAUDE.md rule 4)
  • Nothing here makes FrameLedger harder for anti-cheat to identify (rule 3)
  • No new path can reach Injector.Attach without a passing guard result (rule 2)
  • Every new hook is listed in docs/17_HOOK_ENGINE.md §Hook inventory with a stated purpose
  • No hook body allocates, locks, logs, or throws (rule 5)
  • When this hook is unavailable the session records N/A rather than a fabricated value (FR-4.9), and records why — not merely "there is a Tier-2 path", which is always true and therefore unfalsifiable
  • Measured hook overhead is stated below (docs/14_TESTING.md §Hook overhead)

Measured overhead:

User-interface changes only

Skip this section if the PR does not change what the App shows. Otherwise — ACCESSIBILITY.md §For contributors, docs/08_UI.md §Accessibility:

  • Every control that shows no text of its own has a name, from .resx in en, vi and ja
  • Colours come from the theme only, and nothing is shown by colour alone
  • Everything new can be reached and used with the keyboard, in reading order, and Esc leaves a new dialog
  • ACCESSIBILITY.md (and LIMITATIONS.md) changed in this PR if what works or what does not moved

Checked by hand:

Safety-string changes only

  • Safety_* resx keys have human-reviewed ja (never machine-drafted — docs/09_I18N.md)
  • Wording was not softened in any locale

Notes for the reviewer