From 24a87159f4093df9e2754c9bc9aefcbd6d0b1476 Mon Sep 17 00:00:00 2001 From: poli0981 <127664709+poli0981@users.noreply.github.com> Date: Tue, 20 Oct 2026 10:31:47 +0700 Subject: [PATCH] fix: the owner's eight sessions of 2026-10-20 - a x2.52 state, the driver's DLSS word lost at exit, Start directly losing the game Steam starts, two summary windows, display sizes, a bare DLSS line; the Steam note; the two load-flaky tests (beta.27 PR-1) (#330) The owner ran the installed 0.1.0-beta.26 (sessions 64-71) and asked for the results to be checked, the two flaky tests fixed, bugs fixed, and a release if there were bugs. Read from a backup copy of the ledger and the logs (docs/spike-notes/23-owner-runs-2026-10-20.md). - FgWindow.IsNearWholeMultiplier: a window is a state's only within 10 % of a whole multiplier of two or more (FgSlices.Slice.IsActive); FgMixRecord.Parse reads stored rows by the same rule. Silent Hill 2 under Dynamic MFG listed x2.52 for 12.8 s - windows where the multiplier stepped; it now reads x2.0, x3.0, none and 7.36 % not classified. - NgxDriverState / CaptureSession: the driver is not asked after the game has gone, and CREATED | EVALUATE stand once a reading carried them. The last NGX reading, taken after the target exited, replaced every in-game one: none of the 14 answered sessions kept the two bits, so DLSS (driver-reported) and the NVIDIA App's mode (D63) never showed on an NGX-direct title. - CaptureOrchestrator: a launch says it ended on its own (Recorded) with the pids it recorded (Targets), so a process turned away while it ran - the game Steam starts after Lies of P hands itself over - is recorded when it ends; the launch's own process never is. - SessionSummaryOpener: one window per session; opening it again brings it forward. - DisplayTally: the sizes are the mode's last sample that saw the window (a game leaving exclusive fullscreen closes it first; five sessions stored none). - DlssText.Line: no line that says only "DLSS". - Tests: the guard's scan set includes the test host above the harness, which under a full gate releases modules while it starts its other classes - ModuleScanFailed (reproduced 1 run in 12 of the assembly with coverage; 15 of 15 green after), ProcessUnreadable on 2026-10-19. ShmDrainIntegrationTests.InjectAsync asks again on those two reasons only (4 times at most, 250 ms apart); the pause case waits for READY; every injection suite waits for the harness's flushed "presenting" line instead of 800 ms (tests/Shared/HarnessReady.cs). - Docs: 03_METRICS (the mix, the driver-reported rung, display sizes), 04_CAPTURE, 06_DATA_MODEL, 08_UI, 14_TESTING, 18_GPU_VENDOR_APIS, 19_SAFETY (direct starts counted by the crash safety - measured, the policy unchanged), LIMITATIONS, guide (troubleshooting, results), spike-notes section 23, HANDOFF items 20 and 21, CHANGELOG. Then, on the owner's word about Steam games (Play > Start directly says a Steam game may hand itself to Steam - the notice, the tooltip and Settings (en/vi/ja); why a note rather than a fixed Steam rule (beta.27 PR-1)): The owner, 2026-10-20: Steam games hand themselves to Steam; a note in the UI, or a fixed setting that Steam's games always go through the Steam client - the choice left open. The note: - GamePlayer: PlayResult.SteamGame - the game the agent starts (Start directly, or an App running as administrator, or a Steam record with no link) is one Steam's own records name; the notice then reads Play_Started_Steam_Format / Play_Elevated_Steam_Format. Store records are read once a press. - Strings: Play_ToolTip_Direct and Settings_PlayMode_Body say a Steam game may hand itself to Steam and the game Steam then starts is recorded; Settings adds that a few will not start outside Steam at all. en/vi/ja, ja marked review; Strings.Designer regenerated. - Why not the fixed rule: three of the five Steam games started directly on 2026-10-20 ran and were measured from their first frame, and a Vulkan game is measured only when FrameLedger starts it (Everhex Demo) - recorded in 08_UI. - Docs: 08_UI, guide/08-settings, LIMITATIONS, CHANGELOG. - Tests: GamePlayerTests (Steam started directly and elevated say it; a loose or GOG game does not). Co-authored-by: Claude Opus 5.5 --- CHANGELOG.md | 43 ++++++++++ FrameLedger.DrainFixtures.targets | 2 + LIMITATIONS.md | 18 +++- docs/03_METRICS.md | 30 ++++++- docs/04_CAPTURE.md | 7 +- docs/06_DATA_MODEL.md | 2 +- docs/08_UI.md | 17 ++++ docs/14_TESTING.md | 15 ++++ docs/18_GPU_VENDOR_APIS.md | 2 +- docs/19_SAFETY_AND_ANTICHEAT.md | 7 ++ docs/HANDOFF.md | 15 +++- docs/spike-notes.md | 1 + docs/spike-notes/23-owner-runs-2026-10-20.md | 86 +++++++++++++++++++ guide/03-read-your-results.md | 2 +- guide/08-settings.md | 2 +- guide/09-troubleshooting.md | 1 + src/FrameLedger.App/Services/DlssText.cs | 10 ++- src/FrameLedger.App/Services/GamePlayer.cs | 27 ++++-- src/FrameLedger.App/Services/PlayResult.cs | 8 +- .../Services/SessionSummaryOpener.cs | 27 +++++- src/FrameLedger.App/Strings.Designer.cs | 6 ++ src/FrameLedger.App/Strings.ja.resx | 12 ++- src/FrameLedger.App/Strings.resx | 10 ++- src/FrameLedger.App/Strings.vi.resx | 10 ++- .../Capture/CaptureSession.cs | 15 +++- .../Capture/NgxDriverState.cs | 18 +++- .../Recording/FgMixRecord.cs | 7 +- .../Watch/CaptureOrchestrator.cs | 23 +++-- .../Display/DisplayTally.cs | 10 ++- src/FrameLedger.Domain/Metrics/FgSlices.cs | 9 +- src/FrameLedger.Domain/Metrics/FgWindow.cs | 14 +++ .../AgentEndToEndTests.cs | 16 ++-- .../PartialRecoveryEndToEndTests.cs | 12 ++- tests/FrameLedger.App.Tests/DlssTextTests.cs | 23 ++++- .../FrameLedger.App.Tests/GamePlayerTests.cs | 37 +++++++- tests/FrameLedger.App.Tests/PagesLoadTests.cs | 46 ++++++++++ .../Capture/CaptureSessionTests.cs | 43 ++++++++++ .../Recording/FgMixRecordTests.cs | 3 +- .../Watch/CaptureOrchestratorTests.cs | 58 +++++++++++++ .../CaptureHostEndToEndTests.cs | 18 ++-- .../Consume/NgxDriverStateTests.cs | 23 +++++ .../Display/DisplayModeTests.cs | 34 ++++++++ .../Metrics/FgMixTests.cs | 36 ++++++++ .../ShmDrainIntegrationTests.cs | 62 +++++++++---- tests/Shared/HarnessReady.cs | 53 ++++++++++++ 45 files changed, 841 insertions(+), 79 deletions(-) create mode 100644 docs/spike-notes/23-owner-runs-2026-10-20.md create mode 100644 tests/Shared/HarnessReady.cs diff --git a/CHANGELOG.md b/CHANGELOG.md index f33ca2be..1314abea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,49 @@ numeric core and does not move; the heading is the full version — corrected 20 ## [Unreleased] +### Changed + +- **Play ▸ *Start directly* says what a Steam game may do.** Some Steam games hand themselves to Steam when + FrameLedger starts them — Lies of P closes within seconds and Steam starts it again. Starting a game Steam installed, + the notice now says it may hand itself to Steam first and that the game Steam then starts is recorded; the *Start + directly* tooltip and Settings ▸ Games ▸ *Play button* say so too, adding that a few will not start outside Steam at + all. Steam games keep *Start directly*: three of the five started directly on 2026-10-20 ran and were measured from + their first frame, and a Vulkan game is measured only when FrameLedger starts it. In en/vi/ja (ja marked for review). + +### Fixed + +- **A frame-generation "state" of ×2.52.** The owner's Silent Hill 2 session under the NVIDIA App's *Dynamic* multi + frame generation listed ×2.52 for 13 seconds beside ×2.0 and ×3.0: the five-second windows in which the multiplier + stepped from ×2 to ×3 read in between, and three of them formed a state nobody held. Every frame generation that + ships multiplies by a whole number, so a window now counts toward a state only within 10 % of one; the others are + *Not classified*. Sessions already recorded are read by the same rule: that session lists ×2.0, ×3.0, no frame + generation and 7.36 % not classified. The owner's runs of 2026-10-20 are recorded in + `docs/spike-notes/23-owner-runs-2026-10-20.md`. +- **The NVIDIA driver's DLSS report was lost from every stored session.** FrameLedger asked the driver one last time + after the game had closed, and that answer — which no longer says DLSS ran — replaced the ones read while the game + ran. So no session said *DLSS (driver-reported)* where no hook saw DLSS, and none named the NVIDIA App's quality mode + on such a game: Clair Obscur: Expedition 33 under the App's override read *Upscaler not identified*. The driver is no + longer asked once the game has closed, and once it reports that DLSS ran, the session keeps it. Sessions recorded + before keep what they stored. +- **Play ▸ *Start directly* recorded nothing of a game that hands itself to Steam.** Lies of P, started directly, closes + within seconds and Steam starts it again; the game Steam started was turned away while the first session ended and + never recorded. It is now recorded once that session ends, as a game started again already was. Each such start + still counts toward the two early exits that turn hooking off for a game, so Limitations ▸ Play advises starting such + a game through its store. +- **Opening a session's summary twice opened two windows.** The open window comes forward instead, restored if + minimised. +- **No window or monitor size for a game in exclusive full-screen.** A game leaving exclusive full-screen closes its + window a moment before its swap chain says so, and those last samples replaced the sizes: two Lies of P and three + Dark Souls III sessions show none. The sizes are now the last ones the mode saw. +- **A DLSS line that said only "DLSS"**, under a header that already did, is no longer shown: the NVIDIA App's override + loads its libraries under names FrameLedger does not list (The Witcher 3), and the *Loaded:* line prints them. +- **Two integration tests that failed under load** (developers only). The guard reads every process above the test + harness too, the test host among them, and under a full `build.ps1 check` the test host is still starting its other + test classes: a module it released while the guard read its list refused the injection (`ModuleScanFailed`, and + `ProcessUnreadable` on 2026-10-19). The drain suite asks the guard again on those two reasons, four times at most; + the pause case, which once read the writer still starting, waits for it to be ready; and every injection test waits + for the harness's own "presenting" line instead of 800 ms (`tests/Shared/HarnessReady.cs`). + ## Releases Newest first. Each file holds that release's section exactly as it stood here. diff --git a/FrameLedger.DrainFixtures.targets b/FrameLedger.DrainFixtures.targets index 3d8c564e..8fd37d81 100644 --- a/FrameLedger.DrainFixtures.targets +++ b/FrameLedger.DrainFixtures.targets @@ -49,6 +49,8 @@ --> + +