Five lenses filed 20; 8 survived verification.
**release.yml would have failed on the first tag.** The `announce` job called
the ops reusable with no `with:` block, but that reusable resolves
TAG="${INPUT_TAG:-$EVENT_TAG}" where EVENT_TAG is github.event.release.tag_name
-- empty, because this workflow is triggered by `on: push: tags`, not
`on: release`. The job would have exited 1 on "No release tag available" for
every release. Filed independently by three lenses and confirmed against the
reusable's actual source; docs/12 §2.3 had the same omission and is fixed too.
Ironically the comment right above it explains why the workflow deliberately is
not event-driven -- which is exactly what makes tag_override mandatory.
**Nothing checked the BUILT manifest.** The unit test reads wxt.config.ts,
which proves what we ask for, not what WXT emits. Those differ: a dev build of
this same config carries ["bookmarks","storage","tabs","scripting"] and
host_permissions ["http://localhost/*"]. Production is clean, but that is
WXT's behaviour, not ours. scripts/check-manifest.mjs now gates the artifact
and runs in both CI and release; verified by editing a built manifest. The
README sentence claiming a test asserted the built manifest was false and is
corrected -- the same overclaim I had already made once verbally.
**The contrast test I added last commit could not see its own bypass.**
TabBar's `.locked { opacity: 0.65 }` composites --fg-muted against the page and
drops the label to 2.83:1. The test reads token values, so alpha applied on top
is invisible to it. Opacity removed; the padlock and title already carried the
signal. TEXT_PAIRS also widened to check the status colours on --bg, not only
--bg-raised.
**docs/09 T3 was signed off with half its mitigation unbuilt.** The row has
always specified a ⚠ badge for dangerous schemes; only the blocking existed. A
`javascript:` bookmark titled "Your bank" rendered identically to a safe one
and its Open button silently did nothing. isBlockedUrl now drives a badge, and
a refused open raises a toast.
Also: the five row action buttons had glyphs as their accessible names (content
beats title in accname), so voice control could not address them; the manifest
test's literal-harvesting regex would have passed a spread or identifier;
resolveNewFolderParent returned a focused unmodifiable folder's id, which every
create rejects; and clipboard.ts was the only new module with no test.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
92 lines
3.3 KiB
YAML
92 lines
3.3 KiB
YAML
# Release — docs/12 §2.3.
|
|
#
|
|
# Standalone rather than the ops reusable: the reusable's `release` job only
|
|
# runs `gh release create --generate-notes`. It produces no SHA256SUMS.txt
|
|
# (required by docs/09 §5), performs no store submission, and exposes no
|
|
# `outputs:`, so a caller cannot reference the zip it built.
|
|
name: Release
|
|
|
|
on:
|
|
push:
|
|
tags: ['v*']
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
release:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
permissions:
|
|
contents: write # create the GitHub Release
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- uses: actions/setup-node@v6
|
|
with:
|
|
node-version: '24'
|
|
cache: npm
|
|
- run: npm ci
|
|
|
|
# The same gates as CI. A tag must never ship what a PR would have
|
|
# blocked — pushing a tag skips the CI workflow's branch triggers.
|
|
- run: npm run lint
|
|
- run: npm run check
|
|
- run: npm run knip
|
|
- run: npm run coverage
|
|
- run: npm run guard
|
|
|
|
- run: npm run zip # wxt zip → .output/<name>-<version>-chrome.zip
|
|
|
|
# Gate the artifact, not just the config it was built from. A tag is the
|
|
# last point at which an unintended permission can still be stopped.
|
|
- run: npm run check:manifest
|
|
|
|
- name: Verify tag matches manifest version
|
|
run: |
|
|
set -euo pipefail
|
|
MANIFEST_VERSION=$(jq -r '.version' .output/chrome-mv3/manifest.json)
|
|
TAG_VERSION="${GITHUB_REF_NAME#v}"
|
|
test "$MANIFEST_VERSION" = "$TAG_VERSION" \
|
|
|| { echo "::error::tag $TAG_VERSION != manifest $MANIFEST_VERSION"; exit 1; }
|
|
|
|
- name: SHA256SUMS
|
|
working-directory: .output
|
|
run: sha256sum *-chrome.zip > SHA256SUMS.txt
|
|
|
|
- name: GitHub Release
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
run: |
|
|
gh release create "$GITHUB_REF_NAME" \
|
|
.output/*-chrome.zip .output/SHA256SUMS.txt --generate-notes
|
|
|
|
# v1.0.x is published by hand (docs/12 §3) — first store reviews often
|
|
# ask questions and want a human in the loop. Flipping the repo variable
|
|
# CWS_AUTOPUBLISH to 'true' turns this on for v1.1+.
|
|
- name: Publish to Chrome Web Store
|
|
if: vars.CWS_AUTOPUBLISH == 'true'
|
|
env:
|
|
CHROME_EXTENSION_ID: ${{ secrets.CHROME_EXTENSION_ID }}
|
|
CHROME_CLIENT_ID: ${{ secrets.CHROME_CLIENT_ID }}
|
|
CHROME_CLIENT_SECRET: ${{ secrets.CHROME_CLIENT_SECRET }}
|
|
CHROME_REFRESH_TOKEN: ${{ secrets.CHROME_REFRESH_TOKEN }}
|
|
run: npx wxt submit --chrome-zip .output/*-chrome.zip
|
|
|
|
# A job INSIDE this workflow, not an `on: release: [published]` caller.
|
|
# A Release created by `gh release create` under the default GITHUB_TOKEN
|
|
# emits no event that starts new workflow runs, so an event-driven caller
|
|
# would silently never fire.
|
|
announce:
|
|
needs: release
|
|
uses: poli0981/.github/.github/workflows/announce-release.yml@main
|
|
permissions:
|
|
contents: read
|
|
with:
|
|
# REQUIRED here, and only because of the comment above. The reusable
|
|
# resolves `TAG="${INPUT_TAG:-$EVENT_TAG}"` with EVENT_TAG =
|
|
# github.event.release.tag_name — which is empty under `on: push: tags`,
|
|
# so without this the job exits 1 on "No release tag available" and the
|
|
# announcement never fires for any release.
|
|
tag_override: ${{ github.ref_name }}
|
|
secrets: inherit
|