Files
poli0981andClaude Fable 5.2 2be6955087 fix(review): code and documentation review findings for 1.2.1
Two independent reviews, of the code and of the documentation against it.

Code:
- A first click on a row button or a chevron jumped the tree to the top:
  handing focus to the tree with no row focused made it pick the first one.
  The clicked control's row becomes the focused one, and the tree only picks
  the first row for a focus that came from the keyboard — which also stops a
  plain click on a row in a scrolled tree from landing on the wrong row.
- Three forced-colours rules lost to more specific ones: the selected theme
  lost its label on hover, About's status-bar entry had no right edge, and a
  drop into the focused folder showed nothing.
- Under a search, Alt+Up/Down announced the position among all siblings while
  the row's aria-posinset counts the ones on screen; it announces the latter.
  Moves run one at a time, and the live region is emptied before each
  message so a repeated text is spoken.
- The preview's "Show more" was still 22 px; the ring on "Show earlier / Show
  more" and on the "Move to…" folders was clipped; placeholders used the
  browser's grey, which no contrast test saw.
- EditTab's script was over the 150-line limit: its live-sync wiring moves to
  stores/edit-live.ts.

Documentation:
- ACCESSIBILITY.md promised more than the code does in nine places ("every
  clickable target is 24 px", "nothing times out", "focus is always a 2-pixel
  ring", four operating systems "supported"). Rewritten to what the source
  supports; the untested list and the known limitations grew.
- docs/05, 06, 10, 11, 13, 15 and CLAUDE.md corrected where they named tests
  that did not exist, miscounted, or were overtaken by the fixes above.

tests: a managed node, hidden siblings under a search and an in-flight move
for nudge; the statement's key table is checked against tree-keyboard.ts.
capture/about.png shows the new About link.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 11:18:58 +07:00
..