diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index bbe832b..9d9b53d 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -15,7 +15,7 @@ contact_links: about: Reviews are read, but a bug reported here gets fixed faster. - name: Question, or no GitHub account - url: mailto:contact@poli0981.dev + url: mailto:code@poli0981.dev about: >- Email works. Please do not attach your real bookmarks file — see the privacy policy for what happens to anything you send. diff --git a/CLAUDE.md b/CLAUDE.md index e61b8a4..e3b0bee 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -111,11 +111,12 @@ install, privacy summary, donate), full manual QA (docs/11 §5), `wxt zip` clean-install test. Also carried in from the Phase 4 review: - ✔ About's "Changelog" link now targets `CHANGELOG.md`, pinned by `tests/unit/links.test.ts`; -- ✔ `EditTab.svelte` split (589 → 459, under the hard limit). It grew back - through the Phase 5 and 6 review commits — **476 lines with a 356-line script - block** as of 2026-10-28, against a 150-line soft limit for script blocks - (docs/10 §1). Anything added there has to come out first; `src/lib/edit/` is - where extracted logic goes; +- ✔ `EditTab.svelte` split (589 → 459, under the hard limit). It grew back to + 481, and in v1.1.0 its state and commands moved to + `src/lib/stores/edit-session.svelte.ts` — the component is now ~295 lines of + wiring and markup. The store itself (364) and `TreeRow.svelte` (353) sit + between the 300 target and the 500 hard limit: split them before adding to + them; - ✔ contrast tokens fixed, and `tests/unit/styles/contrast.test.ts` now fails the build on any text pair under 4.5:1. Two blind spots to know about: it is token-level, so it cannot see the `opacity`-on-text bypass it was written to @@ -134,6 +135,22 @@ CI hardening → the About store link → cut 1.0.1. **Exit:** ✔ v1.0.1 tagged and released 2026-08-03, live on the store (confirmed 2026-10-28). +### Phase 7 — v1.1.0: toolchain, import redesign, new formats, technical UI +Two PRs. **PR-A** (toolchain): Node 26, TypeScript 7 beside the TS 6 API, +ES2025 with Chrome ≥ 136, SonarCloud in CI, a browser-enforced zero-network +CSP, gates that cannot be talked past. **PR-B** (product): the import pipeline +redesigned — every entry a file holds read, addresses Chrome would refuse +skipped up front, Chrome's `Bookmarks` file and Firefox JSON backups imported, +root markers so restores stop nesting, a Merge that reuses folders, a Replace +that plans first and refuses an unrestorable backup; the Edit tab rebuilt +around a store, with Sort A→Z, drag to reorder and batched live sync; a +technical redesign of every surface; local diagnostics; a cross-tab write +lock; docs and legal synced (clarifications only — `LEGAL_VERSION` stays 1); +contact aliases per purpose. +**Exit:** `main` tag-ready with `verify:full` green; the human runs the +docs/11 §5 manual pass on real Chrome including the **1.0.1 → 1.1.0 upgrade +over an existing profile** ⚠️, then uploads the release zip to the store ⚠️. + ## Working style - Small commits per module; tests land with (or before) implementation. @@ -149,6 +166,16 @@ CI hardening → the About store link → cut 1.0.1. how a missing `@types/node` survived a green local `verify` and failed CI on the first push. A green local type-check in a worktree is weaker evidence than it looks. +- **TypeScript 7 runs beside the TS 6 API.** `tsc` is TS 7 (`@typescript/native`, + aliased `npm:typescript@~7`); the `typescript` package is aliased to + `@typescript/typescript6` for svelte-check, which needs the classic API TS 7 + does not have yet. `npm run check` runs svelte-check (TS 6, `.svelte` files) + and then `tsc` (TS 7, `.ts` and `scripts/*.mjs`). Never "fix" one by + removing the other. +- **Installs run with `--ignore-scripts`**, in CI and locally when in doubt: + `npm ci --ignore-scripts && npx --no-install wxt prepare`. The `postinstall` + hook only runs `wxt prepare`; every other package's install script is + untrusted code. - When a browser fixture contradicts the format spec: add the fixture, make the parser tolerant, note the quirk in code + docs/04 §1.2, then continue. - Do not invent features not in docs; park ideas as `docs/15` roadmap PRs. diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 1a769e0..1fec44a 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -56,7 +56,7 @@ spaces. ## Enforcement Instances of abusive, harassing, or otherwise unacceptable behavior may be -reported to the maintainers at **contact@poli0981.dev**. All complaints will be +reported to the maintainers at **code@poli0981.dev**. All complaints will be reviewed and investigated promptly and fairly. Maintainers are obligated to respect the privacy and security of the reporter of diff --git a/README.md b/README.md index 8e55008..e654b23 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,9 @@ [![License: GPL-3.0-or-later](https://img.shields.io/badge/license-GPL--3.0--or--later-blue.svg)](LICENSE) [![CI](https://github.com/poli0981/bookmarkmagic/actions/workflows/ci.yml/badge.svg)](https://github.com/poli0981/bookmarkmagic/actions/workflows/ci.yml) [![CodeQL](https://github.com/poli0981/bookmarkmagic/actions/workflows/codeql.yml/badge.svg)](https://github.com/poli0981/bookmarkmagic/actions/workflows/codeql.yml) +[![Quality gate](https://sonarcloud.io/api/project_badges/measure?project=poli0981_bookmarkmagic&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=poli0981_bookmarkmagic) +[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=poli0981_bookmarkmagic&metric=coverage)](https://sonarcloud.io/summary/new_code?id=poli0981_bookmarkmagic) +[![Chrome Web Store](https://img.shields.io/chrome-web-store/v/eghnciphhegekmnofffpgbdfefckdhmg?label=Chrome%20Web%20Store)](https://chromewebstore.google.com/detail/bookmarkmagic/eghnciphhegekmnofffpgbdfefckdhmg) [![Runtime dependencies: 0](https://img.shields.io/badge/runtime%20dependencies-0-brightgreen.svg)](#privacy) Move your bookmarks between browsers the simple way: with a file. No account, @@ -23,15 +26,21 @@ folder trees. English · Tiếng Việt · 日本語. ## What it does -- **Import** HTML, JSON or CSV bookmark files, with a full preview first — +- **Import** HTML, CSV and JSON bookmark files — including Chrome's own + `Bookmarks` file from the profile folder and Firefox's JSON backups, the + copies you have when a browser will not start. A full preview comes first: counts, folders, depth, duplicates and warnings before anything is written. -- **Choose how**: into a new dated folder (the safe default), merged into your - existing folders, or replacing everything. Replace saves a JSON safety backup - first and **deletes nothing until that backup is proven**. +- **Choose how**: into a new dated folder (the safe default), merged into the + folders you already have (reused, not copied), or replacing everything. + Replace tells you exactly what it will delete, saves a JSON safety backup + first, and **deletes nothing until that backup is proven** — and restoring + that backup puts the Bookmarks bar, Other and Mobile bookmarks back where + they were. - **Export** everything, or just the folders you pick, to HTML (Chrome, Edge, Brave, Firefox, Safari, Vivaldi, Opera), JSON, CSV or Markdown. -- **Edit** the tree: search, rename, drag & drop, create folders, delete, and - find duplicate links — every action reachable from the keyboard. +- **Edit** the tree: search, rename, drag to move or reorder, sort a folder + A→Z, create folders, delete, and find duplicate links — every action + reachable from the keyboard. ## Privacy @@ -47,7 +56,13 @@ This is the whole point of the project, so it is worth being precise. over `wxt.config.ts`, and `npm run check:manifest`, which CI runs against the **built** `manifest.json` — because a build can add what the config never asked for. -- **Zero runtime dependencies.** Nothing third-party ships in the extension. +- **Zero runtime dependencies.** Nothing is installed at runtime; the only + third-party code in the package is what the build compiles in — the Svelte + runtime and WXT's one-line browser shim, both MIT + ([`legal/THIRD_PARTY_NOTICES.md`](legal/THIRD_PARTY_NOTICES.md)). +- A short diagnostics log (error codes and counts, never titles or addresses) + lives in memory while a tab is open, so you can copy it into a bug report. + It never leaves your computer unless you paste it somewhere. - Settings use `chrome.storage.local`, never `storage.sync`, so even your preferences stay off any vendor cloud. @@ -84,9 +99,15 @@ Then load `.output/chrome-mv3/` at `chrome://extensions` with Developer mode on. npm run dev ``` -`npm run verify` is the gate everything else answers to — lint, type-check, -knip, the grep gate and the test suite, in that order. It must be green before -every commit. +`npm run verify` is the gate everything else answers to — lint, type-check +(svelte-check on the TypeScript 6 API, then `tsc` 7), knip, the grep gate and +the test suite, in that order. It must be green before every commit; +`npm run verify:full` adds coverage, the build and the built-manifest check, +and must be green before anything release-bearing. + +`node scripts/screenshots.mjs` serves the built extension with sample +bookmarks and a fake `chrome`, for looking at every page without loading the +extension (`--shoot` also captures the store screenshots). The [`docs/`](docs/) directory is the binding specification, not notes: where code and docs disagree, the docs win. Start with [`CLAUDE.md`](CLAUDE.md), then @@ -115,6 +136,23 @@ not negotiable, and how a reported file becomes a regression test. Security issues: please follow [`SECURITY.md`](SECURITY.md) rather than opening a public issue. +## Contact + +| For | Write to | +|---|---| +| Security vulnerabilities (if you have no GitHub account) | security@poli0981.dev | +| Privacy questions, removing a sample you sent | privacy@poli0981.dev | +| The terms (EULA, disclaimer) | legal@poli0981.dev | +| Licensing and permission questions | copyright@poli0981.dev | +| Formal copyright (DMCA) notices | dmca@poli0981.dev | +| A copy or listing pretending to be BookmarkMagic | takedown@poli0981.dev | +| Contributing and code of conduct | code@poli0981.dev | +| Sponsorship · collaboration · press | sponsor@ · collab@ · press@poli0981.dev | + +Bugs and feature ideas are best as +[issues](https://github.com/poli0981/bookmarkmagic/issues) — they help the next +person too. The extension itself never shows or uses any of these addresses. + ## Support development Entirely optional — BookmarkMagic is free software either way. @@ -127,9 +165,14 @@ Entirely optional — BookmarkMagic is free software either way. ## Licence +Copyright © 2026 skullmute ([poli0981](https://github.com/poli0981)). [GPL-3.0-or-later](LICENSE). Also see [`legal/EULA.md`](legal/EULA.md), [`legal/DISCLAIMER.md`](legal/DISCLAIMER.md) and -[`legal/THIRD_PARTY_NOTICES.md`](legal/THIRD_PARTY_NOTICES.md). +[`legal/THIRD_PARTY_NOTICES.md`](legal/THIRD_PARTY_NOTICES.md). Licensing +questions: copyright@poli0981.dev. -Not affiliated with or endorsed by Google, Chrome, or any browser vendor. -Browser names are trademarks of their respective owners. +The BookmarkMagic name and icon identify this project. The GPL lets anyone fork +the code; it does not let a fork present itself as this project. + +Not affiliated with or endorsed by Google, Chrome, Mozilla, Firefox or any +browser vendor. Browser names are trademarks of their respective owners. diff --git a/SECURITY.md b/SECURITY.md index f0c195b..74cb976 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -17,7 +17,7 @@ see which version you are running in the extension's **About** tab, or on Report privately via **GitHub Security Advisories**: -No GitHub account? Email **contact@poli0981.dev** instead. Please say up front +No GitHub account? Email **security@poli0981.dev** instead. Please say up front that it is a security report. Please do not open a public issue for a security problem. diff --git a/docs/14_LEGAL_GATE.md b/docs/14_LEGAL_GATE.md index 8971ccd..e4aab81 100644 --- a/docs/14_LEGAL_GATE.md +++ b/docs/14_LEGAL_GATE.md @@ -60,6 +60,7 @@ without shipping a bug. So the bump is a decision, never a side effect: | A new obligation, permission, or data flow — anything a user could reasonably object to | **Yes.** Bump, and say so in the CHANGELOG, so the reappearing gate is explicable rather than alarming. | | Wording that narrows or clarifies something already true | No. Record the reasoning in the `15` decision log so the judgement stays auditable. | | Typos, formatting, dead links | No. | +| Contact details — a new address, a different alias for a purpose | No. It changes how to reach us, not what anyone agreed to. Log it in `15`. | Procedure for a bump: edit `legal/*.md` → bump `LEGAL_VERSION` → update the CWS Privacy tab if the privacy text changed at all (`08 §5`, `09 §4`; a privacy-tab @@ -74,6 +75,27 @@ Deliberately **not** a bump: it describes what happens to data a user chooses to send us, which was never inside "what the Extension collects", and re-gating every installed user over a clarification is the worse of the two outcomes. +**Precedent (2026-10-29, v1.1.0):** all four documents gained a version/date +header ("Terms version 1 · Effective 2026-07-26 · Last updated …"), a copyright +line, and per-purpose contact aliases (`legal@`, `dmca@`, `privacy@`, +`takedown@`, `copyright@`; `contact@` retired). EULA clause 3 — worded as an +obligation, which a GPL program cannot impose (§10) — became a note. +DISCLAIMER now describes Replace as it really behaves (confirmation with exact +counts, refusal when no restorable backup is possible). PRIVACY now describes +the in-memory diagnostics log, the Chrome Web Store's own role, what happens +when a user opens a bookmark (the browser's request, not the Extension's), and +what the build compiles in. THIRD_PARTY_NOTICES now lists the Svelte runtime +and WXT's browser shim, which the build always compiled in. **Not a bump:** +every change clarifies or corrects a description of what was already true, or +removes an obligation; none adds one or a data flow. + +**What each `LEGAL_VERSION` means** — the text a user who accepted that number +agreed to: + +| `LEGAL_VERSION` | Accepted text | Notes | +|---|---|---| +| 1 | The four `legal/` files as published 2026-07-26, with the clarifications of 2026-08-03 and 2026-10-29 | The clarifications are listed above; git history has each wording | + ### 3.2 `LICENSE` Full GPL-3.0 text at **repo root** (already committed). Variant resolved: @@ -85,15 +107,21 @@ same value in `package.json#license` (`01 §5`). | Surface | Shows | |---|---| | First-run gate | Summary + 4 links + accept | -| About tab | 4 links + accepted date/version + "Third-party dependencies: None" | +| About tab | 4 links + accepted date/version + "Third-party code" (the Svelte runtime and WXT's browser shim, MIT, as compiled in) + Copy diagnostics | | Store listing | GitHub link; privacy-policy URL in Privacy tab | | README | License badge, links to `legal/` | ## 5. Third-party & donations note -- v1 ships **zero runtime dependencies** → About states "None". If `fflate` - lands in v1.1, About must render its name + MIT license text (add - `THIRD_PARTY_NOTICES.md` generated at build time — keep the rule ready). +- **Zero runtime dependencies are installed**, but the build compiles two + MIT-licensed pieces into the package: the Svelte runtime and + `@wxt-dev/browser`'s one-line shim. Through v1.0.x the About tab said "None" + and THIRD_PARTY_NOTICES said "no third-party code" — both wrong, corrected in + v1.1.0. The notices ship as `THIRD_PARTY_NOTICES.txt` (from `src/public/`), + which `check:manifest` requires in every build; `legal/THIRD_PARTY_NOTICES.md` + is the same list for readers of the repository. A new runtime dependency + (`fflate`, if ever) adds its name and license text to both files in the same + pull request, and the About tab names it. - Donate links live in About + README only — outbound links are fine on CWS; no payment functionality inside the extension. Handles are resolved (from the portfolio's `.github/FUNDING.yml`, which this repo copies verbatim): diff --git a/docs/15_ROADMAP.md b/docs/15_ROADMAP.md index 66b4086..f476ee3 100644 --- a/docs/15_ROADMAP.md +++ b/docs/15_ROADMAP.md @@ -25,6 +25,7 @@ Build-phase breakdown lives in `CLAUDE.md` (single source for sequencing). | **v1.0.1 released** | ✔ 2026-08-03 | signed tag on `4654086`, GitHub Release with a `sha256sum -c`-verified zip; shipped manifest `1.0.1`, permissions unchanged. `announce` skipped (no `DISCORD_ANNOUNCE`), store publish skipped (no `CWS_AUTOPUBLISH`) | | **v1.0.1 submitted** | ✔ 2026-08-03 | uploaded to the CWS dashboard by hand (`13 §1b` step 6) | | **v1.0.1 published** | ✔ observed 2026-10-28 | listing shows version 1.0.1 (`Updated: August 3, 2026`), 5 users. ⚠️ Exact approval date not recorded; `13 §1b` step 10 (clean-profile install of the published build + upgrade re-check) has no recorded result | +| 7 — v1.1.0 | in review 2026-10-29 | PR-A toolchain/CI/Sonar merged as #26; PR-B (import redesign, Chrome/Firefox formats, Merge reuse, Edit store + Sort A→Z + reorder, technical UI, diagnostics, docs/legal) on `release/1.1.0` | **Verified on real browsers 2026-07-25:** Chrome and Brave, unpacked build. Until that point every phase had been tested only against a hand-rolled @@ -125,7 +126,34 @@ independently of the package (`13 §5`), though the copy should still go through | ✔ Import Firefox `.json` backup | **Shipped in v1.1.0** (`04 §2b`). The compressed automatic backups (`.jsonlz4`) are a separate item: a ~80-line pure-TS LZ4 block decoder, no dependency. | | "Export all formats as .zip" | First runtime dep decision: `fflate` (gated, `01 §4`; About/THIRD_PARTY updates per `14 §5`). | | Aggressive-dedupe toggle | Optional `www.`/`utm_*` stripping in normalize (off by default). | -| Sort folder A→Z action | In #edit context menu (bulk `move` with index). | +| ✔ Sort folder A→Z action | **Shipped in v1.1.0** — a row action and a toolbar button, planned first and confirmed with a count (`03 §3`). | + +### Next direction (written 2026-10-29, ordered by value per risk) + +1. **v1.1.x — automate the upgrade test.** An end-to-end run with Playwright's + bundled Chromium (`--load-extension` still works there; branded Chrome + dropped it in 137) that installs 1.0.1, upgrades over the same profile and + runs the `11 §5` smoke in CI. Needs a dev-dependency approval (`01 §4`). +2. **v1.1.x — Firefox automatic backups** (`.jsonlz4`): a ~80-line pure-TS LZ4 + block decoder, no dependency. Also: capture a real Chrome HTML + `Bookmarks` + pair to sit beside the hand-built `chrome-156-*` fixtures, and the JA native + review. +3. **v1.2 — the aggressive-dedupe toggle** (deferred this round), a + session-scoped import undo, Biome linting of `.svelte` files, and true + virtualization of the edit tree if 500-row chunks prove too coarse. +4. **v1.2+ — automated CWS publishing** once the owner creates the `CHROME_*` + secrets; Edge Add-ons and Firefox AMO listings through WXT's multi-target + build (each a separate go/no-go). + +### Backlog carried from the v1.1.0 audit + +Items found by the 2026-10-28 audit and not closed in v1.1.0, with their IDs: +cL6 non-UTF-8 charsets in HTML imports; cL9 an extension allowlist on drop +(content sniffing is the gate, so not planned); cL13 a newline inside a title +for Chrome's line-based importer; sA8.1 Biome does not lint `.svelte`; uH4's +windowed renderer (500-row chunking shipped instead); the edit-session store +(364 lines) and TreeRow (353) sit between the 300-line target and the 500 hard +limit and should be split before they grow. ## v1.2 — resilience @@ -243,3 +271,18 @@ independently of the package (`13 §5`), though the copy should still go through | 2026-10-29 | **Replace never dedupes, and the plan says so** (`plan.dedupe` is the effective value). In-file repeats are part of a backup; 1.0.x collapsed them while the box showed unchecked. Merge dedupes against the Start-time read, not the preview snapshot | 03 §1 | | 2026-10-29 | **The plan is built before the backup, and the backup is refused if the import could not read it back.** Compact BM JSON, checked against the node, depth and byte caps before anything is written, downloaded or deleted (`BACKUP_EXCEEDS_LIMITS`). The still-open save dialog's rejection is marked handled, so a later Cancel cannot surface as an unhandled rejection | 03 §1 step 6b, 02 §7 | | 2026-10-29 | **The seeded round-trip suite had been testing 200 empty trees since Phase 1.** xorshift32 seeded with 1–200 draws near-zero values first, so every generated tree had 0 children. `makeRng` now scrambles the seed, and every seeded suite asserts its corpus is non-trivial before asserting anything else. Found by the new merge property suite's own non-vacuity check | 11 §3 | +| 2026-10-29 | **Sort A→Z is planned before it runs and moves only what is out of place.** Folders first, `Intl.Collator` numeric and accent/case-insensitive, stable; left-to-right moves, each taking a child from further right, so the target index needs no correction for `chrome.bookmarks.move`'s same-parent rule. The confirmation states the count; a refusal part-way says how far it got and re-reads | 03 §3 | +| 2026-10-29 | **Drag to reorder, with before/after/into zones.** `planDrop` converts once between Chrome's pre-removal move index and `onMoved`'s post-removal one; dropping a node beside itself is no move; the permanent roots take drops into only | 03 §3, 06 §3.3 | +| 2026-10-29 | **Live sync is batched per animation frame and re-reads on bursts** (more than 500 queued events), after a wholesale reorder and after Chrome's own import. Each listener is isolated in try/catch. 1.0.x patched the whole tree — and rescanned it for duplicates — once per event | 03 §3 | +| 2026-10-29 | **Bounded rendering ships as 500-row chunks, not windowing.** The edit tree, the import preview and the export picker mount 500 rows at a time with "Show more"; the focused row is always mounted. Windowing was the plan; chunking gives the same bound with none of the keyboard/DnD risk, and windowing moves to the backlog | 05 §9 | +| 2026-10-29 | **One modal for every dialog** (`Modal.svelte`, native ``): focus in, Esc, focus returned, and no cancel callback after a confirm. Move-to was a positioned `
` that focus never entered | 06 §5 | +| 2026-10-29 | **The v1.1 look is "technical"**: cool neutrals, a mono stack for labels and numbers, a faint grid, 6/4 px radii, a self-drawn SVG icon set, an IDE-style status bar. No font is bundled. Every animation and moving transition sits inside `prefers-reduced-motion: no-preference`, enforced by `motion.test.ts`; text clears 4.5:1 and control boundaries 3:1 on every surface, enforced by `contrast.test.ts` | 06 §1 | +| 2026-10-29 | **Replace asks first, with numbers.** The confirmation states how many bookmarks and folders will be deleted and how many written; the Start button counts what a preview plan will really import, not what the file holds | 03 §1, 09 T4 | +| 2026-10-29 | **One writer across Manager tabs** (Web Locks, `ifAvailable`): a second tab's import, sort or duplicate clean-up is refused at once with `WRITE_LOCKED`. The import takes the lock after opening the save picker, so the click's activation still holds | 03 §5, 08 §2 | +| 2026-10-29 | **The popup routes an open Manager** over a `BroadcastChannel` instead of only focusing it; the Manager refuses while an import writes | 02 §6 | +| 2026-10-29 | **A local diagnostics log, copied by the user.** In memory, 200 allowlisted events (phases, codes, counts, error names), recorded at the one place failures are described — by code, never detail text. No storage, no network, no new permission. A PRIVACY clarification, not a bump | 09 §5, 14 §3.1 | +| 2026-10-29 | **Failure toasts stay until dismissed**; success and info still leave after 4 s | 06 §4 | +| 2026-10-29 | **About and THIRD_PARTY_NOTICES stop saying "no third-party code"** — the build always compiled in the Svelte runtime and WXT's browser shim (both MIT). The notices now ship as `THIRD_PARTY_NOTICES.txt`, required by `check:manifest` | 14 §5 | +| 2026-10-29 | **Contact aliases per purpose**: security@ (SECURITY.md), privacy@ (PRIVACY), legal@ and dmca@ (EULA, DISCLAIMER), copyright@ (licensing), takedown@ (impersonating copies), code@ (CoC, contributing, issue chooser), sponsor@/collab@/press@ (README); contact@ retired. Still none inside the product — `links.test.ts` now scans all of `src/` | 14 §3.1, 09 §6 | +| 2026-10-29 | **Legal clarifications, no `LEGAL_VERSION` bump**: version/date headers, a copyright line, EULA clause 3 as a non-binding note (GPL §10), DISCLAIMER's Replace description, PRIVACY on diagnostics, the Web Store and opening a bookmark | 14 §3.1 | +| 2026-10-29 | **`scripts/screenshots.mjs`** serves the built extension with a fake `chrome`, neutral sample data and the production CSP as a meta tag; `--shoot` drives headless Chrome for `capture/` and the store set. Visual QA and listing screenshots stop depending on anyone's real profile | 11 §5, 13 | diff --git a/legal/DISCLAIMER.md b/legal/DISCLAIMER.md index 6981a50..a72a889 100644 --- a/legal/DISCLAIMER.md +++ b/legal/DISCLAIMER.md @@ -1,15 +1,27 @@ # Disclaimer — BookmarkMagic +Terms version 1 · Effective 2026-07-26 · Last updated 2026-10-29 + - Provided "AS IS", without warranty of any kind (see LICENSE §15–16). - Bookmark operations modify your browser's bookmark data. The "Replace - everything" mode DELETES all existing bookmarks after saving an automatic - safety backup. You are responsible for keeping backups of data you care - about. + everything" mode DELETES all existing bookmarks. Before it does, it saves a + safety backup and asks you to confirm with the exact numbers it will delete + and write; it does not start if your bookmarks are larger than a backup the + Extension could read back. If the browser stops part-way, what was already + deleted can be restored by importing that backup. You remain responsible for + keeping backups of data you care about. - Imported bookmarks are created with the current date and time. Chrome's extension API does not allow an extension to set a bookmark's original creation date, so original dates are preserved in your exported *files* but not when writing back into the browser. - Import files come from outside this Extension; verify you trust their source. Bookmarked URLs are stored as-is and are not vetted by the Extension. -- This project is not affiliated with or endorsed by Google, Chrome, or any - browser vendor. Browser names are trademarks of their respective owners. +- This project is not affiliated with or endorsed by Google, Chrome, Mozilla, + Firefox or any browser vendor. Browser names are trademarks of their + respective owners. +- The BookmarkMagic name and icon identify this project, published by skullmute + (poli0981). The GPL lets anyone fork the code; it does not let a fork present + itself as this project. Report a copy that does to **takedown@poli0981.dev**, + and formal copyright notices to **dmca@poli0981.dev**. + +Questions about this disclaimer: **legal@poli0981.dev**. diff --git a/legal/EULA.md b/legal/EULA.md index b4071de..623643d 100644 --- a/legal/EULA.md +++ b/legal/EULA.md @@ -1,5 +1,9 @@ # End User License Agreement — BookmarkMagic +Terms version 1 · Effective 2026-07-26 · Last updated 2026-10-29 + +Copyright © 2026 skullmute ([poli0981](https://github.com/poli0981)). + 1. **License.** The software is free software licensed under the GNU General Public License v3.0 or later (see LICENSE). You may use, study, share, and modify it under those terms. This EULA adds no restrictions beyond the GPL; @@ -7,9 +11,19 @@ 2. **No warranty; limitation of liability.** As stated in GPL-3.0 §15 and §16, the software is provided without warranty, and authors are not liable for damages, including loss of bookmark data. -3. **Acceptable use.** You agree not to use the software to violate applicable - law or third-party rights. +3. **A note on use — not a condition.** Please do not use the software to break + the law or to infringe anyone's rights. This restates what the law already + requires; it is not an additional license term, because GPL-3.0 §10 does not + allow one, and your rights under the GPL do not depend on it. 4. **Your data.** The software processes bookmark data locally on your device - only (see PRIVACY.md). + only, and sends nothing anywhere (see PRIVACY.md). 5. **Updates.** Updates are delivered via the Chrome Web Store and may change functionality. Material legal changes trigger re-acceptance in-app. +6. **Contact.** Questions about these terms: **legal@poli0981.dev**. Formal + copyright infringement (DMCA) notices: **dmca@poli0981.dev**. + +--- + +*Clarified on 2026-10-29: clause 3 was worded as an obligation, which a GPL +program cannot impose; it is now a note, and clause 6 gives contacts. Nothing +you agreed to changed, so no re-acceptance is requested (`docs/14 §3.1`).* diff --git a/legal/PRIVACY.md b/legal/PRIVACY.md index 98a4d33..f4af401 100644 --- a/legal/PRIVACY.md +++ b/legal/PRIVACY.md @@ -1,6 +1,6 @@ # Privacy Policy — BookmarkMagic -Last updated: 2026-08-03 +Terms version 1 · Effective 2026-07-26 · Last updated 2026-10-29 BookmarkMagic ("the Extension") is designed to work entirely on your device. @@ -21,7 +21,15 @@ contains no analytics, telemetry, or crash reporting. `chrome.storage.sync`, so even your settings stay off any vendor cloud. The Extension requests no other permissions. It has no host permissions, no -content scripts, and no background service worker. +content scripts, and no background service worker. Its Content-Security-Policy +forbids it from opening network connections at all. + +- **Diagnostics** (no permission needed): while a BookmarkMagic tab is open, + it keeps a short log of what it did — import steps, error codes, counts — + in memory, so that you can copy it into a bug report from the About tab. It + never contains titles, addresses or file names, is never written to storage, + disappears when the tab closes, and leaves your computer only if you paste + it somewhere yourself. ## Files you import or export @@ -32,7 +40,20 @@ location you control. ## Third parties No data is shared with anyone, because no data is collected. The Extension -ships with zero runtime dependencies. +installs no runtime dependencies; the two small MIT-licensed pieces its build +compiles in (the Svelte runtime and WXT's browser shim — see +THIRD_PARTY_NOTICES.md) contain no network code. + +Two things happen outside the Extension and are worth knowing: + +- **The Chrome Web Store** (Google) distributes the Extension and its updates. + Installing and updating it are governed by Google's own privacy policy, not + this one, and Google gives the developer only aggregate counts such as the + number of users. +- **Opening a bookmark.** When you open a bookmark from the Edit tab, your + browser loads that page exactly as when you click any link: the request is + the browser's, made on your instruction, to the site you chose. The + Extension itself still sends nothing. ## If you contact us @@ -62,7 +83,13 @@ of practice: it describes handling of material you choose to send us, which was never part of what the Extension itself collects — which remains nothing. No re-acceptance was requested.* +*Clarified on 2026-10-29: the diagnostics log, the Chrome Web Store, opening a +bookmark, and what the build compiles in are now described, and the contact +address changed. None of it changes what the Extension collects — still +nothing — so no re-acceptance is requested (`docs/14 §3.1`).* + ## Contact -Email: contact@poli0981.dev — or open an issue at +Privacy questions, and requests to remove a sample you sent: +**privacy@poli0981.dev** — or open an issue at diff --git a/legal/THIRD_PARTY_NOTICES.md b/legal/THIRD_PARTY_NOTICES.md index 2bfd290..61cd17c 100644 --- a/legal/THIRD_PARTY_NOTICES.md +++ b/legal/THIRD_PARTY_NOTICES.md @@ -1,15 +1,73 @@ # Third-Party Notices — BookmarkMagic -**Runtime dependencies: None.** +Last updated: 2026-10-29 -The shipped extension bundles no third-party code. Parsing, serializing and -downloading use platform APIs only (`DOMParser`, `Blob`, `URL`, -`crypto.randomUUID`). +**No runtime dependencies are installed** — `package.json` has an empty +`dependencies` list (`docs/01 §4`). Two small MIT-licensed pieces are, +however, **compiled into** the shipped extension by the build, and their +notices travel with it in `THIRD_PARTY_NOTICES.txt` at the root of the package: -Build-time tooling (WXT, Vite, Svelte, TypeScript, Biome, Knip, Vitest) is not -distributed with the extension and is not listed here. All of it is +| Component | What ships | License | +|---|---|---| +| [Svelte](https://github.com/sveltejs/svelte) 5 | The runtime the compiler emits into each page (reactivity, DOM updates) | MIT | +| [@wxt-dev/browser](https://github.com/wxt-dev/wxt) | The one-line `browser` export: `globalThis.browser` when it exists, else `globalThis.chrome` | MIT | + +Neither contains network code; the extension's Content-Security-Policy forbids +it anyway (`docs/08 §3`). Parsing, serializing and downloading otherwise use +platform APIs only (`DOMParser`, `Blob`, `URL`, `URL.canParse`, +`Intl.Collator`, Web Locks, `BroadcastChannel`). + +Build-time tooling (WXT, Vite, TypeScript, Biome, Knip, Vitest, svelte-check) +is not distributed with the extension and is not listed here. All of it is MIT/Apache-2.0/ISC licensed and compatible with GPL-3.0-or-later. -If a runtime dependency is ever added — see `docs/01_TECH_STACK.md §4` for the -gated list — its name and full license text must be added to this file in the -same pull request, and the About tab must render it (`docs/14 §5`). +If a runtime dependency is ever added — see `docs/01 §4` for the gated list — +its name and full license text must be added here and to +`src/public/THIRD_PARTY_NOTICES.txt` in the same pull request, and the About +tab must say so (`docs/14 §5`). + +Licensing questions: **copyright@poli0981.dev**. + +## Svelte — MIT + +Copyright (c) 2016-2025 Svelte Contributors + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. + +## @wxt-dev/browser — MIT + +Copyright (c) Aaron Klinker + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. diff --git a/scripts/check-manifest.mjs b/scripts/check-manifest.mjs index d44279e..1dac300 100644 --- a/scripts/check-manifest.mjs +++ b/scripts/check-manifest.mjs @@ -85,6 +85,8 @@ const FORBIDDEN_KEYS = [ const REQUIRED_FILES = [ 'manager.html', 'popup.html', + // The MIT notices for the code the build compiles in (legal/THIRD_PARTY_NOTICES.md). + 'THIRD_PARTY_NOTICES.txt', '_locales/en/messages.json', '_locales/vi/messages.json', '_locales/ja/messages.json', diff --git a/src/public/THIRD_PARTY_NOTICES.txt b/src/public/THIRD_PARTY_NOTICES.txt new file mode 100644 index 0000000..a32c825 --- /dev/null +++ b/src/public/THIRD_PARTY_NOTICES.txt @@ -0,0 +1,59 @@ +BookmarkMagic — third-party notices +=================================== + +BookmarkMagic is free software under GPL-3.0-or-later. +No runtime dependencies are installed. Two MIT-licensed components are +compiled into this package: + + * Svelte 5 runtime https://github.com/sveltejs/svelte + * @wxt-dev/browser shim https://github.com/wxt-dev/wxt + +Source and licence: https://github.com/poli0981/bookmarkmagic + + +Svelte — MIT +------------ + +Copyright (c) 2016-2025 Svelte Contributors + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. + + +@wxt-dev/browser — MIT +---------------------- + +Copyright (c) Aaron Klinker + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. diff --git a/store/listing.en.md b/store/listing.en.md index df6a0b6..c0c7153 100644 --- a/store/listing.en.md +++ b/store/listing.en.md @@ -17,17 +17,19 @@ Move your bookmarks between browsers the simple way: with a file. No account. No cloud sync. 100% offline. WHAT IT DOES -• Import bookmark files (HTML, JSON, CSV) with a full preview before anything - is written — see counts, folders, and duplicates first. +• Import bookmark files (HTML, JSON, CSV) — including Chrome's own + "Bookmarks" file from your profile folder and Firefox JSON backups — with a + full preview before anything is written: counts, folders and duplicates + first. • Choose how to import: into a new dated folder (safe default), merge into - your existing folders, or replace everything (with an automatic safety - backup downloaded first). -• Skip duplicates automatically. + the folders you already have, or replace everything (it shows exactly what + will be deleted and saves a safety backup first). +• Can skip links you already have. • Export everything — or just the folders you pick — to HTML (works with Chrome, Edge, Brave, Firefox, Safari, Vivaldi, Opera), JSON, CSV, or Markdown. -• Edit your bookmark tree: search, rename, drag & drop, create folders, - delete, and find duplicate links. +• Edit your bookmark tree: search, rename, drag to move or reorder, sort a + folder A→Z, create folders, delete, and find duplicate links. PRIVACY BY DESIGN • Works entirely on your device. No servers, no analytics, no tracking. diff --git a/store/listing.ja.md b/store/listing.ja.md index 36d8be4..f419cdc 100644 --- a/store/listing.ja.md +++ b/store/listing.ja.md @@ -22,17 +22,19 @@ native pass (`docs/00 §10.9`). Review before relying on it for a listing edit. アカウント不要、クラウド同期なし、完全オフラインで動作します。 できること -• ブックマークファイル(HTML、JSON、CSV)をインポートします。書き込む前に - 必ずプレビューを表示し、件数・フォルダ・重複を先に確認できます。 +• ブックマークファイル(HTML、JSON、CSV)をインポートします。Chrome の + プロファイルフォルダにある「Bookmarks」ファイルや Firefox の JSON バック + アップにも対応。書き込む前に必ずプレビューを表示し、件数・フォルダ・重複 + を先に確認できます。 • インポート方法を選べます。日付付きの新しいフォルダに入れる(安全な既定 - 値)、既存のフォルダに統合する、またはすべて置き換える(この場合は安全 - のためのバックアップを先にダウンロードします)。 -• 重複したブックマークは自動でスキップできます。 + 値)、既存のフォルダに統合する、またはすべて置き換える(削除される内容を + 正確に示し、安全のためのバックアップを先に保存します)。 +• すでにあるリンクはスキップできます。 • すべて、または選んだフォルダだけを HTML(Chrome、Edge、Brave、Firefox、 Safari、Vivaldi、Opera で利用できます)、JSON、CSV、Markdown に エクスポートできます。 -• ブックマークツリーを編集できます。検索、名前の変更、ドラッグ&ドロップ、 - フォルダの作成、削除、重複リンクの検出。 +• ブックマークツリーを編集できます。検索、名前の変更、ドラッグでの移動と + 並べ替え、フォルダの A→Z 並べ替え、フォルダの作成、削除、重複リンクの検出。 設計としてのプライバシー • すべて端末上で動作します。サーバーも、分析も、トラッキングもありません。 diff --git a/store/listing.vi.md b/store/listing.vi.md index 7b900eb..81f78fb 100644 --- a/store/listing.vi.md +++ b/store/listing.vi.md @@ -19,17 +19,18 @@ Chuyển bookmark giữa các trình duyệt theo cách đơn giản nhất: b Không tài khoản. Không đồng bộ đám mây. Hoàn toàn offline. TIỆN ÍCH NÀY LÀM GÌ -• Nhập tệp bookmark (HTML, JSON, CSV) và xem trước đầy đủ trước khi ghi bất - cứ thứ gì — số lượng, thư mục và các mục trùng lặp đều hiện ra trước. +• Nhập tệp bookmark (HTML, JSON, CSV) — kể cả tệp "Bookmarks" của chính + Chrome trong thư mục hồ sơ và bản sao lưu JSON của Firefox — và xem trước + đầy đủ trước khi ghi bất cứ thứ gì: số lượng, thư mục và mục trùng lặp. • Chọn cách nhập: vào một thư mục mới theo ngày (mặc định an toàn), gộp vào - các thư mục sẵn có, hoặc thay thế toàn bộ (tệp sao lưu an toàn sẽ được tải - về trước). -• Tự động bỏ qua các mục trùng lặp. + các thư mục bạn đã có, hoặc thay thế toàn bộ (cho biết chính xác những gì + sẽ bị xóa và lưu bản sao lưu an toàn trước). +• Có thể bỏ qua các liên kết bạn đã có. • Xuất toàn bộ — hoặc chỉ những thư mục bạn chọn — ra HTML (dùng được với Chrome, Edge, Brave, Firefox, Safari, Vivaldi, Opera), JSON, CSV hoặc Markdown. -• Chỉnh sửa cây bookmark: tìm kiếm, đổi tên, kéo thả, tạo thư mục, xoá và tìm - các liên kết trùng lặp. +• Chỉnh sửa cây bookmark: tìm kiếm, đổi tên, kéo thả để di chuyển hoặc đổi + thứ tự, sắp xếp thư mục A→Z, tạo thư mục, xoá và tìm liên kết trùng lặp. RIÊNG TƯ NGAY TỪ THIẾT KẾ • Chạy hoàn toàn trên máy bạn. Không máy chủ, không phân tích, không theo dõi. diff --git a/tests/unit/links.test.ts b/tests/unit/links.test.ts index 6340e9b..c84d79f 100644 --- a/tests/unit/links.test.ts +++ b/tests/unit/links.test.ts @@ -1,4 +1,4 @@ -import { existsSync, readFileSync } from 'node:fs'; +import { existsSync, readdirSync, readFileSync } from 'node:fs'; import { basename, join } from 'node:path'; import { afterEach, describe, expect, it } from 'vitest'; import { getAppVersion } from '@/lib/browser/app-info'; @@ -106,10 +106,19 @@ describe('store listing', () => { // receipt of personal data legal/PRIVACY.md exists to bound. The address // belongs in SECURITY.md and CONTRIBUTING.md, where it arrives alongside // the instruction to sanitize first. - const source = readFileSync(join(REPO_ROOT, 'src', 'lib', 'links.ts'), 'utf8'); - const code = source.replace(/\/\*\*[\s\S]*?\*\//g, ''); - expect(code).not.toMatch(/mailto:/); - expect(code).not.toMatch(/@poli0981\.dev/); + // + // Widened in v1.1.0 from links.ts to everything under src/ — strings, + // components, locale files and the files src/public/ ships verbatim. + const offenders: string[] = []; + const walk = (dir: string): void => { + for (const entry of readdirSync(dir, { withFileTypes: true })) { + const path = join(dir, entry.name); + if (entry.isDirectory()) walk(path); + else if (/mailto:|@poli0981\.dev/.test(readFileSync(path, 'utf8'))) offenders.push(path); + } + }; + walk(join(REPO_ROOT, 'src')); + expect(offenders).toEqual([]); }); }); diff --git a/tests/unit/scripts/check-manifest.test.ts b/tests/unit/scripts/check-manifest.test.ts index 817d912..02faff0 100644 --- a/tests/unit/scripts/check-manifest.test.ts +++ b/tests/unit/scripts/check-manifest.test.ts @@ -37,6 +37,7 @@ const MANIFEST = { const FILES: Record = { 'manager.html': '', 'popup.html': '', + 'THIRD_PARTY_NOTICES.txt': 'notices', '_locales/en/messages.json': '{}', '_locales/vi/messages.json': '{}', '_locales/ja/messages.json': '{}', @@ -116,7 +117,7 @@ describe('check-manifest.mjs', () => { expect(output).toContain('missing expected top-level key(s): content_security_policy'); }); - it.each(['_locales/vi/messages.json', 'icon/128.png', 'popup.html'])( + it.each(['_locales/vi/messages.json', 'icon/128.png', 'popup.html', 'THIRD_PARTY_NOTICES.txt'])( 'fails when %s is missing from the build', (file) => { const { status, output } = check(build(MANIFEST, { [file]: null }));