diff --git a/CLAUDE.md b/CLAUDE.md index 46c5703..2e138d6 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -141,6 +141,13 @@ the tag and performs the store update per docs/13 §1b. things appear to work, but knip reports every devDependency unused and `verify` fails; `tsconfig.json` extends `./.wxt/tsconfig.json`, which `wxt prepare` generates. + **Type resolution walks up too, and it does so even after a correct `npm ci`.** + A worktree under `E:\bookmarkmagic\.claude\worktrees\` inherits + `E:\bookmarkmagic\node_modules\@types\*`, so `npm run check` can pass locally + on types the package does not declare and CI does not have. That is exactly + how a missing `@types/node` survived a green local `verify` and failed CI on + the first push. A green local type-check in a worktree is weaker evidence than + it looks. - When a browser fixture contradicts the format spec: add the fixture, make the parser tolerant, note the quirk in code + docs/04 §1.2, then continue. - Do not invent features not in docs; park ideas as `docs/15` roadmap PRs. diff --git a/docs/01_TECH_STACK.md b/docs/01_TECH_STACK.md index e027a55..def487b 100644 --- a/docs/01_TECH_STACK.md +++ b/docs/01_TECH_STACK.md @@ -25,6 +25,7 @@ | @wxt-dev/module-svelte | latest at scaffold | WXT ↔ Svelte integration. | | **Biome** | **2.5.2 (pinned exact)** | Lint + format (replaces ESLint + Prettier). Install with `npm i -D -E @biomejs/biome` per Biome guidance. | | svelte-check | ^4.7.4 | Type/template authority for `.svelte` files. | +| **@types/node** | **^24** (matches the Node major) | Types for `node:fs`, `node:path`, `node:child_process` and `process`, which the test suite and `scripts/*.mjs` genuinely use. **Declared explicitly since 2026-08-03** — it used to arrive transitively, and WXT 0.21 stopped providing it. Types only: erased at build, so hard rule 2 (zero *runtime* dependencies) is untouched. | | jsdom | **^30** (was ^29 through v1.0.0) | Test DOM. Not interchangeable — `02 §3` picks jsdom over happy-dom because the Netscape walk depends on parse5's implied-end-tag behaviour. A major bump runs `tests/unit/dom-environment.test.ts` first; if that canary fails, pin rather than loosen the test. | | **Knip** | **^6** (6.29.0 latest as of 2026-07) | Dead code: unused files, exports, dependencies. Requires Node ≥ 20.19. v6 swapped the TypeScript backend for oxc-parser — confirm `compilers.svelte` is still the supported `.svelte` hook before scaffold (`10 §4`). | | **Vitest** | latest stable at scaffold | Unit tests for `src/lib/core`. | diff --git a/package-lock.json b/package-lock.json index c80dd23..c4bfbe6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,17 +1,18 @@ { "name": "bookmarkmagic", - "version": "1.0.0", + "version": "1.0.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "bookmarkmagic", - "version": "1.0.0", + "version": "1.0.1", "hasInstallScript": true, "license": "GPL-3.0-or-later", "devDependencies": { "@biomejs/biome": "2.5.5", "@sveltejs/vite-plugin-svelte": "^7.2.0", + "@types/node": "^24.13.3", "@vitest/coverage-v8": "^4.1.10", "@wxt-dev/module-svelte": "^2.0.5", "jsdom": "^30.0.1", @@ -1776,6 +1777,16 @@ "dev": true, "license": "MIT" }, + "node_modules/@types/node": { + "version": "24.13.3", + "resolved": "https://registry.npmjs.org/@types/node/-/node-24.13.3.tgz", + "integrity": "sha512-Dh8vAsV36ig5wa9OX4pXvMc9D3Veibfw2wix0CUwYODLD8nkj9UsLjASr49nPg+2eKzxhBV+v7L8pXvT4e639Q==", + "dev": true, + "license": "MIT", + "dependencies": { + "undici-types": "~7.18.0" + } + }, "node_modules/@types/trusted-types": { "version": "2.0.7", "resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz", @@ -4404,6 +4415,13 @@ "node": ">=22.19.0" } }, + "node_modules/undici-types": { + "version": "7.18.2", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-7.18.2.tgz", + "integrity": "sha512-AsuCzffGHJybSaRrmr5eHr81mwJU3kjw6M+uprWvCXiNeN9SOGwQ3Jn8jb8m3Z6izVgknn1R0FTCEAP2QrLY/w==", + "dev": true, + "license": "MIT" + }, "node_modules/unimport": { "version": "6.3.1", "resolved": "https://registry.npmjs.org/unimport/-/unimport-6.3.1.tgz", diff --git a/package.json b/package.json index b926fb2..32da391 100644 --- a/package.json +++ b/package.json @@ -39,6 +39,7 @@ "devDependencies": { "@biomejs/biome": "2.5.5", "@sveltejs/vite-plugin-svelte": "^7.2.0", + "@types/node": "^24.13.3", "@vitest/coverage-v8": "^4.1.10", "@wxt-dev/module-svelte": "^2.0.5", "jsdom": "^30.0.1",