fix(ci): a missing Discord webhook must not fail a good release
The real v1.0.0 run went red. The release job itself succeeded — the GitHub Release, bookmarkmagic-1.0.0-chrome.zip and SHA256SUMS.txt all published, and `sha256sum -c` verifies against the downloaded asset. Only `announce` failed, with "No webhooks configured", because DISCORD_RELEASES_WEBHOOK and DISCORD_REPO_WEBHOOK are unset — which docs/12 §5 lists as optional. A red run on a correct release is worse than a missing announcement: it trains you to stop reading the colour. `continue-on-error: true` on the announce job. The tag_override fix from the Phase 5 review did work — the job reached the webhook check, which it could only do after resolving the tag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
9c6ecaaa75
commit
5f4c6e7b1f
2 files changed
+14
No files matched your search
@@ -78,6 +78,13 @@ jobs:
|
||||
# would silently never fire.
|
||||
announce:
|
||||
needs: release
|
||||
# A Discord notification is not part of the release. The reusable exits 1
|
||||
# on "No webhooks configured" when DISCORD_RELEASES_WEBHOOK and
|
||||
# DISCORD_REPO_WEBHOOK are both unset (docs/12 §5 lists them as optional),
|
||||
# which turned the v1.0.0 run red even though the Release, the zip and
|
||||
# SHA256SUMS.txt had all published correctly. A red run on a good release
|
||||
# is worse than a missing announcement: it trains you to ignore the colour.
|
||||
continue-on-error: true
|
||||
uses: poli0981/.github/.github/workflows/announce-release.yml@main
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
@@ -203,6 +203,7 @@ jobs:
|
||||
|
||||
announce:
|
||||
needs: release
|
||||
continue-on-error: true # see below
|
||||
uses: poli0981/.github/.github/workflows/announce-release.yml@main
|
||||
permissions:
|
||||
contents: read
|
||||
@@ -211,6 +212,12 @@ jobs:
|
||||
secrets: inherit
|
||||
```
|
||||
|
||||
`continue-on-error` because the reusable exits 1 on "No webhooks configured"
|
||||
when both Discord secrets are unset — which §5 lists as optional. On the real
|
||||
v1.0.0 run the Release, the zip and `SHA256SUMS.txt` all published correctly
|
||||
and the run still showed red. A red run on a good release trains you to ignore
|
||||
the colour, so the notification must not be able to fail the release.
|
||||
|
||||
`tag_override` is **required here**, and for the same reason the announcement
|
||||
is a job rather than a caller. The reusable resolves
|
||||
`TAG="${INPUT_TAG:-$EVENT_TAG}"` with `EVENT_TAG = github.event.release.tag_name`
|
||||
|
||||
Reference in new issue
Block a user